Adding switch(){} statement to jasshelper (good/bad idea)?

[GetTriggerUnit-]

I had the idea, while doing c++, to suggest adding the switch statement to jasshelper. (For those who don't know what the switch statement is: Switch statement)

Exemple

function Test takes nothing returns nothing
    local integer value=15
    switch(value)
        case 5 {
            call DoSomething(5)
            break
        }
        case 10 {
            call DoSomething(10)
            break
        }
        case 15 {
            call DoSomething(15)
            break
        }
        default {
            call DoNothing()
            break
        }
    endswitch
endfunction

Good idea? Opinions please .

[jomik]

Well, your example looks like it could be rewritten to:

function Test takes nothing returns nothing
    local integer value=15
    if (value != 0)
        call DoSomething(value)
    endif
endfunction

But if it is what I think it is, then it's goodies
But it can already be made with if statements?

[Tyrulan]

If statements yes, but this is more organized. I like it. Plus shorter to write if you have many conditions you avoid long statements ... or or or and or or and and or....

[GetTriggerUnit-]

Basicly, it would be rewriten with if statements but the main idea is that it's shorter to write and looks neater, Imo..

[kingkingyyk3]

Suggest to cJass, it uses c style. vJass is fine, if you want to use shortcut, use Zinc.

[Lyerae]

Switch could be useful.

[GetTriggerUnit-]

[ertaboy356b]

switch is useful.. I mostly use it if I have a lot of if statements..

[Lyerae]

Yeah.
I'd remove the endswitch keyword though.

[Jesus4Lyf]

It is all crap. It is more efficient (and perhaps even readable) if you have enough cases to do:

function Test takes nothing returns nothing
    local integer value=15
    call MySwitchCases[value].evaluate()
endfunction

And fill "MySwitchCases" with function pointers on init.

Heck, you can make MySwitchCases a trigger array directly and add triggers with conditions and just do call TriggerEvaluate(MySwitchCases[value]).

(Switch is just an O(n) complexity way of doing this, so to speak.)

[Nestharus]

In JASS, it really wouldn't matter whether you were using a switch statement or a set of ifs. In compiled programming, the switch statement immediately goes to the set case. In compiled programming, switch statements are faster than ifs -.-, but this isn't compiled programming is it? It's interpretive, so it really doesn't matter which way or the other .


Jesus4Lyf's a good idea for maintainability and for speed if you end up having a million else ifs.

I don't believe a switch statement would merit any benefit whatsoever to the JASS language ;D.

[Tyrulan]

It's user friendly. To me, anyway.

[Xorifelse]

This would not be really possible in Jass, because if 1 case returns true it should execute every case below as well.
Meaning this can only be done with a lot of preset booleans for a case.

So your example should be converted to this:

function Test takes nothing returns nothing
    local integer value=15
    local boolean a = false
    local boolean b = false
    local boolean break = false

    if( value == 5 ) then
        set a = true
        set break = true
        call DoSomething(value)
    elseif (value == 10) or ((break == false) and (a == true)) then
        set b = true
        set break = true
        call DoSomething(value)
    elseif (value == 15) or ((break == false) and (b == true)) then
        call DoSomething(value)
    elseif (true) and ( (break == false) and (a == false) and (b == false)) then // dunno if default switch case is executed when every case returns false, otherwise it's a simple "elseif true then")
        call DoNothing()
        // The last break here in your code does not make any sense.
    endif
endfunction

Perhaps this code is not fully accurate in the way switch really works but you should get the idea. This causes a lot of technical difficulties and a lot of more compute time as well.

If-then-else works good, if you don't like the syntax use zinc, otherwise don't complain.

[T.s.e]

I really don't see what the point of this is.

[Nestharus]

You and me both

In JASS, it really wouldn't matter whether you were using a switch statement or a set of ifs. In compiled programming, the switch statement immediately goes to the set case. In compiled programming, switch statements are faster than ifs -.-, but this isn't compiled programming is it? It's interpretive, so it really doesn't matter which way or the other .


Jesus4Lyf's a good idea for maintainability and for speed if you end up having a million else ifs.

I don't believe a switch statement would merit any benefit whatsoever to the JASS language ;D.