Does this leak?

Here's a trigger I'm using as part of a spell, but I'm not sure if the variables TempAngle and TempAngle2 are leaking.


Any help would be great, thanks

Facing angles are reals, and reals don't leak, so no, the trigger doesn't leak.

Looks good, but your second condition is checking if the target is in a unit group. That would mean you've set this group somewhere else. so either you destroyed it there and then this trigger will never fire or it will leak because that group is still sitting around.

You would need to set that group at the start of the trigger and destroy it at the end rather

What exactly is the problem with an existing group: udg_IllusionistIllusions? Why would it "either be destroyed when it was set" or "leak"?

Does having units in a group cause leaks? (As far as I knew, it only leaks if you have no reference to whatever is in the group... and then you destroy the group[??]... otherwise, it is just taking up memory, as it should be. No?)

ZakkWylde- said:

What

Click to expand...

You are right, you don't have to destroy something if you are going to use it.

I understood it as, groups etc that aren't destroyed (even when set to variables) leak. The whole reason we set them to variables is that we need to destroy them so a reference is required.

whats the difference between using an un-set group compared to setting a group and not destroying it? either way it sits around in the memory

From the trigger, the Unit Group does not leak. It's just a dynamic unit group variable.

> ...we set them to variables is that we need to destroy them so a reference is required.
Yes. But setting a variable to a certain value does not mean it's a leak.
Is the above Point variable leaking?

I would say yes, but you've got me doubting myself now :/

Well you can try it out yourself.

Or think on another point of view. Use units instead.
Will Unit2 still be around in the map?
If it's not around in the map, does it leak?

Ps: RemoveUnit is typically 'Unit - Remove Unit' in GUI. Was just use the custom script to avoid confusion.

Well...hmm

Ok, so I made this trigger for a test

The results I got was:
1 Footman Remianed, ofcourse they other has removed.
But both unit variables still retained the unit as they were not set == null so the handles remained
Point wise, MyPointX and Y both retained their values while MyPoint2 X and Y were 0. (Map Center) which is the default of a non-existant point.

So what I take away from this is:
Locations, Groups, Forces, SFX need to be destroyed
All handles need to be nulled

inevit4ble said:

Looks good, but your second condition is checking if the target is in a unit group. That would mean you've set this group somewhere else. so either you destroyed it there and then this trigger will never fire or it will leak because that group is still sitting around.

You would need to set that group at the start of the trigger and destroy it at the end rather

Click to expand...

There are 2 other triggers attached to this spell, one which adds an illusion to the unit group as soon as it's created, and another which removes it when it dies, the unit group is a constant rolling selection of units. Thanks for the help everyone, cleared up some minor niggling doubts

vypur85 said:

From the trigger, the Unit Group does not leak. It's just a dynamic unit group variable.

> ...we set them to variables is that we need to destroy them so a reference is required.
Yes. But setting a variable to a certain value does not mean it's a leak.

Code:

Set Point = Position of Someunit
Set Point2 = Point
Custom Script:  call RemoveLocation (udg_Point2)

Is the above Point variable leaking?

Click to expand...

Point wouldn't be "leaking," it would just be using memory. It would leak if you called this again without first removing Point, right?

As for the unit example, it seems slightly different, and it confuses me. I feel that Unit2 will be pointing to something non-existent, but still--it wouldn't actually leak unless you set Unit2 to something else without removing it...right? Or am I lost

Both don't leak. I was just using Unit as an example because it's more of a tangible object as compared to Point, which you can't really see. Both are essentially the same concept.

Then again, this is based off my old knowledge. In the past, this was considered fine and not leaking.


> inevit4ble
Your test trigger is not similar with the trigger I posted.

vypur85 said:

Both don't leak. ...

Click to expand...

Unless you set them again without removing them, right?
If you set them to something else, then isn't that 'original' location (or unit) just sitting around in memory with no reference to it (i.e. leak?) ?

That is why I used the Unit as example. By removing Unit2, do you think Unit still exist? If it doesn't exist, does it leak?

Leak occurs if you lose reference to a certain object. Both Unit and Unit2 are references to a single object. By removing either one, you have successfully remove the single object. So it doesn't leak.

(I believe in JASS, you'd need to null both the variables, but for GUI, it's fine.)