Hero Revive and Death Clock Error

Kayoss666

Kayoss666

Member
Reaction score
7
i am just getting the hang of Jass but this code is just not working at all but jasshelper finds no problems with it. So i am assuming i inserted something right but not for what i want. i commented to the three spots i think the error could be but i don't know Jass good enough to tell.

JASS:
function Trig_ReviveHero_Conditions takes nothing returns boolean
    if ( not ( IsUnitType(GetDyingUnit(), UNIT_TYPE_HERO) == true ) ) then
        return false    //^^error might be here not sure if IsUnitType was set up right
    endif
    return true
endfunction
 
function Trig_ReviveHero_Actions takes nothing returns nothing
    if ( Trig_ReviveHero_Conditions() and GetLocalPlayer()==GetOwningPlayer(GetDyingUnit()) ) then //also this if state might be the cause
        set udg_deathtollwindow[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))] = CreateTimerDialog(udg_deathtoll[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))]) 
        call TimerDialogDisplay(udg_deathtollwindow[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))], true)
        call TimerDialogSetTitle(udg_deathtollwindow[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))], "Revive") 
        call TimerStart( udg_deathtoll[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))], 40.00, false, null)
        call TriggerSleepAction( 40.00 )
        call PanCameraToTimedLocForPlayer( GetOwningPlayer(GetDyingUnit()), udg_Restart_point[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))], 0 )
        call ReviveHeroLoc( GetDyingUnit(), udg_Restart_point[(GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit())))], false )
        call DestroyTimerDialog(udg_deathtollwindow[GetConvertedPlayerId(GetOwningPlayer(GetDyingUnit()))])
    else
        call DoNothing( )
    endif
endfunction
 
//===========================================================================
function InitTrig_ReviveHero takes nothing returns nothing
    set gg_trg_ReviveHero = CreateTrigger(  )
    //The error might be in the player part on next line but i believe it should work.vv
    call TriggerRegisterPlayerUnitEvent(gg_trg_ReviveHero, GetOwningPlayer(GetDyingUnit()), EVENT_PLAYER_UNIT_DEATH, null)
    call TriggerAddAction( gg_trg_ReviveHero, function Trig_ReviveHero_Actions )
endfunction
 
PurgeandFire

PurgeandFire

zxcvmkgdfg
Reaction score
509
In the register event line:
JASS:
call TriggerRegisterPlayerUnitEvent(gg_trg_ReviveHero, GetOwningPlayer(GetDyingUnit()), EVENT_PLAYER_UNIT_DEATH, null)


GetDyingUnit() is null (at least at that point in time). The InitTrig functions are called on map initialization, but they don't actually correspond to the events that are being registered. For example, if you made an event for a unit being summoned, you cannot register it like this:
JASS:
call TriggerRegisterUnitEvent(t, GetSummonedUnit(), EVENT_UNIT_SUMMONED)

It expects a particular unit. Since InitTrig functions are simply called on initialization, rather than in response to some event, GetSummonedUnit() will simply return null.

The fix would be to either manually loop through all players to register it, or simply use this function for it:
JASS:
call TriggerRegisterAnyUnitEventBJ(gg_trg_ReviveHero, EVENT_PLAYER_UNIT_DEATH)


I haven't checked the rest of the code though, but hopefully that'll get you started.
 
Kayoss666

Kayoss666

Member
Reaction score
7
Thank you I now have it working and i think this will help on some of my other problems so double thanks.
 
DrEvil

DrEvil

FCRI Associate!
Reaction score
111
To add some further help with learning jass we should try to understand the generated condition.
JASS:
function Trig_ReviveHero_Conditions takes nothing returns boolean
    if ( not ( IsUnitType(GetDyingUnit(), UNIT_TYPE_HERO) == true ) ) then
        return false    //^^error might be here not sure if IsUnitType was set up right
    endif
    return true
endfunction


Why Blizzard decided to generate conditions this way is beyond my understanding but it makes it pretty useless to learn from when you are just starting.

So what happens if a unit is a hero?
E.g. IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO) returns true, because the unit is a hero.

JASS:
if( not ( true == true ))then
      return false
endif
return true
 
if( not (true))then
    return false
endif
return true
 
if( false == true)then  
// not is basically comparing it to false
//not(false) === true
//(false == false) ===true
    return false
endif
return true


If a unit type is of hero the if statement returns false and ends, then returns true.
But if a unit type is not a hero, the if statement will be true and return false.

But we already know that IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO) will give a true value if a unit is a hero, or false if the unit is non-hero.
The return type of the function is boolean (true/false) so you can just return the value of the IsUnitType function

JASS:
function Trig_ReviveHero_Conditions takes nothing returns boolean
     return IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO)
endfunction
 
// or if you wanted to only add units if they were non-heroes you could return the inverse of the function 
 
return not(IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO))
return !(IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO))
return IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO)==false
return  false==IsUnitType(GetDyingUnit(),UNIT_TYPE_HERO)
// these four returns all do the same thing
// 1. is a function call, but one function call is really nothing to worry about performance wise
// 2. is shorthand for changing the sign (comparing to false)
// 3 & 4. it doesn't matter which way you compare false to
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/
  • The Helper The Helper:
    Here is another comfort food favorite - Million Dollar Casserole - https://www.thehelper.net/threads/recipe-million-dollar-casserole.193614/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      385 (members: 0, guests: 385)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top