.

luorax

Invasion in Duskwood
Reaction score
67
JASS:
globals
    private integer array BlackList
    private integer StackLevel=0
endglobals

private function AddToList takes integer id returns nothing
    set StackLevel=StackLevel+1  // Not giving value to "BlackList[0]"
    set BlackList[StackLevel]=id
endfunction

private function Filter takes unit toFilter returns boolean
    local integer id=GetUnitTypeId(toFilter)
    local integer i=1
    loop
        exitwhen i>StackLevel
        if id==BlackList<i> then
            return false
        endif
        set i=i+1
    endloop
    return true
endfunction</i>


Simple as that. Alternatively, if those units share an attribute (like they're all creeps, etc), you can create a Sphere based dummy ability and check if the unit has that ability. That's what I'm doing on my map for heroes, creeps, minions, towers, and so forth.
 

NoobImbaPro

You can change this now in User CP.
Reaction score
60
Dude learn jass more and then come to make scripts, arrays are your best friend. Do as luorax says.
Try to make more things with arrays until you learn them for good. Don't stop only on what they give you.
 

tommerbob

Minecraft. :D
Reaction score
110
Dude learn jass more and then come to make scripts, arrays are your best friend. Do as luorax says.
Try to make more things with arrays until you learn them for good. Don't stop only on what they give you.

Your comment is both rude and unnecessary, learn some respect. If you have nothing constructive to add to the conversation, don't say anything.
 

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)
Reaction score
216
Actually the best way would be using array for O(1) checking, either table or hashing unit id into array will do.
JASS:
library Test requires Table initializer OnInit

globals
    private Table UnitTypeFilter
endglobals

function BlacklistUnitType takes integer uid returns nothing
    set UnitTypeFilter[uid]=1
endfunction

function IsUnitTypeBlacklisted takes integer uid returns boolean
    return UnitTypeFilter[uid]==1
endfunction

private function OnInit takes nothing returns nothing
    set UnitTypeFilter=Table.create()
endfunction

endlibrary

When the blacklist becomes bigger, this script will become faster than O(n) searching, which was introduced in luorax and your script.
 

NoobImbaPro

You can change this now in User CP.
Reaction score
60
@tommerbob
So giving some helpful advice became disrespectful?
If everyone came here after reading only "if then else" and wrote his question about making something better
without giving a try himself it wouldn't be a spam?

@kingkingyyk3
He should first learn O(n) complexity with loops before coming to O(1) hashed in arrays, but well done mate.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    If you are new to the site please check out the Recipe and Food Forum https://www.thehelper.net/forums/recipes-and-food.220/
  • Monovertex Monovertex:
    How come you're so into recipes lately? Never saw this much interest in this topic in the old days of TH.net
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top