A little help with skill trigger, it isn't working

[Stratoss]

Event
Unit - A unit begins Casting an ability

Conditions
(Ability being cast) Equal to Finishing Blow

Actions
Set caster = (casting unit)
Set target = (targeted unit)
Animation - Play caster's attack animation
Unit - Cause caster to damage target , dealing damage of attack type Hero and damage type normal

If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(target is dead) Equal to True
(target is a Hero) Equal to True

Then - Actions
Floating text - Create floating text that reads +1 AGI! with Z offset 0.00 using font size 10.00, color (100%, 0%, 0%), and 0.00% transparency
Hero - Modify Agility of caster : Add 1

Else - Actions
Do Nothing

Animation - Reset caster Animation
_______________________________

I can't seem to get the trigger above to work, it does the damage but it doesn't add the 1 Agi when the enemy hero dies. (Nor shows the floating text). Please help and thanks.

 

[Rad]

Add a wait?

 

[Grundy]

try to change "target is dead equal to true" to something like "current hp of target is less than or equal to 0"

 

[Stratoss]

I've added a wait button, and changed it to check for target's hp instead of whether he's dead, but it's still not working

 

[Grundy]

copy your exact trigger as text (right click on the name of the trigger and select copy as text) and post it here


oh yea put it inside code tags too, makes it easier to read.

 

[Stratoss]

Finishing Blow
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to Finishing Blow 
    Actions
        Set caster = (Casting unit)
        Set target = (Targeted unit)
        Animation - Play caster's attack animation
        Unit - Cause caster to damage target, dealing 250.00 damage of attack type Hero and damage type Normal
        Wait 0.10 game-time seconds
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((target is A Hero) Equal to True) and ((Life of target) Less than or equal to 0.00)
            Then - Actions
                Floating Text - Create floating text that reads +1 AGI! above caster with Z offset 0.00, using font size 10.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
                Hero - Modify Agility of caster: Add 1
            Else - Actions
                Do nothing

 

[Grundy]

Set target = (Targeted unit)

that should be set target = target of ability being cast

nevermind that MUST work if its doing damage to target....

try this
put 2 more if/then/else things before that one you already ahve (for 3 total)

in the first one make the condition (target is a hero equal to true)
then: game message - display text to all players "Target is a hero"
else: game message - display text to all players "Target is not a hero"

next one:
if condition: target's current life is less than or equal to 0.00
then: game message - display text to all players "Target's life is less than or equal to 0"
else: game message - display text to all players "Target's life is not less than or equal to 0"

and see what messages it shows when you use it

 

[Stratoss]

Ok, thanks, after changing to "target = target of ability being casted" it started working well.

 

[Ruination]

That is really weird since the targetted unit worked for doing the damage. What does the targetted unit even have to do with adding one agil to the casting unit. :nuts:

 

[Stratoss]

ok, after getting the agi buff to work the animation stops working

Updated trigger codes:

Finishing Blow
    Events
        Unit - A unit Begins casting an ability
    Conditions
        (Ability being cast) Equal to Finishing Blow 
    Actions
        Set caster = (Casting unit)
        Set target = (Target unit of ability being cast)
        Animation - Play caster's attack animation
        Wait 0.50 game-time seconds
        Unit - Cause caster to damage target, dealing 250.00 damage of attack type Hero and damage type Normal
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                ((target is A Hero) Equal to True) and ((Life of target) Less than or equal to 0.00)
            Then - Actions
                Floating Text - Create floating text that reads +1 AGI! above caster with Z offset 0.00, using font size 10.00, color (100.00%, 0.00%, 0.00%), and 0.00% transparency
                Hero - Modify Agility of caster: Add 1
            Else - Actions
                Do nothing

 

[AgentPaper]

maybe put the animation line above the "new" target set one? i dunno, worth a try.

 

[Grurf]

Reset the caster's animation at the end of the trigger.