System Advanced Indexing & Data Storage

mysteriis

New Member
The error happens when I try to save it for the first time. When I delete the "!" it goes okay. I think we should save it first with the "!" and then reopen the map and delete, right?
 

tooltiperror

Super Moderator
No. Simply delete the "!" and get it to save, then copy the ability, then scroll down to this line in the script:
JASS:
        private constant integer LEAVE_DETECTION_ABILITY = 'AIDS'

And go to the ability in your World Editor, and press CTRL-D to see its rawcode. Replace [ljass]'AIDS'[/ljass] with your rawcode.
 

WolfieeifloW

WEHZ Helper
So, I've never used one of your systems J4L, because frankly, you confuse me :p
But it's come to my attention that using Damage will greatly benefit my map, so I'm going to use it.

But I have a quick question.
I didn't see it anywhere in the documentation, but I've heard that AIDS 'breaks' [ljass]GetUnitUserData()[/ljass] and [ljass]SetUnitUserData()[/ljass]?
Now, I see [ljass]GetUnitIndex()[/ljass], which I assume is the replacement for [ljass]GetUnitUserData()[/ljass];
However, I didn't see a [ljass]SetUnitIndex()[/ljass] function?

My 'combo point' system in my map uses user data's, so how would I go about fixing that 'system' to work with AIDS so that, ultimately, I can finally use Damage :p ?

Oh, and also, where's the TESH highlighting for this system ;) ?
 

tooltiperror

Super Moderator
You can't use [LJASS]SetUnitUserData[/LJASS] if you use AIDS, or else you break it.

Instead, you use AIDS structs. You use a textmacro because Jesus4Lyf is a lazy bastard [noparse]<3[/noparse]

An AIDS struct is a struct which is made every time a unit enters the map, and the unit is then available as [ljass]this.unit[/ljass].

You make an AIDS struct by putting [LJASS]//! runtextmacro AIDS()[/LJASS] at the very last line of your struct, right before [ljass]endstruct[/ljass]. You also have to extend array. Then you get access to a few cool methods:
  1. [ljass]static method AIDS_filter takes unit u returns boolean[/ljass] --- Every unit that enters the map is passed to this method. If true, it creates a struct of this kind.
  2. [ljass]method AIDS_onCreate takes nothing returns nothing[/LJASS] --- This is run for units that pass the filter. You can now use [LJASS]this.unit[/LJASS].
  3. [ljass]method AIDS_onDestroy takes nothing returns nothing[/LJASS] --- Ran when a unit is killed.
  4. [ljass]static method AIDS_onInit takes nothing returns nothing[/LJASS] --- This is because Jesus4Lyf took your onInit method.
 

WolfieeifloW

WEHZ Helper
Hmm..
Like I said, too advanced I think.

I have to create a struct for every script that wants to use UserData?

Maybe you could take a look at my system, and edit it to use AIDS?
I could probably figure it out once I see my own script changed to use it.
To avoid posting code unrelated to AIDS here, I'll just link to pastebin.
I don't like people doing stuff for me (Considering that's not what we're here for), but like I said, seeing my own script modified for AIDS would probably help me get it.
 

tooltiperror

Super Moderator
If I understand your script, this should be good.
Also, I don't see why you would need Damage for this :p
JASS:
struct Combo extends array
    integer combo // The number of combo points a unit has

    private static method AIDS_onEffect takes nothing returns boolean
        local thistype this
        local boolean spell = GetSpellAbilityId()==mangle or GetSpellAbilityId()==claw // Because hardcoding is bad

        if GetUnitTypeId(GetTriggerUnit())==feralDruid and spell then
            set this=thistype[GetTriggerUnit()] // thistype[x] - Return the Combo struct for the unit x
            if this.combo!=5 then
                call UnitRemoveAbility(this.unit, combo[this.combo]) // Does JASS allow combo and combo[]? I hope so, else you have to rename combo.
                set this.combo=this.combo+1
                call UnitAddAbility(u, combo[this.combo])
            endif
        endif
        return false
    endmethod
    private static method AIDS_onCreate takes nothing returns nothing
        set this.combo=0 // in case of revival and such
    endmethod
    private static method AIDS_onInit takes nothing returns nothing
        local trigger trig=CreateTrigger()
        local integer index=0
        
        call TriggerAddCondition(trig, Condition(thistype.onEffect))
        loop
            call TriggerRegisterPlayerUnitEvent(trig, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
            set index=index+1
            exitwhen index==bj_MAX_PLAYER_SLOTS
        endloop
    endmethod
    //! runtextmacro AIDS()
endstruct
 

Ayanami

칼리
Couldn't he do this?

JASS:

library Combo initializer OnInit uses AIDS, GT

globals
    private constant integer UNIT_ID = 'h000' // raw code of unit feral druid
    private constant integer MANGLE_ID = 'A000' // raw code of ability mangle
    private constant integer CLAW_ID = 'A001' // raw code of ability claw
    private integer array COMBO
    
    public integer array Data
endglobals

private function OnCast takes nothing returns boolean
    local unit u = GetTriggerUnit()
    local integer id
    
    if GetUnitTypeId(u) == UNIT_ID then
        set id = GetUnitId(u)
        if Data[id] != 5 then
            call UnitRemoveAbility(u, COMBO[Data[id]])
            set Data[id] = Data[id] + 1
            call UnitAddAbility(u, COMBO[Data[id]])
        endif
    endif

    set u = null
    return false
endfunction

private function OnInit takes nothing returns nothing
    local trigger t = CreateTrigger()
    call GT_RegisterStartsEffectEvent(t, MANGLE_ID)
    call GT_RegisterStartsEffectEvent(t, CLAW_ID)
    call TriggerAddCondition(t, Condition(function OnCast))
    set t = null
    
    // set up your COMBO array values
endfunction

endlibrary


Then for your Combo system, if you ever need to use GetUnitUserData() or SetUnitUserData() outside of the Combo library, you could just do:

JASS:

library Example uses Combo
    private function Example takes nothing returns nothing
        local unit u = SomeUnit // just an example, let's say it's a unit
        local integer i

        set Combo_Data[GetUnitId(u)] = 1 // use this instead of SetUnitUserData(u, 1)
        
        set i = Combo_Data[GetUnitId(u)] // use this instead of GetUnitUserData(u)
    endfunction
endlibrary


This would work, right?
 

tooltiperror

Super Moderator
Yeah, that's a good way if you like procedural/functional programming.
 

WolfieeifloW

WEHZ Helper
I thought I needed to trigger all damage in my map when using Damage?
Also, maybe you modifying it won't help :p , still confusing.
 

Laiev

Hey Listen!!
You need, but in some cases (like mine), I'll trigger damage dealt by units attacks too, so Damage is not like the most perfect as should be, but still my choice to use it (since I use most of resources by Jesus4Lyf)
 

WolfieeifloW

WEHZ Helper
Here's the ComboPoints library:
JASS:
library ComboPoints initializer onInit uses AIDS, GT

    globals
        integer array COMBO
        public integer array Data
    endglobals

    private function onCast takes nothing returns boolean
        local unit u = GetTriggerUnit()
        local integer id
        
        if GetUnitTypeId(u) == feralDruid then
            set id = GetUnitId(u)
            if Data[id] != 5 then
                call UnitRemoveAbility(u, COMBO[Data[id]])
                set Data[id] = Data[id] + 1
                call UnitAddAbility(u, COMBO[Data[id]])
            endif
        endif
        set u = null
        return false
    endfunction
    
    private function OnInit takes nothing returns nothing
        call TriggerAddCondition(GT_RegisterStartsEffectEvent(CreateTrigger(), mangle), Condition(function onCast))
        call TriggerAddCondition(GT_RegisterStartsEffectEvent(CreateTrigger(), claw), Condition(function onCast))
        
        // set up your COMBO array values
        set COMBO[0] = 'A009'
        set COMBO[1] = 'A00E'
        set COMBO[2] = 'A00F'
        set COMBO[3] = 'A00G'
        set COMBO[4] = 'A00H'
        set COMBO[5] = 'A00I'
    endfunction

endlibrary
I think that's all good and fine, it compiles with no errors.
However, my one spell where it uses up combo points has a compile error:
Undeclared variable COMBO_Data (On the local integer)
JASS:
scope FerociousBite initializer init

    private function Chance takes integer level returns integer
        return level * 2
    endfunction

    private function Damage takes integer level returns real
        return (level * 0.5) + 0.5
    endfunction
    
    private function Conditions takes nothing returns boolean
        local real fbDamage
        local unit u = GetTriggerUnit()
        //local integer ud = GetUnitUserData(u)
        local integer UD = COMBO_Data[GetUnitId(u)]
        
        if (GetSpellAbilityId() == ferociousBite and UD &gt; 0) then
            set fbDamage = (GetHeroAgi(u, true) * Damage(UD))
            call UnitDamageTarget(u, GetSpellTargetUnit(), fbDamage, true, false, ATTACK_TYPE_MELEE, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)
            call UnitRemoveAbility(u, COMBO[UD])
            if (GetRandomInt(1, 100) &lt;= Chance(GetUnitAbilityLevel(u, ferociousBite)) and UD &gt;= 4) then
                //call SetUnitUserData(u, ud - 3)
                set UD = UD - 3
            else
                //call SetUnitUserData(u, 0)
                set UD = 0
            endif
            call UnitAddAbility(u, COMBO[UD])
        elseif (GetSpellAbilityId() == ferociousBite and UD &lt;= 0) then
            call IssueImmediateOrder(u, &quot;stop&quot;)
            call SimError(GetOwningPlayer(u), &quot;You need at least one combo point!&quot;)
        endif
        set u = null
        return false
    endfunction

    private function init takes nothing returns nothing
        local trigger t = CreateTrigger()
        local integer index = 0
        
        loop    
            call TriggerRegisterPlayerUnitEvent(t, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
            set index = index + 1
            exitwhen index == bj_MAX_PLAYER_SLOTS
        endloop
        call TriggerAddCondition(t, Condition(function Conditions))
        set t = null
    endfunction

endscope
 

Ayanami

칼리
Public global's prefix is basically the library name. So, it should be "ComboPoints_Data".

JASS:
library Test
    globals
        public integer MyInt // you would need to refer this as Test_MyInt outside of the Test library
    endglobals
endlibrary

library Wow
    globals
        public integer MyInt // you would need to refer this as Wow_MyInt outside of the Wow library
    endglobals
endlibrary

library Combo
    globals
        public integer MyInt // you would need to refer this as Combo_MyInt outside of the Combo library
    endglobals
endlibrary
 

dudeim

New Member
Well if you remove the Public before it, it can be used anywhere so it's public right? I don't really get why you should even put public before a variable but whatever.
 

WolfieeifloW

WEHZ Helper
Public global's prefix is basically the library name. So, it should be "ComboPoints_Data".
Those three little examples were honestly a perfect explanation.

Thank you!
Although my ComboPoints library doesn't work, I"ll post in the JASS Help section, instead of spamming the AIDS thread with this.
Sorry J4L :p
 

Sgqvur

FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi
In the function OnUndefendTimer the line:

[ljass] if GetUnitUserData(IndexUnit[UndefendExpiringIndex[0]]) == 0 then[/ljass]

should be

[ljass] if GetUnitUserData(IndexUnit[UndefendExpiringIndex[0]]) != 0 then[/ljass]

otherwise the user's AIDS_onDestroy is never called.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Jesus4Lyf Jesus4Lyf:
    Hmm, how to summarize... Moved to the USA and got married. Became a professional software engineer and solution lead. Learning Godot for game dev. :)
  • jonas jonas:
    So you are pursuing game dev as a hobby? What industry is your dayjob in?
  • jonas jonas:
    FAANG?
  • Jesus4Lyf Jesus4Lyf:
    Not quite FAANG, less pay for a less hours/stress. Yeah, game dev as a hobby.
  • jonas jonas:
    makes sense. Do we have a hobby game dev subforum to showcase some work?
  • Blackveiled Blackveiled:
    Happy Thursday
    +1
  • The Helper The Helper:
    Happy Thursday!
  • The Helper The Helper:
    TGIF!
  • The Helper The Helper:
    hey tom_mai please do not archive anymore news
  • Ghan Ghan:
    AMD Ryzen 7000 next week :D
    +1
  • The Helper The Helper:
    noice!
  • tom_mai78101 tom_mai78101:
    "hey tom_mai please do not archive anymore news" ----> Got it. What should we do with the "News Archive" subforum?
  • The Helper The Helper:
    I think leave it for real old news that cannot be sorted the reason we had it in the first place was a server issue that we do not have anymore. I don't want to get rid of the archive just not put anything in it for now until we figure it out more
  • The Helper The Helper:
    The side chat has nothing on the discord. it is not possible but the biggest thing on my wish list right now is a sidechat channel on the disord that hooks up to this...
  • Ghan Ghan:
    I've been selected for the Diablo IV beta.
    +1
  • Ghan Ghan:
    Woo!
    +1
  • The Helper The Helper:
    that is so cool
  • V-SNES V-SNES:
    Eh just noticed the new discord section on the side. Looks great!
    +1
  • Blackveiled Blackveiled:
    :( feels bad I can't ever get selected for any beta I sign up for. It's annoying as heck.
    +1
  • The Helper The Helper:
    Hello mgarcia! Happy Monday everyone!

    The Helper Discord

    Staff online

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top