System Advanced Indexing & Data Storage

Sgqvur

FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi
Bribe:
1. No, because after the timer the unit's user data will already be 0.

1. Why should it? The unit is dead but it's user data is not zero.

Let me give you an example:

The example I am using is really simple, create 1 footman and 4 knights, for each I save their name and location and after the map loads
I order the knights to kill the footman. When he dies the AIDS_onDestroy method should be called but it is NOT.
But if the '==' is changed to '!=' for the above mentioned line it is called.
JASS:






library aidstest uses AIDS

    struct testaids extends array
        string name
        location l
    
        method AIDS_onCreate takes nothing returns nothing
            set name = GetUnitName(this.unit)
            set l    = GetUnitLoc(this.unit)
        endmethod
        
        method AIDS_onDestroy takes nothing returns nothing
            call RemoveLocation(l)
            call BJDebugMsg("AIDS_onDestroy called")
        endmethod
        
        static method AIDS_onInit takes nothing returns nothing
            call CreateUnit(Player(0), 'hfoo', 0, 0, 0)
            call CreateUnit(Player(0), 'hkni', 0, 0, 0)
            call CreateUnit(Player(0), 'hkni', 0, 0, 0)
            call CreateUnit(Player(0), 'hkni', 0, 0, 0)
            call CreateUnit(Player(0), 'hkni', 0, 0, 0)
        endmethod

        //! runtextmacro AIDS()
    endstruct
    
endlibrary
 

Bribe

vJass errors are legion
You don't get what this does at all.

AIDS_onDestroy is called when the unit has finished decaying, or is removed, not when the unit has simply "died".

If you have it the way it is now, if you order a footman to "undefend" it will also fire the AIDS_onDestroy method. Fail.
 

Sgqvur

FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi
Bribe:
1. You don't get what this does at all.

1. I get it now =).
 

Jesus4Lyf

Good Idea™
Just to clarify, AIDS structs are not destroyed on death, they are destroyed when the unit is removed from the game.
[LJASS]if GetUnitUserData(IndexUnit[UndefendExpiringIndex[0]]) == 0 then[/LJASS]
This line checks that the unit no longer exists. Nothing should have set it to 0, so it can only fire if the unit is gone. :)
 

Bribe

vJass errors are legion
Well Jesus, you could still do it without a timer and just check if the unit's ability level of the "Defend" ability is 0. Nestharus found out this trick.

That way AIDS_onDestroy will fire while the unit is still in scope, and you could always rework the locks to just recycle the index instead of waiting for all locks released to fire onDestroy.
 

Jesus4Lyf

Good Idea™
Well Jesus, you could still do it without a timer and just check if the unit's ability level of the "Defend" ability is 0. Nestharus found out this trick.
Correct, and always intended to implement this. Not that it matters, nor that I will, but y'know. Could happen, right?
That way AIDS_onDestroy will fire while the unit is still in scope, and you could always rework the locks to just recycle the index instead of waiting for all locks released to fire onDestroy.
I was about to say incorrect, but you are, in fact, totally correct.

I mean, these are changes which have trivial impact and require substantial time, thought and effort, which I'm currently dedicating to another project,a t the moment. Best I can do is assure you that said project is for this community. :)
 

Jesus4Lyf

Good Idea™
And you can ofc update the AIDS macro to be a module using static ifs
I'm not so sure that this is possible with full backwards compatibility. See, unfortunately, the init orders in JassHelper were all stuffed around while this was being made, and the result is not that the init order will not be the same if I was to do that. I tried making it a module and it actually broke some of my maps, so I gave up on the silliness at the time, and just let it be.
 

GFreak45

I didnt slap you, i high 5'd your face.
now im getting a syntax error whenever I use AIDS, getting this:AIDS error.png

am i doing something wrong? should i be using vjass?
 

Dirac

22710180
Looks like you don't have the latest version of the JassHelper, check the sticky in the WEHZ page for more info on the JassNewGenPack 1.5.
static if are an special tool for programming that check for constant booleans and decides whether or not the code below should be compiled. Example
JASS:
static if LIBRARY_AIDS then
    globals
        integer Index = 0
    endglobals
endif
In that case if the user doesn't have AIDS in his map the global won't exist.
 

Bribe

vJass errors are legion
Well bad example because vJass bugs with globals in static if's, it creates it anyway because it parses globals before static if's.
 

Dirac

22710180
Rofl correct, forgot about that bug.

On a side-note, i've found this bug that both UnitIndexer and AIDS have when it comes to event-firing of preplaced units, the thing is, it doesn't happen.
Yes, preplaced units gain their custom value once the map is initialized, but the events are added to functions on unit indexation AFTER the indexation per se happens.
Any ideas on how to solve this?
 

Bribe

vJass errors are legion
It works fine with UnitIndexer if you use the current version. It was updated a few months ago to support that.
 

Jesus4Lyf

Good Idea™
There's an even better bug Azlier once pointed out about units with auto-cast activated abilities being issued orders before the enters region boolexpr fires. Get with the times, people! :p

I think this applies to most indexing systems, and is easy to solve. Can't remember if I ever did address that one.

Not saying I can't/won't address these things, I just have slightly more pressing things atm.
 

JJooKKoo

New Member
I have a question how can i take the struct that i assign to unit.I use these two bot non of them works
Code:
local MyUnitStruct uData = GetUnitId(GetTriggerUnit())
 
local MyUnitStruct uData = GetUnitIndex(GetTriggerUnit())
i made the struct AIDS struct with //! runtextmacro AIDS()

edit:
I found what is wrong now i use this
Code:
local MyUnitStruct uData = MyUnitStruct[GetTriggerUnit()]
but when i initialize the struct members in method AIDS_onCreate and use to say set this.i = 100
and when i take the value from struct is is 0 .So please smoebody help me

EDIT2:
It initialize the members of the struct for dynamic added units but not for units plased in editor.So why this hapen
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.
  • The Helper The Helper:
    We need to do something about the Headline News forum now that Ghan got the News script to work on the forums. We need an Other category really now more than we need a headline news forum full of redirects
  • The Helper The Helper:
    wow i just noticed there are no redirects left in Headline news lol!
  • The Helper The Helper:
    so much for the redirects I think they are useless anyway because posts urls are set and the redirects were just extra if something is indexed by the search engine it still will be without the redirect since the original url does not change
  • tom_mai78101 tom_mai78101:
    I was wondering if it'd be best to consolidate all of the Headline News threads into 1 place, and then let the users click on navigation links that would show/hide threads based on their thread flairs? Splitting the Headline News up like this would mean the only way to see all of the news is to go to the Home page and check there.
  • jonas jonas:
    I usually just browse the homepage for news
  • tom_mai78101 tom_mai78101:
    Good to know.

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top