System Advanced Unit Transfer System

NoobImbaPro

You can change this now in User CP.
thanks, I thought I can use now with the newest jasshelper update the functions without logic order without cons...
Ability "I know vJass" got +1 level :D
 

Sgqvur

FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi
I think you should change the:

[ljass]call SetUnitFlyHeight(.moving, .z, 0)[/ljass]

to

[ljass]call MoveLocation(some_global_loc, x, y)[/ljass]
[ljass]call SetUnitFlyHeight(.moving, .z - GetLocationZ(some_global_loc), 0)[/ljass]

The reason is that ithe SetUnitFlyHeight internally adds to the height parameter += GetLocationZ(Location(GetUnitX(u), GetUnitY(u)), so that's why we subtract (.z - GetLocationZ(some_global_loc)) to end up with "absolute" z position.

If you are not convinced then make a unit jump over an raised terrain and see what happens =).
 

NoobImbaPro

You can change this now in User CP.
I actually saw that, and tried to fix it but it didn't came into solution so I left it behind.
Because with that I will have problems when I cast a jump style ability from one level higher terrain...
I think I must save the very first position height and then check what comes next.

It must be something like this:
JASS:
call MoveLocation(some_global_loc, x, y)
call SetUnitFlyHeight(.moving, .z + first_location_height - GetLocationZ(some_global_loc), 0)

EDIT2:
But now I will have problem when i come from higher height to lower. It's so complex....but I will find a way.

EDIT:
@tooltiperror
if you see this post, I figured out how to move things up, just setting distance to 1, not stacking 2 movements with opposite directions.
 

Bribe

vJass errors are legion
"interface AUMS_Interface"

This pretty much executes any hopes of this being "better". Interfaces are the worst garbage in all of JassHelper. Because doing a system like this is pretty tough without interfaces, a lot of people end up just inlining a knockback into their resource, for better or for worse.
 

NoobImbaPro

You can change this now in User CP.
Well, I don't recommend it too for simple knockbacks, like the ones for movement only.

But what??? What do interfaces have that makes them garbage???
 

luorax

Invasion in Duskwood
A bunch of extra trash (mostly duplicated functions) generated because of their nature.

But you can check it for yourself; create a new map, delete the generated triggers and create a new custom script. Then create an interface with a few methods and extend it with a struct. The exteding struct should have those methods as well, with a couple of function calls, just to make things more clear. Then save the map twice (because it's a new map - JNGP bug) and check the generated "war3map.j" file.
 

Sgqvur

FullOfUltimateTruthsAndEt ernalPrinciples, i.e shi
A bunch of extra trash (mostly duplicated functions) generated because of their nature.

But you can check it for yourself; create a new map, delete the generated triggers and create a new custom script. Then create an interface with a few methods and extend it with a struct. The exteding struct should have those methods as well, with a couple of function calls, just to make things more clear. Then save the map twice (because it's a new map - JNGP bug) and check the generated "war3map.j" file.
Or... just use jasshelper.exe or clijasshelper.exe from the command line, examples:

jasshelper --scriponly commonj.j Blizzard.j in.j out.j; // asuming that the command is run from the jasshelper directory and all the files (common.j Blizzard.j in.j and out.j) exist there.

wine clijasshelper.exe --scriptonly common.j Blizzard.j a.in a.out; // asumes the same things as the first command but should run under gnu/linux, it is not required to be clijasshelper.exe, jasshelper.exe (gui) works just as fine.

And of course reading the manual won't hurt.


Edit: What is the big deal with the "code duplication"???? Nada! Who cares if a function is trigger evaluated/executed and not runned directly? I sure don't. Because trigger evaluations are only about ~15% slower than a function that take arguments (say 2 to 4).

>My god, what a crappy lang....
What is that supposed to mean?
 

NoobImbaPro

You can change this now in User CP.
That supposes to mean its not c++/java like lang. Where jass2 needs to call functions from the upper code, else they are evaluated.
I just made a system that makes your life a lot easier when it comes to moving. And they are complaining about my coding, got bored of this.
Haters gonna hate...




Now system needs to be updated about 2 times. One for checking collision in Z axis and one for covering all the types of movement.
 

luorax

Invasion in Duskwood
Edit: What is the big deal with the "code duplication"???? Nada! Who cares if a function is trigger evaluated/executed and not runned directly? I sure don't. Because trigger evaluations are only about ~15% slower than a function that take arguments (say 2 to 4).
It's bad if it can be avoided; the extra size (especially for long functions) does matter, if your map script is 3,2MBytes already. By coding properly you won't be duplicating functions and you'll even gain speed; so it actually does matter.
 

Dirac

22710180
Who cares if a function is trigger evaluated/executed and not runned directly? I sure don't.
So says the guy who is extremely opposed to do function calls and reduce code because they are slow?
Implying that trigger evaluations aren't at least 100 times worse.
If anything calling functions to reduce code size is the smartest thing to do, it also allows you to easily change the actions performed just by changing the contents of the function.
Yes the speed might come in handy when dealing with systems that require lots of speed, but you have textmacros for that.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    They aren't cutting my responsibilities or interjecting in my management abilities or anything, it's just stupid shit that comes up. And they don't exactly have people lining up for my job, there's not that many people applying for the positions I hire
  • Varine Varine:
    Eh, whatever. Thanks for listening guys
  • jonas jonas:
    Sure :) Let us know how it ends
  • Varine Varine:
    All of these things will end happily, they're just stressful. And I still lack many good friends that I can go to, and the ones I can are preoccupied with similar things. Thus general chit chat, cuz for some reason TH and Ghan and Tom all actively keep it up.
  • Varine Varine:
    Just gotta keep Miss Mazie up through the week until her shock wears off and she realizes that she still has family all around her, and bossman will do whatever he's going to do and I'll respond appropriately when it happens. Thank you all for the support, I do very much appreciate everyone being here for me through the years
    +3
  • vypur85 vypur85:
    Best of luck Varine!
  • vypur85 vypur85:
    I just gotten myself an offer to work in China. The pay quadruples my current one. Damn.... Not really ready to start a new life there in China.
  • The Helper The Helper:
    I have heard that they pay pretty good to English teachers in China - you would be an expat
  • jonas jonas:
    Cool, what kind of job?
  • Accname Accname:
    I would be careful with jobs in China. They can be hit and miss depending on where in China you go. Places like hong kong / Shengzen / Beijing can be neat. Other places not so much.
  • Accname Accname:
    I would recommend searching for some first person experiences for the city you got the offer in. Especially now when the political situation in China is deteriorating.
  • jonas jonas:
    Accname, long time no see
  • jonas jonas:
    What have you been up to
  • tom_mai78101 tom_mai78101:
    Hey Accname, welcome back.
  • Accname Accname:
    Not much. Working in the Renewable Energy Sector as an IT Consultant. Its okay, but I think I preferred working at the university. It was more relaxed and you met all kinds of crazy people there.
  • vypur85 vypur85:
    I gotten a teaching position for Biology in a college in Wuhan (yes, there)... I suppose it should be fine there (I hope). Many of my ex colleagues are teaching in China as well currently (none in Wuhan though)
  • vypur85 vypur85:
    And I signed the contract already. I guess there's no turning back....
  • jonas jonas:
    @Accname how many hours do you work? I heard in some sectors IT consultants rack up insane hours
  • jonas jonas:
    @vypur85 sounds nice, have fun : )
  • Accname Accname:
    I am supposed to work 40 hrs a week, but I can work more if I like and I will be paid for those hours (as long as I don't go too far, there are laws and company policies, etc)
  • Accname Accname:
    In practice its basically work as much as you like, as long as the job gets done in time.
  • jonas jonas:
    Haha, my job is like that as well... that usually means I have a few 70-80 hours weeks a year, and lots of 20 hours weeks...
  • jonas jonas:
    a few weeks ago, one of my friends basically said "jonas, I received an invitation to submit something to conference X but I'm too lazy to do it and also the conference isn't advanced enough for my high level of research*, why don't you write something? Oh by the way, the deadline is in two weeks. Enjoy!" so I got two 80 hour weeks out of that kind offer. (*of course he didn't say those parts, but it's a better story this way)
  • jonas jonas:
    now I'll have next week off to make up for overtime :p and I'll play some good old gothic 2
  • The Helper The Helper:
    Hope you are enjoying that gothic 2~

    Staff online

    Members online

    Affiliates

    Hive Workshop NUON Dome
    Top