Angle problems

[Wratox1]

okay, so i have this trigger:

• push box
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
    • shield_active Equal to True
  • Actions
    • Set pushing_unit = u
    • Set pushing_unit_loc = (Position of pushing_unit)
    • Set pushing_angle = (Facing of pushing_unit)
    • Game - Display to (All players) the text: (String(pushing_angle))
    • Unit Group - Pick every unit in (Units within 64.00 of pushing_unit_loc matching ((Unit-type of (Matching unit)) Equal to Box)) and do (Actions)
      • Loop - Actions
        • Set pushed_unit = (Picked unit)
        • Set pushed_unit_loc = (Position of pushed_unit)
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Angle from pushing_unit_loc to pushed_unit_loc) Greater than 315.00
            • (Angle from pushing_unit_loc to pushed_unit_loc) Less than 45.00
          • Then - Actions
            • Set pushed_angle = 0.00
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Angle from pushing_unit_loc to pushed_unit_loc) Greater than 45.00
                • (Angle from pushing_unit_loc to pushed_unit_loc) Less than 135.00
              • Then - Actions
                • Set pushed_angle = 90.00
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Angle from pushing_unit_loc to pushed_unit_loc) Greater than 135.00
                    • (Angle from pushing_unit_loc to pushed_unit_loc) Less than 225.00
                  • Then - Actions
                    • Set pushed_angle = 180.00
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Angle from pushing_unit_loc to pushed_unit_loc) Greater than 225.00
                        • (Angle from pushing_unit_loc to pushed_unit_loc) Less than 315.00
                      • Then - Actions
                        • Set pushed_angle = 270.00
                      • Else - Actions
        • Set pushed_unit_new_loc = (pushed_unit_loc offset by 2.00 towards pushed_angle degrees)
        • Unit - Move pushed_unit instantly to pushed_unit_new_loc
    • Custom script: call RemoveLocation(udg_pushing_unit_loc)
    • Custom script: call RemoveLocation(udg_pushed_unit_loc)
    • Custom script: call RemoveLocation(udg_pushed_unit_new_loc)

what it's supposed to do is making me able to push a box, but only north, south, east and west.

but when i test it, i am only able to push the box north and east. And sometimes, if i sort of glitch it, west.

Could someone tell me what is wrong with the trigger? Or maybe help me make a new system that works..

thanks

 

[Solu9]

At first glance. Have you tried 360 degrees instead?

Unit Group - Pick every unit in (Units within 64.00 of pushing_unit_loc matching ((Unit-type of (Matching unit)) Equal to Box)) and do (Actions)

• Loop - Actions
  • Set pushed_unit = (Picked unit)
  • Set pushed_unit_loc = (Position of pushed_unit)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Angle from pushing_unit_loc to pushed_unit_loc) Greater than 315.00
      • (Angle from pushing_unit_loc to pushed_unit_loc) Less than 45.00
    • Then - Actions
      • Set pushed_angle = 360

Edit:
By the way. You probably want the detected angles set to this instead:

East: Angle = equal to or greater than 360 OR equal to or less than 44
North: Angle = equal to or greater than 45 OR equal to or less than 134
West: Angle = equal to or greater than 135 OR equal to or less than 224
South: Angle = equal to or greater than 225 OR equal to or less than 359

 

[Wratox1]

@solu9 well first off, the east angle isn't the problem, so zero works.

why should i use the "or"? when the facing angle of my unit is greater than 315 for example and it is less than 45, then i want the pushed angle to be zero.

Also, "East: Angle = equal to or greater than 360 OR equal to or less than 44" the angle will never become greater than 360 so that doesn't make sense..

 

[Solu9]

why should i use the "or"? when the facing angle of my unit is greater than 315 for example and it is less than 45, then i want the pushed angle to be zero.

Because if your unit is EXACTLY at angle 315 you want it to count that angle as well. And the reason for North max angle = 134 instead of 135 is you don't want to count it in both the north and the west angle.
You already have the OR like you already stated yourself. I just wrote it differently than in your trigger. The OR is supposed to be an AND anyway

Also, "East: Angle = equal to or greater than 360 OR equal to or less than 44" the angle will never become greater than 360 so that doesn't make sense..

Obviously a typo:

East (right): Angle = equal to or greater than 315 OR (this need to be an OR Im pretty sure) equal to or less than 44​

North (up): Angle = equal to or greater than 45 and equal to or less than 134​

West (left): Angle = equal to or greater than 135 and equal to or less than 224​

South (down): Angle = equal to or greater than 225 and equal to or less than 314​

​

Edit:
"Unit Group - Pick every unit in (Units within 64.00 of pushing_unit_loc matching ((Unit-type of (Matching unit)) Equal to Box)) and do (Actions)"

Have you kept in mind if more than one box is within the perimeter of the pushing unit?
This unit group leaks by the way.

Edit 2:

Have you tried, instead of a 0.01 periodic timer, to run this trigger when an ability is casted?
And what the hell, every 0.01 secs of game time!? At max set it to 0.10 secs.

 

[vypur85]

'Facing angle' and 'Angle between points' cannot be compared to directly.

Facing angle measures angle ranging from 0 to 360 degrees.
Angle between points measures angle ranging from -180 to 180.

You can easily test this using debug message for Angle between points.

To fix this, convert Angle between points so that it measures 0-360, and then, make your comparison. This is how you convert:

Loop - Actions

• Set pushed_unit = (Picked unit)
• Set pushed_unit_loc = (Position of pushed_unit)
• Set AngleBetweenPoints = Angle from pushing_unit_loc to pushed_unit_loc
• Condition: If AngleBetweenPoints is less than 0.00 then:
  • Set AngleBetweenPoints = AngleBetweenPoints + 360.00
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • AngleBetweenPoints Greater than 225.00
    • AngleBetweenPoints Less than 315.00
  • Then - Actions
    • Bla bla bla...

 

[Wratox1]

@vypur85 i changed my trigger according to your post and it worked, thanks!

However, after some time of pushing on my box, the trigger went a little buggy, the box was mostly being pushed south, even if i push it from the left or whatever..