Apply timed life not working and memory leaks

superkar

New Member
Well! I've made this ability called Absorb. It deals damage to enemies in 400 range and gives back 20% of that damage to the caster. I had to make 2 dummy abilities ( ON and OFF) to make it work properly, here is the code!
AbsorbON triggers:

Code:
function Trig_Absorb_Effect_Conditions takes nothing returns boolean
    if  ( GetSpellAbilityId() == udg_AbsorbON ) then
        return true
    endif
    return false
endfunction
 
function Absorb_Effect_Pick_Condition takes nothing returns boolean
    if ( IsUnitAlly(GetFilterUnit(), Player(0)) == true ) or (IsUnitDeadBJ(GetFilterUnit()) == true) or (IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == true) or (IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == true) then
        return false
    endif
    return true
endfunction
 
function Absorb_Effect_Picked_Effect takes nothing returns nothing   
    local unit targ = GetEnumUnit()
    local unit cast = GetTriggerUnit()
    local real dmg = GetWidgetLife(targ)
    set udg_loc = GetUnitLoc(targ)
    call UnitDamageTarget(cast, targ, 10, false, false, ATTACK_TYPE_MAGIC, DAMAGE_TYPE_FIRE, null)
    set dmg = dmg - GetWidgetLife(targ)
    call SetUnitLifeBJ( cast, ( GetUnitStateSwap(UNIT_STATE_LIFE, cast) + dmg/5 ) )
    call DisplayTextToForce(GetPlayersAll(), R2S(dmg))
    call CreateNUnitsAtLoc( 1, 'h001', Player(PLAYER_NEUTRAL_PASSIVE), udg_loc, 0 )
    call RemoveLocation (udg_loc)
    call UnitApplyTimedLifeBJ( 0.99, 'BTLF', GetLastCreatedUnit() )
endfunction
 
function Trig_Absorb_Effect_Actions takes nothing returns nothing
    call AddSpecialEffectTargetUnitBJ( "chest", GetTriggerUnit(), "Objects\\Spawnmodels\\Undead\\UDeathMedium\\UDeath.mdl" )
    call DestroyEffectBJ( GetLastCreatedEffectBJ() )
    call UnitRemoveAbilityBJ( udg_AbsorbON, GetTriggerUnit() )
    call UnitAddAbilityBJ( udg_AbsorbOFF, GetTriggerUnit() )
    call CreateNUnitsAtLoc( 1, 'h000', Player(PLAYER_NEUTRAL_PASSIVE), GetUnitLoc(GetTriggerUnit()), 0 )
    set udg_AbsorbDummyUnitEffect = GetLastCreatedUnit()
    loop
        exitwhen (GetUnitAbilityLevel(GetTriggerUnit(), 'A003') == 0)
        set udg_loc = GetUnitLoc(GetTriggerUnit())
        set udg_group = GetUnitsInRangeOfLocMatching(400.00, udg_loc, Condition(function Absorb_Effect_Pick_Condition))
        call RemoveLocation (udg_loc)
        call ForGroupBJ( udg_group, function Absorb_Effect_Picked_Effect )
        call DestroyGroup (udg_group)
        call TriggerSleepAction( 1 )
    endloop
   
endfunction
 
//===========================================================================
function InitTrig_Absorb_Effect takes nothing returns nothing
    set gg_trg_Absorb_Effect = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Absorb_Effect, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Absorb_Effect, Condition( function Trig_Absorb_Effect_Conditions ) )
    call TriggerAddAction( gg_trg_Absorb_Effect, function Trig_Absorb_Effect_Actions )
endfunction
And AbsorbOFF triggers:

Code:
function Trig_Absorb_OFF_Conditions takes nothing returns boolean
    if ( not ( GetSpellAbilityId() == udg_AbsorbOFF ) ) then
        return false
    endif
    return true
endfunction
 
function Trig_Absorb_OFF_Actions takes nothing returns nothing
    call RemoveUnit( udg_AbsorbDummyUnitEffect )
    call UnitRemoveAbilityBJ( udg_AbsorbOFF, GetTriggerUnit() )
    call UnitAddAbilityBJ( 'A004', GetTriggerUnit() )
    call IssueImmediateOrderBJ( GetTriggerUnit(), "howlofterror" )
    call TriggerSleepAction( 3.00 )
    call UnitRemoveAbilityBJ( 'A004', GetTriggerUnit() )
    call UnitAddAbilityBJ( udg_AbsorbON, GetTriggerUnit() )
endfunction
 
//===========================================================================
function InitTrig_Absorb_OFF takes nothing returns nothing
    set gg_trg_Absorb_OFF = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Absorb_OFF, EVENT_PLAYER_UNIT_SPELL_CHANNEL )
    call TriggerAddCondition( gg_trg_Absorb_OFF, Condition( function Trig_Absorb_OFF_Conditions ) )
    call TriggerAddAction( gg_trg_Absorb_OFF, function Trig_Absorb_OFF_Actions )
endfunction
Some explanation! When AbsorbOn is cast, this ability is removed and a loop that requires the caster to have AbsorbOFF starts: every 1 second, every unit in 400 range of the caster is picked, damage is dealt to them, a special effect is created in their position using a dummy unit, these dummies are set to die .99 seconds after and some life is given to the caster (20% of the dmg). If the player uses AbsorbOFF, this ability is taken away, so the loop stops. Another dummy ability is given and used to put a cooldown (couldn't think of anything better as there is no "put ability on cooldown" action), after this cooldown the dummy is removed and AbsorbON is given back. Following some guides, I've tried to solve leak problems, correct me if I am wrong, but the ability kept on lagging (up to making the game unplayable). I created a trigger to count units on the map and it says that the unit count keeps on getting higher and higher while the ability is ON. So I guess the dummy units for the special effect on targets are not dying. I tried to not create the dummies but the lag is the same.

SO! I can see I have 2 problems, one is the fact that dummies are not dying, the other is that there is some leaking, not depending on the dummies not dying. What am I doing wrong?? Help please!!
 

dracolich

TH.net Regular
why do you use another units to provide visual? enormous summon of units cause lags itself, regardless anything.
 

superkar

New Member
The lag doesn't depend on the dummy units being created, it actually appears mostly when AbsorbOFF is used! Anyway, if I used a special effect, I wouldn't be able to destroy it after 1 second as the commands are inside a "pick" loop
 

dracolich

TH.net Regular
of course u can. just save them in hashtable?
u use
local unit targ = GetEnumUnit()
local unit cast = GetTriggerUnit()

but dont null them.
if you wonder about timelife then change dummy's model to selectable one (remove locust ability too) and change PLAYER_PASSIVE to trigger player. Then select it and check for timeline.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top