Snippet AutoFly

[Azlier]

Indeed. Especially because it's 11:20 am here.

 

[Dest]

Just one question, does this snippet works very well with spells, like, ie the hero casts a spell that makes the unit to fly back and then hits onto the ground.

Not requesting a spell, just being curious

 

[Azlier]

It's meant for spells. It's better than adding and removing Crow Form every time a spell is cast.

 

[Jesus4Lyf]

How lame can I be...
Hm.

        local integer i = 16
        call RegionAddRect(r, re)
        call TriggerRegisterEnterRegion(CreateTrigger(), r, Filter(function Actions))
        call RemoveRect(re)
        set re = null
        
        loop
            exitwhen i == 0
            set i = i - 1
            call GroupEnumUnitsOfPlayer(g, Player(i), Filter(function Actions))
        endloop

-->

        local integer i = 15
        call RegionAddRect(r, re)
        call TriggerRegisterEnterRegion(CreateTrigger(), r, Filter(function Actions))
        call RemoveRect(re)
        set re = null
        
        loop
            call GroupEnumUnitsOfPlayer(g, Player(i), Filter(function Actions))
            exitwhen i == 0
            set i = i - 1
        endloop

That exitwhen comparison and subtract 1 should cut thy load time by 4.2 minutes.

To be honest, I'd use yours and switch [LJASS]local integer i=16[/LJASS] with [LJASS]local integer i=bj_MAX_PLAYERS[/LJASS].
It's just kind of nicer not to have magic numbers.

PS. Err, very nicely done. Good script.
PPS. You could use a static if to look for boolexpr utils for using the enum group.
Edit: This? Lol.

 

[Azlier]

Like this? Insanity.

// Autofly - by Azlier
//  Requires a vJass preprocessor

// How to import:
//  1. Create a new trigger called AutoFly.
//  2. Convert the trigger to custom script, and replace all the code inside with this.

library AutoFly requires optional GroupUtils, optional GlobalGroup

private function Actions takes nothing returns boolean
    if UnitAddAbility(GetFilterUnit(), 'Amrf') then
        call UnitRemoveAbility(GetFilterUnit(), 'Amrf')
    endif
    return false
endfunction

private struct Hack extends array

    static method onInit takes nothing returns nothing
        local region r = CreateRegion()
        local rect re = GetWorldBounds()
        local group g
        local integer i = 15
        call RegionAddRect(r, re)
        call TriggerRegisterEnterRegion(CreateTrigger(), r, Filter(function Actions))
        call RemoveRect(re)
        set re = null
        
        static if LIBRARY_GroupUtils then
             set g = ENUM_GROUP
        elseif LIBRARY_GlobalGroup then
             set g = GROUP
        else
             set g = CreateGroup()
        endif
        loop
            call GroupEnumUnitsOfPlayer(g, Player(i), Filter(function Actions))
            exitwhen i == 0
            set i = i - 1
        endloop
        static not (if LIBRARY_GroupUtils or LIBRARY_GlobalGroup) then
             call DestroyGroup(g)
        endif
        set g = null

endmethod

endstruct

endlibrary

 

[Jesus4Lyf]

That code is not spaghetti enough.
You can optimise it more:
[LJASS]local group g[/LJASS] shouldn't be declared if either of those libs exist!

Edit: We need to implement an I2C goto.

 

[Azlier]

I hate you.

 

[Romek]

> [ljass]static not (if LIBRARY_GroupUtils or LIBRARY_GlobalGroup) then[/ljass]
I'm sure that doesn't compile...

 

[Azlier]

Well, duh. It doesn't make any sense. Did you know that [lJASS]then[/lJASS] can be omitted with static ifs? Unless Vex fixed that.

 

[Jesus4Lyf]

>endmethod
Indent plz.

Also, you could optionally require grouputils and recycle and use a group from those respectively.

In reality, no one cares. Nice work.

 

[Azlier]

I made it use library_once. Not that it matters much, but you can copy and paste it onto every spell or something without negative effects. Yes, I know that's evil.

 

[Narks]

Major bug: this breaks that Medivh guy unit thing

 

[Jesus4Lyf]

Oh noez! It are teh end of the world, Medivh!

 

[Azlier]

You tested that, Narks?

If it really does break Medivh, it's Romek's fault because I had it set up in a way that wouldn't break Medivh originally.

 

[Narks]

oh, wait, my mistake

damn you azlier, you have all your bases covered

 

[Romek]

> If it really does break Medivh, it's Romek's fault because I had it set up in a way that wouldn't break Medivh originally.
You're welcome.

 

[Troll-Brain]

I don't see how it could break the 'Amrf' ability since the ability is added/removed only when the unit enter the map and doesn't already have this ability.

 

[Kenny]

Can I ask why this doesn't use AIDS? Is there a specific reason or something? Otherwise, this could be done in like 10 lines.

Edit:

Something like this:

library AutoFly
    private struct AutoFly extends array
        //! runtextmacro AIDS()
        private method AIDS_onCreate takes nothing returns nothing
            if UnitAddAbility(this.unit,'Amrf') then
                call UnitRemoveAbility(this.unit,'Amrf')
            endif
        endmethod
    endstruct
endlibrary

 

[Jesus4Lyf]

It doesn't need indexing. Doesn't make a diff, really.. that AIDS version is nice cos if you require it from a library, then AIDS structs in that lib should guarantee the unit has been auto-flown. *Shrugs*

 

[Kenny]

Yeah fair enough. I just love how simple AIDS makes things, I've become use to using it all the time.

Off topic: Is there an ETA on an update for AIDS?