Spell Black Arrow

[Cohadar]

LoL I accidentally saw it.

It will not disturb anything, besides I am using this spell in Pyramidal remember?
I simply recoded it to use PUI as I explained to you.

 

[cr4xzZz]

Well, cohadar, your PUI GUI SHMUI WUI isn't MUI at all. I tested it but when I cast it 2+ times all arrows move to the direction where the last arrow was casted and none of them gets removed.

 

[Cohadar]

Of course it is (try the arrow in pyramidal)

It is not my fault that you made error in your coding....

 

[cr4xzZz]

> It is not my fault that you made error in your coding....
Never used it in my map. It's not MUI in the map few posts above. :\

 

[Cohadar]

Oh I see, well I just hacked that in few minutes,
it does not matter really, it is GUI anyways and I don't want to bother with that, waste of time...

Try jassing...

 

[cr4xzZz]

> Try jassing...

Duuuh... I know, GUI sux. I just wanted to report that.

 

[Flare]

Super Mega Awesome Update!

This post doesn't matter anymore. All info that was in this post is now on the first post.l

 

[PurgeandFire]

private function GroupActions takes nothing returns nothing
    local unit u = GetEnumUnit ()
    if IsUnitAlly (u, GetOwningPlayer (caster)) == true then
        call SetUnitState (u, UNIT_STATE_LIFE, (GetUnitState (u, UNIT_STATE_LIFE)) + heal)
    else
        call UnitDamageTarget (caster, u, damage, true, true, ATTACK_TYPE_HERO, DAMAGE_TYPE_NORMAL, WEAPON_TYPE_WHOKNOWS)
    endif
endfunction

No null? Else, good job. I'll look at the rest latar.

 

[Flare]

Ah, I guess I overlooked that. Still trying to figure out how to get around the error in my VARIABLEDAMAGE and VARIABLEHEAL constant functions (it says 'Expected a name'). It's not an absolute requirement, but it makes the spell more customizable

EDIT: Just noticed that I didn't null the timer t in BArrowActions. Do I need to null it, or would that cause problems with the timer?

 

[GoGo-Boy]

Sooo okay tested it!
I really love this spell. It looks so nice when the effects appear on all units into a line. Doesn't lag and you made the code configuration very newbfriendly (using degrees, colors in %). +Rep because it's great.

I got one little "but" though^^
Could you please make it that way, that it doesn't go further the targeted spellpoint? It is quite easy to do that. Just use an struct integer which, e.g., you call ticks. Then when the spell is fired you do s.th. like this.

local location l = GetSpellTargetLoc()
local real lx = GetLocationX(l)
local real ly = GetLocationY(l)
local real x = lx - GetUnitX(a.caster)
local real y = ly - GetUnitY(a.caster)
set a.ticks = R2S(SquareRoot( x * x + y * y) / MOVEDIST) // distance between caster and target location / the distance that is traveled every period
    call RemoveLocation(l)
set l = null

In your callback function you always set a.ticks = a.ticks - 1 and you always check whether a.ticks >= 1... if true then you do all your movement thing etc. if not you do the explode-stuff.

Edit: Null the timer, won't cause any problems... and you should also null the timer in the callback function.

Edit2: Ahh and for physicals sake give the arrow a fly height... normally arrows do NOT move ON the ground^^. Will also look much better.

 

[Flare]

set a.ticks = R2S(SquareRoot( x * x + y * y) / MOVEDIST)

Your setting ticks as a string? R2S is Real 2 String, right? ^^

And sure, I can add that.

Actually, I shouldn't use the distance function xD I'll just take the long way (to save on importing stuff)

Thanks for the comments though

 

[GoGo-Boy]

set a.ticks = R2S(SquareRoot( x * x + y * y) / MOVEDIST)

Your setting ticks as a string? R2S is Real 2 String, right? ^^

And sure, I can add that.

Ups... I mean R2I ^^

 

[Flare]

Done, ask you requested. Map is on the first post. It's much more fun to cast now (because the hero's animation is played so it doesn't look like a projectile appears from nowhere)

 

[BRUTAL]

when i open the updated map in WE then click test map
it brings me to the Warcraft 3 menu screen

 

[Flare]

Oh ye, I forgot to mention that NewGen is required. If you just want to test, put the map into your Maps folder and play in Single Player

Added a note about NewGen requirement to post 27

 

[Flare]

Doesn't lag and you made the code configuration very newbfriendly (using degrees, colors in %)

That's pretty much what I was aiming for. Being a JASS newb myself, it's nice to be able to easily configure a spell without diving right in and looking for everything and not understanding it. And, pretty much every other JASS spell I've seen has a configuration block, so why shouldn't I do it ^^

I guess that was one of the disadvantages of spending so long using GUI (the newb-unfriendly-ness)


EDIT AGAIN
I have a quick question:
For my first decent attempt at a JASS spell, would this be good/bad/average? End result-wise and complexity of code-wise (would you say it's a fairly simple thing to do for a beginner?)

 

[GoGo-Boy]

Hmm I'll try to give a pros / cons feedback

+ Spell is in vJASS
+ You use unit sliding
+ You use coordinates
+ You successfully use ABC
+ MUI / MPI
+ Result is pretty nice^^
+ Awesome config, very newbfriendly
+ method use
+ quite efficient coding ( probably more then trice as good as your GUI version [though I never threw a look at it])

------------
- code could be neater at some points (not at config )


-->
Conclusion:
In my opinion a very nice remake of one of your own GUI spells. You learned a lot in the past days I guess... and we can see that . Great result for a first JASS spell.
And... I'm happy to see someone GUIing for so long to finally took over JASS ;s

 

[Flare]

+ Spell is in vJASS
+ You use unit sliding
+ You use coordinates
+ You successfully use ABC
+ MUI / PUI
+ Result is pretty nice^^
+ Awesome config, very newbfriendly
+ method use
+ quite efficient coding ( probably more then trice as good as your GUI version [though I never threw a look at it])

------------
- code could be neater at some points (not at config )

1) -
2) I was able to do that before with Key Timers (but it used PolarProjectionBJ)
3) Coordinate geometry would be one of my stronger points when it comes to maths ^^
4) Woot!
5) Ahm... PUI? If you are talking about Perfect Unit Indexing, no comment :nuts:
6) Thanks
7) That was the plan when I thought out the configuration
8) Copied it from cr4xzzz's JASS version of Frozen Orb (I still don't understand what methods do, but I know how to use that one ^^)
9) Thanks

-----------------------------------------------------------

1) Any suggestions on making it neater (should I space out the functions more? better indentation?)

 

[GoGo-Boy]

Mean MPI...
Don't say woot to ABC usage... many beginners don't get it work :S.
And at least you used methods... which is good. Though you might not directly understand how they work yet, which is to be honest no shame. It took me ages to understand em^^

 

[Flare]

Don't say woot to ABC usage... many beginners don't get it work :S.

I'm saying woot because the last few times I tried to use ABC, it was a pretty epic failure (I got loads of ingame errors, lag and crashes) so I'm just happy that I got it to work successfully

EDIT: Updated the first post with a little more information on the GUI/JASS versions and the technical details.

EDIT 2: Updated the first post again, cleaned up some stuff and added the JASS code, JASS implementation instructions and credits to the first post.