Spell Blink Back

WolfieeifloW

WEHZ Helper
Reaction score
372
Could a moderator review this.
Sim said I'd just need to fix the TimerUtils, which has been done (And more :p ).

Or, any comments on the code/spell itself?
 

BlackRose

Forum User
Reaction score
239
[LJASS]call TimerStart(d.t, 1.233, false, function SFXDestroy)[/LJASS], effect duration should be configurable.

You also don't null "u" in BBConditions. I also don't think the BB prefix is necessary, since you already use scope and private.
 

WolfieeifloW

WEHZ Helper
Reaction score
372
I was only supposed to update TimerUtils for this to most likely get re-approved;
Could a moderator, please and thank you, look at this :p
 

BlackRose

Forum User
Reaction score
239
Functions listed under the below header should be constant so it is inlineable.
JASS:
//=========================================================================
//====================     Functions Configuration     ====================
//=========================================================================

I see nothing else wrong other than the unconstant functions. The only other thing I would make note of is the code structure. I'd make any functions related with the spell only as methods to the struct, but it's not too big of a deal in this case.
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top