Can custom function take boolean or code?

afisakov

afisakov

You can change this now in User CP.
Reaction score
37
I have a trigger that is getting very repetitive in its steps, trying to make custom function to encompass most of these, to save space and make it easier to tweak. But game does not want to accept way I tried to trigger it.

Original trigger
Code: 
function gen_enemy takes nothing returns boolean
   return GetUnitState(GetFilterUnit(),UNIT_STATE_LIFE)>0.405 and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(GetAttacker()))
endfunction

function ice_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'Bfro')<1)
endfunction
function icemag_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'BHca')<1)
endfunction
function den1_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'B007')<1) and (GetUnitAbilityLevel(GetFilterUnit(),'B004')<1)
endfunction

function Trig_den_auto_Actions takes nothing returns nothing
local unit u=GetAttacker()
local location TempLoc
local group TempGroup
   if (GetUnitTypeId(u) == 'oC31') then
     call PolledWait(0.2)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(900, TempLoc, Condition(function den1_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     //call DisplayTextToPlayer(GetOwningPlayer(u),0,0,I2S(CountUnitsInGroup(TempGroup)))
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'o00A') then
     call PolledWait(0.12)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(1100, TempLoc, Condition(function den1_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'o00N') then
     call PolledWait(0.11)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(1050, TempLoc, Condition(function ice_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'oC85') then
     call PolledWait(0.2)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(850, TempLoc, Condition(function ice_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'hC13') then
     call PolledWait(1.0)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(600, TempLoc, Condition(function ice_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'h00F') then
     call PolledWait(0.5)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(800, TempLoc, Condition(function ice_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
   if (GetUnitTypeId(u) == 'hC05') then
     call PolledWait(0.9)
     set TempLoc=GetUnitLoc(u)
     set TempGroup = GetUnitsInRangeOfLocMatching(600, TempLoc, Condition(function icemag_enemy))
     call IssueTargetOrderBJ(u, "attack", FirstOfGroup(TempGroup) )
     call DestroyGroup(TempGroup)
     call RemoveLocation(TempLoc)
   endif
  set u=null
endfunction
You can see the same paragraph keep repeating itself with minor tweaks.

Attempt to fix, leaving out alot of the unneeded parts
Code: 
function gen_enemy takes nothing returns boolean
   return GetUnitState(GetFilterUnit(),UNIT_STATE_LIFE)>0.405 and IsUnitEnemy(GetFilterUnit(),GetOwningPlayer(GetAttacker()))
endfunction

function ice_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'Bfro')<1)
endfunction
function icemag_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'BHca')<1)
endfunction
function den1_enemy takes nothing returns boolean
   return gen_enemy() and (GetUnitAbilityLevel(GetFilterUnit(),'B007')<1) and (GetUnitAbilityLevel(GetFilterUnit(),'B004')<1)
endfunction

function retarget takes unit atk, real wt, real Range, code ab3 returns nothing
local location TempLoc
local group TempGroup
   call PolledWait(wt)
   set TempLoc=GetUnitLoc(atk)
   set TempGroup = GetUnitsInRangeOfLocMatching(Range, TempLoc, Condition(function ab3))
   call IssueTargetOrderBJ(atk, "attack", FirstOfGroup(TempGroup) )
   call DestroyGroup(TempGroup)
   call RemoveLocation(TempLoc)
endfunction

function Trig_den_auto_Actions takes nothing returns nothing
local unit u=GetAttacker()
   if (GetUnitTypeId(u) == 'oC31') then
     call retarget(u,0.3,900,den1_enemy)
   endif
   if (GetUnitTypeId(u) == 'o00A') then
     call retarget(u,0.12,1100,den1_enemy)
   endif
   if (GetUnitTypeId(u) == 'o00N') then
     call retarget(u,0.11,1050,ice_enemy)
   endif
...

The problem is the retarget function is not saving properly, the game keeps giving me a "expected a name" error message.
I have tried putting the condition functions (e.g. "den1_enemy") upwards as code or boolexpr with no success.
Please help! Explanation of why I am failing or advice on how to get it to work would be greatly appreciated.

P.S.
Leaving the conditions out of the retarget function would undo half of what I attempted to accomplish by reformatting this trigger.
 
jonas

jonas

You can change this now in User CP.
Reaction score
66
afisakov said:
[/code]
function Trig_den_auto_Actions takes nothing returns nothing
local unit u=GetAttacker()
if (GetUnitTypeId(u) == 'oC31') then
call retarget(u,0.3,900,den1_enemy)
endif
if (GetUnitTypeId(u) == 'o00A') then
call retarget(u,0.12,1100,den1_enemy)
endif
if (GetUnitTypeId(u) == 'o00N') then
call retarget(u,0.11,1050,ice_enemy)
endif
...
[/code]
Click to expand...

Have you tried putting "function" in front of the names, like this:

JASS:
call retarget(u, 0.11, 1050,  function ice_enemy)


Also, remove it from the other place:
JASS:
Condition(ab3)


This is how I remember the syntax, but it has been years since I used it.
I'm only using zinc nowadays:

http://www.wc3c.net/vexorian/zincmanual.html#anonfunc

Also, if you have strange syntax errors and you can't really place them, I recommend delta debugging...
https://www.st.cs.uni-saarland.de/dd/
 
afisakov

afisakov

You can change this now in User CP.
Reaction score
37
jonas said:
Have you tried putting "function" in front of the names, like this:

JASS:
call retarget(u, 0.11, 1050,  function ice_enemy)


Also, remove it from the other place:
JASS:
Condition(ab3)


This is how I remember the syntax, but it has been years since I used it.
I'm only using zinc nowadays:

http://www.wc3c.net/vexorian/zincmanual.html#anonfunc

Also, if you have strange syntax errors and you can't really place them, I recommend delta debugging...
https://www.st.cs.uni-saarland.de/dd/
Click to expand...

It now works.
I figured it probably had something to do with my syntax but did not know how to find the correct way to write it. Trial and error were not cooperating and WE does not give very good error messages.

Thank You!
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/
  • The Helper The Helper:
    Here is another comfort food favorite - Million Dollar Casserole - https://www.thehelper.net/threads/recipe-million-dollar-casserole.193614/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      361 (members: 0, guests: 361)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top