Code Speed: Functions

[NoobImbaPro]

They have same speed or second is faster?

.
    function A takes nothing returns nothing
        //a bunch of lines
    endfunction

    function B takes nothing returns nothing
        if condition then
            call A()
        endif
    endfunction

.
    function B takes nothing returns nothing
        if condition then
            //lines of function A
        endif
    endfunction

 

[luorax]

The second is faster, obviously.

 

[dudeim]

Function calls are pretty slow in jass so the second example is faster.

 

[tooltiperror]

This is (usually) even better, though:

function B takes nothing returns nothing
    if not condition then
        return
    endif
    // lines of function A
endfunction

This way you can skip the rest of the function (like searching for the [ljass]endif[/ljass].)

 

[SerraAvenger]

Fuck speed.
Vexorian's optimizer transformed the first to the second in most cases anyway.

 

[Bribe]

Only if function A was only one line of code. Otherwise it wouldn't (couldn't).

 

[WaterKnight]

Functions without parameters cost nearly nothing. Else it has to declare the locals and assign them the incoming values. But it's nuts to make this priority. There are other interests mapmakers strive for like progress, modularity, not write the same things twice, build greater structures. Would only do this if it was really necessary in the standalone low-level.

 

[Bribe]

I use functions to avoid duplicate text whenever possible. I also recommend to anyone else to do the same.