Custom Chain Heal not working

[Leazy]

Hello!

I created a custom Chain Heal (I triggered the whole ability). This is how I did it:

• Chain Heal
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Chain Heal
        • (Ability being cast) Equal to Chain Heal (Instant)
  • Actions
    • Set Caster = (Triggering unit)
    • Set Target = (Target unit of ability being cast)
    • Set Point[1] = (Position of Caster)
    • Set Point[2] = (Position of Target)
    • Unit Group - Add Target to UnitGroup[1]
    • Lightning - Create a Healing Wave - Primary lightning effect from source Point[1] to target Point[2]
    • Lightning - Destroy (Last created lightning effect)
    • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
    • Set Healing = (Random real number between 250.00 and 275.00)
    • Set SpellPower_Percent = 0.33
    • Trigger - Run Spell Power <gen> (checking conditions)
    • Trigger - Run Critical Strike <gen> (checking conditions)
    • Unit - Set life of Target to ((Life of Target) + Healing)
    • Trigger - Run Healing Text <gen> (checking conditions)
    • Set UnitGroup[2] = (Units within 600.00 of Point[2] matching (((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of Caster)) Equal to True)) and ((((Matching unit) is in UnitGroup[1]) Equal to False) and ((Life of (Matching unit)) Les
    • Set UnitGroup[3] = (Random 1 units from UnitGroup[2])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (UnitGroup[3] is empty) Equal to False
      • Then - Actions
        • Unit Group - Pick every unit in UnitGroup[3] and do (Actions)
          • Loop - Actions
            • Set Target = (Picked unit)
            • Set Point[3] = (Position of Target)
            • Unit Group - Add Target to UnitGroup[1]
            • Lightning - Create a Healing Wave - Primary lightning effect from source Point[2] to target Point[3]
            • Lightning - Destroy (Last created lightning effect)
            • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
            • Set Healing = (Random real number between 250.00 and 275.00)
            • Set SpellPower_Percent = 0.33
            • Trigger - Run Spell Power <gen> (checking conditions)
            • Trigger - Run Critical Strike <gen> (checking conditions)
            • Set Healing = (Healing x 0.60)
            • Unit - Set life of Target to ((Life of Target) + Healing)
            • Trigger - Run Healing Text <gen> (checking conditions)
        • Set UnitGroup[4] = (Units within 600.00 of Point[3] matching (((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of Caster)) Equal to True)) and ((((Matching unit) is in UnitGroup[1]) Equal to False) and ((Life of (Matching unit)) Les
        • Set UnitGroup[5] = (Random 1 units from UnitGroup[4])
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (UnitGroup[5] is empty) Equal to False
          • Then - Actions
            • Unit Group - Pick every unit in UnitGroup[5] and do (Actions)
              • Loop - Actions
                • Set Target = (Picked unit)
                • Set Point[4] = (Position of Target)
                • Unit Group - Add Target to UnitGroup[1]
                • Lightning - Create a Healing Wave - Primary lightning effect from source Point[3] to target Point[4]
                • Lightning - Destroy (Last created lightning effect)
                • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
                • Set Healing = (Random real number between 250.00 and 275.00)
                • Set SpellPower_Percent = 0.33
                • Trigger - Run Spell Power <gen> (checking conditions)
                • Trigger - Run Critical Strike <gen> (checking conditions)
                • Set Healing = (Healing x 0.36)
                • Unit - Set life of Target to ((Life of Target) + Healing)
                • Trigger - Run Healing Text <gen> (checking conditions)
          • Else - Actions
      • Else - Actions

My problems are:
1 - Same target are some times healed twice.
2 - The lightning effects doesn't show up.

 

[LurkerAspect]

Leak central man! All those groups you use need to be removed like this:

• Custom Script: call DestroyGroup(udg_UnitGroup[1])

You also need to destroy your special effect immediately after you create it, it will still play the death animation (or if it only has one animation, then that one) and then destroy itself so no memory is leaked.

Your lightning won't show if you destroy it immediately after creating it, set each one to a variable and at the end of the trigger, add a wait and then destroy all your lightning effects.

Also, instead of using "Random 1 units from unit group", create a unit variable and then do this: "Set Unit = Random Unit from Unit Group" and then just use that variable when referring to that unit. Then instead of "Is Unit Group Empty = false", check if "Unit not equal to No Unit".

Finally, why are you running all those other triggers in the meantime? If any of them have waits in them, it will only cause trouble!

 

[Leazy]

Thanks for the help, I was a bit lazy but have now fixed all leaks (except for the special effects, some funky yellow glow appears after destroying the Healing Wave effect). The same target is still healed twice some times. None of the triggers running in the meantime have waits.

• Chain Heal
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Chain Heal
        • (Ability being cast) Equal to Chain Heal (Instant)
  • Actions
    • Custom script: local lightning array Beam
    • Set Caster = (Triggering unit)
    • Set Target = (Target unit of ability being cast)
    • Set Point[1] = (Position of Caster)
    • Set Point[2] = (Position of Target)
    • Unit Group - Add Target to UnitGroup[1]
    • Lightning - Create a Healing Wave - Primary lightning effect from source Point[1] to target Point[2]
    • Custom script: set Beam[1] = GetLastCreatedLightningBJ()
    • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
    • Set Healing = (Random real number between 250.00 and 275.00)
    • Set SpellPower_Percent = 0.33
    • Trigger - Run Spell Power <gen> (checking conditions)
    • Trigger - Run Critical Strike <gen> (checking conditions)
    • Trigger - Run Riptide Chain Heal <gen> (checking conditions)
    • Unit - Set life of Target to ((Life of Target) + Healing)
    • Trigger - Run Healing Text <gen> (checking conditions)
    • Trigger - Run Natures Swiftness Remove <gen> (checking conditions)
    • Set UnitGroup[2] = (Units within 600.00 of Point[2] matching (((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of Caster)) Equal to True)) and ((((Matching unit) is in UnitGroup[1]) Equal to False) and ((Life of (Matching unit)) Les
    • Set Target = No unit
    • Set Target = (Random unit from UnitGroup[2])
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Target Not equal to No unit
      • Then - Actions
        • Set Point[3] = (Position of Target)
        • Unit Group - Add Target to UnitGroup[1]
        • Lightning - Create a Healing Wave - Primary lightning effect from source Point[2] to target Point[3]
        • Custom script: set Beam[2] = GetLastCreatedLightningBJ()
        • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
        • Set Healing = (Random real number between 250.00 and 275.00)
        • Set SpellPower_Percent = 0.33
        • Trigger - Run Spell Power <gen> (checking conditions)
        • Trigger - Run Critical Strike <gen> (checking conditions)
        • Set Healing = (Healing x 0.60)
        • Unit - Set life of Target to ((Life of Target) + Healing)
        • Trigger - Run Healing Text <gen> (checking conditions)
        • Set UnitGroup[3] = (Units within 600.00 of Point[3] matching (((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of Caster)) Equal to True)) and ((((Matching unit) is in UnitGroup[1]) Equal to False) and ((Life of (Matching unit)) Les
        • Set Target = No unit
        • Set Target = (Random unit from UnitGroup[3])
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Target Not equal to No unit
          • Then - Actions
            • Set Point[4] = (Position of Target)
            • Unit Group - Add Target to UnitGroup[1]
            • Lightning - Create a Healing Wave - Primary lightning effect from source Point[3] to target Point[4]
            • Custom script: set Beam[3] = GetLastCreatedLightningBJ()
            • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
            • Set Healing = (Random real number between 250.00 and 275.00)
            • Set SpellPower_Percent = 0.33
            • Trigger - Run Spell Power <gen> (checking conditions)
            • Trigger - Run Critical Strike <gen> (checking conditions)
            • Set Healing = (Healing x 0.36)
            • Unit - Set life of Target to ((Life of Target) + Healing)
            • Trigger - Run Healing Text <gen> (checking conditions)
          • Else - Actions
      • Else - Actions
    • Custom script: call RemoveLocation (udg_Point[1])
    • Custom script: call RemoveLocation (udg_Point[2])
    • Custom script: call RemoveLocation (udg_Point[3])
    • Custom script: call RemoveLocation (udg_Point[4])
    • Custom script: call DestroyGroup (udg_UnitGroup[1])
    • Custom script: call DestroyGroup (udg_UnitGroup[2])
    • Custom script: call DestroyGroup (udg_UnitGroup[3])
    • Wait 1.00 seconds
    • Custom script: call DestroyLightning( Beam[1] )
    • Custom script: call DestroyLightning( Beam[2] )
    • Custom script: call DestroyLightning( Beam[3] )

 

[hopy]

1 - Same target are some times healed twice.
This can be prevented by something like adding the units that have been healed to a unit group and preventing the trigger from healing people in that unit group. Also make sure you prevent the trigger from looping more times than there are units in the area to be healed.

2 - The lightning effects doesn't show up.
That's because the lightning effect gets removed instantly, it gets created and destroyed in about 0.01 seconds.

3 - My game lags afther about 5 casts of this spell.
It leaks.

Right, the spell (heal) bounces to two more targets right? So heals a total of 3 people?

• Chain Heal
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • Or - Any (Conditions) are true
      • Conditions
        • (Ability being cast) Equal to Chain Heal
        • (Ability being cast) Equal to Chain Heal (Instant)
  • Actions
    • Set Caster = (Triggering unit)
    • Set Target = (Target unit of ability being cast)
    • Set Point[1] = (Position of Caster)
    • Set Point[2] = (Position of Target)
    • Lightning - Create a Healing Wave - Primary lightning effect from source Point[1] to target Point[2]
    • Set Lightning Effect[1] = (Last created lightning effect)
    • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
    • Special Effect - Destroy (Last created special effect)
    • Set Healing = (Random real number between 250.00 and 275.00)
    • Set SpellPower_Percent = 0.33
    • Trigger - Run Spell Power <gen> (checking conditions)
    • Trigger - Run Critical Strike <gen> (checking conditions)
    • Unit - Set life of Target to ((Life of Target) + Healing)
    • Trigger - Run Healing Text <gen> (checking conditions)
    • Set UnitGroup[1] = (Units within 600.00 of Point[2] matching (((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an ally of (Owner of Caster)) Equal to True)) and ((((Matching unit) is equal to Target) Equal to False) and ((Life of (Matching unit)) Les
    • If ((Number of units in Unit_Group[1]) Greater than 2) then do (Set Interger = 2) else do (Set Interger = (Number of units in Unit_Group[1]))
    • For each (Integer A) from 1 to Interger, do (Actions)
      • Loop - Actions
        • Set UnitGroup[2] = (Random 1 units from UnitGroup[1])
        • Unit Group - Pick every unit in UnitGroup[2] and do (Actions)
          • Loop - Actions
            • Set Target = (Picked unit)
            • Set Point[3] = (Position of Target)
            • Unit Group - Remove (Picked unit) from Unit_Group[1]
            • Lightning - Create a Healing Wave - Primary lightning effect from source Point[2] to target Point[3]
            • Set Lightning Effect[(Intreger A) + 1] = (Last created lightning effect)
            • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\HealingWave\HealingWaveTarget.mdl
            • Special Effect - Destroy (Last created special effect)
            • Set Healing = (Random real number between 250.00 and 275.00)
            • Set SpellPower_Percent = 0.33
            • Trigger - Run Spell Power <gen> (checking conditions)
            • Trigger - Run Critical Strike <gen> (checking conditions)
            • For each (Integer B) from 1 to (Integer A), do (Actions)
              • Loop - Actions
                • Set Healing = (Healing x 0.60)
            • Unit - Set life of Target to ((Life of Target) + Healing)
            • Trigger - Run Healing Text <gen> (checking conditions)
            • Custom script: call RemoveLocation (udg_Point[3])
        • Custom script: call DestroyGroup (udg_Unit_Group[2])
    • Countdown Timer - Start Lightning Effects as a One-shot timer that will expire in 1.00 seconds
    • Custom script: call DestroyGroup (udg_Unit_Group[1])
    • Custom script: call RemoveLocation (udg_Point[2])
    • Custom script: call RemoveLocation (udg_Point[1])

There we go, Shorter, leakless and should be working 100% fine.

As for the timer/lightning effects:

• Destroy Lightning
  • Events
    • Time - Lightning expires
  • Conditions
  • Actions
    • Lightning - Destroy Lightning Effect[1]
    • Lightning - Destroy Lightning Effect[2]
    • Lightning - Destroy Lightning Effect[3]

Something like that... Please keep in mind that this is hand typed for most part. Hope it helped, and please let me know if there's anything that doesn't work or you don't understand.

=======EDIT=======
I've found the reason why it healed the same targets more than once:
You added all units into Unit_Group[2] and than picked a unit from Unit_Group[2], since the picked unit didn't get removed from Unit_Group[2] and Unit_Group[2] didn't get set again without the already picked unit it was posible for it to be picked again in the 2nd or 3rd wave.
*Points at trigger* "Unit Group - Remove (Picked unit) from Unit_Group[1]" "(Matching unit) is equal to Target Equal to False".

=======/EDIT=======

 

[Leazy]

How can that be the problem? I make a new unitgroup both times, and add all units healed to unit group 1, no units in unit group 1 should be healed? =O

 

[hopy]

How can that be the problem? I make a new unitgroup both times, and add all units healed to unit group 1, no units in unit group 1 should be healed? =O

No, you're right I'm sorry... I didn't notice the "Set UnitGroup[3] = Blahblah" part of the trigger. I'll take another look and see if I can find out why.
I'm pretty sure it doesn't do that with my trigger though... shouldn't anyways... <,<

 

[D4RK_G4ND4LF]

I once made a healing wave trigger for someone @ hive
http://www.hiveworkshop.com/forums/requests-341/need-custom-healing-wave-167102/#post1598302
you can use it or have a look at it to see how I did it

 

[Leazy]

Thank you DARKGANDALF, but I would very much want to know what's wrong with my trigger

 

[Whoareyou.]

Would looking at his custom chain heal trigger help? Cuz he even said for you if needed to look at it.

 

[Leazy]

Of course I looked at it, but he used such a different way of doing this than I did, but still used the same key elements I did, so it didn't really help me out.

 

[Whoareyou.]

Change triggers to his instead of yours? Or do you still want to learn whats wrong?

 

[Sartan]

there where a chain heal thread up for not a long time ago, they simple solves it by using a dummy to cast a negative healing wave with -0.01 damage and then detect if a unit takes damage of that dummy, use custom heal etc etc.




Edit here is the thread:
http://www.thehelper.net/forums/showthread.php?t=156497&highlight=chain+heal

 

[Leazy]

@ Spartan:

Of course! Great idea I actually tried something similar to start with, I used Chain Lightning and did what you said, but chain lightning couldn't probably target allies disregarding of targets allowed. I didn't ever think of Healing Wave.

Thanks m8! +rep