Custom script

[ultimate11]

what is wrong with this script?

• Custom script: call DestroyGroup(udg_Air_rune[GetOwningPlayer(GetTriggerUnit())])

Sry solved my mistake
[GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))] this was good

 

[inevit4ble]

wouldn't it be just "GetPlayerId(GetOwningPlayer(GetTriggerUnit()))"?

 

[luorax]

[ljass]GetConvertedPlayerId(GetOwningPlayer(GetTriggerUnit()))[/ljass] returns 1 for Player 1, and it is used in GUI, whilst [ljass]GetPlayerId(GetOwningPlayer(GetTriggerUnit()))[/ljass] returns 0 for player 1.

If the variable is set via the GUI editor, then the first way is the right way.

However you may try using simply [ljass]GetConvertedPlayerId(GetTriggerPlayer())[/ljass] or [ljass]GetPlayerId(GetTriggerPlayer())+1[/ljass]. If I recall correctly, [ljass]GetTriggerPlayer()[/ljass] returns the owner of triggering unit if the event is fired by some unit event. Not sure, but it definitely worth a try as it may increase the speed of your spell (even drastically if used many times in the trigger, which is important as GUI things are kinda slow)

 

[ZakkWylde-]

...

However you may try using simply [ljass]GetConvertedPlayerId(GetTriggerPlayer())[/ljass] or [ljass]GetPlayerId(GetTriggerPlayer())+1[/ljass]. If I recall correctly, [ljass]GetTriggerPlayer()[/ljass] returns the owner of triggering unit if the event is fired by some unit event. ...

Hmm, really? That would be quite cool. But I don't see it happening, unless perhaps the trigger was a [ljass]playerunitevent[/ljass] ... and then I have a shred of hope.
I'm interested in how this turns out, if it is tried.

 

[inevit4ble]

Ye that is interesting, as I'm am custom to using GetOwningPlayer(GetTriggerUnit())

 

[luorax]

• Test
  • Events
    • Unit - Faceless Devourer 0009 <gen> Starts the effect of an ability
  • Conditions
  • Actions
    • Game - Display to (All players) the text: (Name of (Triggering player))

• Test 2
  • Events
    • Unit - A unit owned by Player 1 (Red) Starts the effect of an ability
  • Conditions
  • Actions
    • Game - Display to (All players) the text: (Name of (Triggering player))

• Test 3
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
  • Actions
    • Game - Display to (All players) the text: (Name of (Triggering player))

The displayed text was Luorax in all cases. So I was right.

 

[inevit4ble]

so if I understand correctly

GetOwningPlayer is not required in most cases.

Actually, when would you need to use it

 

[luorax]

Sometimes you need the owner of AttackedUnit or KillingUnit, for example. In that case, it is useful.

 

[inevit4ble]

Ah yes, true story. This is a very useful piece of knowledge

 

[ZakkWylde-]

WHAT IS THIS LIMIT ON +REP ABILITY!!!

Thanks Luorax, for actually doing what I was too lazy to .
So does this "save" a function call, or is it somehow IMPLIED in the native that GetTriggerPlayer() that if the Trigger wasn't a player, get the owner...(and use a function call to do this)?

[Hope that made sense...]