Damage detection trigger, NOT working

sunshinex3

You can change this now in User CP.
I need to figure out why this isn't working, it fires off when not using the variables and just using a solid number so the second trigger works but when trying to use the bidedamagetaken variable it doesn't work, so im wondering if it is the custom script that is just below that's the problem?

I have this is in initialization its a custom script i was told would add the event unit takes damage to a trigger
Code:
library DamagedEventAdder initializer init
  private function init takes nothing returns nothing

    //change the name of the trigger to match the name of the trigger you want it added to
    //the format is: gg_trg_ + the name of the trigger with _ instead of spaces (see below)

    //if you change the name of the trigger in the trigger editor (or delete the trigger entirely) you will have to change it here
    //if you have multiple triggers that need this event you can duplicate the below line here for any number of triggers, just use the right name!

    call TriggerRegisterAnyUnitEventBJ(gg_trg_BideActivate, EVENT_PLAYER_UNIT_DAMAGED)
  endfunction
endlibrary
First trigger that i need "unit takes damage"
Trigger:
  • BideActivate
    • Events
    • Conditions
      • ((Damage Target) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Damage Target)))] = (BideDamageTaken[(Player number of (Owner of (Damage Target)))] + (Damage taken))


this trigger works with a straight number but not with the variable arithmetic that i have here

Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Custom script: call RemoveLocation (udg_TempPoint)
[/code]
 
Last edited:

jonas

Ultra Cool Member
Add some debug messages.
Display the damage taken and the new value of BideDamageTaken in the first trigger.
Display the BideDamageTaken and the Level of Bide in the second trigger.

If your first trigger doesn't fire, remove the condition.

If even without the conditon it doesn't fire, it is the custom script. In that case please repost the custom script with
Code:
 code tags
 

jonas

Ultra Cool Member
Yep. The code itself looks good to me though.
Can you post a screenshot of the code in your trigger editor?

Maybe it is accidentally turned off, or in the comment section.

Another thing you can try is a new GUI trigger like this:

event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
 

sunshinex3

You can change this now in User CP.
event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
"can't find (triggering unit) takes damage"
i think that's why i had to add the custom script library.
 
Last edited:

jonas

Ultra Cool Member
Unfortunately I don't have Wc3 installed, but I was sure there is a GUI function to make that happen.
If there isn't, you can also try with this line of custom script which should do the same:



Another thing you can do is add the following to the custom script you already have:

Code:
if gg_trg_BideActivate == null then
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called but trigger is null")
else
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called and trigger exists")
endif
This should write some text at the beginning of the game. (Let me know if there are any syntax errors... sorry that I can't check that myself)
 

sunshinex3

You can change this now in User CP.
I am going to put this behind me i guess it's not possible with gui this is what i did it turned out fine.

Trigger:
  • BideActivate
    • Events
      • Unit - A unit Is attacked
    • Conditions
      • ((Attacked unit) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Attacked unit)))] = (BideDamageTaken[(Player number of (Owner of (Attacked unit)))] + 1.00)


Number is increased based on how many attacks are made on the unit instead of damage taken, works well with tanks.


Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Ordered unit)))] = 0.00
      • Custom script: call RemoveLocation (udg_TempPoint)



causes damage based on number of attacks made on caster and then resets the damage to 0.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    I have a GIF though
  • tom_mai78101 tom_mai78101:
    In the GIF, I've configured it so the lower the "Main Value" is, the better. I had to compress it pretty far down though.
  • tom_mai78101 tom_mai78101:
    And this is the thread with the video that shows the wall clip. https://tasvideos.org/Forum/Topics/23453
    +2
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top