Damage detection trigger, NOT working

sunshinex3

You can change this now in User CP.
I need to figure out why this isn't working, it fires off when not using the variables and just using a solid number so the second trigger works but when trying to use the bidedamagetaken variable it doesn't work, so im wondering if it is the custom script that is just below that's the problem?

I have this is in initialization its a custom script i was told would add the event unit takes damage to a trigger
Code:
library DamagedEventAdder initializer init
  private function init takes nothing returns nothing

    //change the name of the trigger to match the name of the trigger you want it added to
    //the format is: gg_trg_ + the name of the trigger with _ instead of spaces (see below)

    //if you change the name of the trigger in the trigger editor (or delete the trigger entirely) you will have to change it here
    //if you have multiple triggers that need this event you can duplicate the below line here for any number of triggers, just use the right name!

    call TriggerRegisterAnyUnitEventBJ(gg_trg_BideActivate, EVENT_PLAYER_UNIT_DAMAGED)
  endfunction
endlibrary
First trigger that i need "unit takes damage"
Trigger:
  • BideActivate
    • Events
    • Conditions
      • ((Damage Target) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Damage Target)))] = (BideDamageTaken[(Player number of (Owner of (Damage Target)))] + (Damage taken))


this trigger works with a straight number but not with the variable arithmetic that i have here

Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Custom script: call RemoveLocation (udg_TempPoint)
[/code]
 
Last edited:

jonas

Ultra Cool Member
Add some debug messages.
Display the damage taken and the new value of BideDamageTaken in the first trigger.
Display the BideDamageTaken and the Level of Bide in the second trigger.

If your first trigger doesn't fire, remove the condition.

If even without the conditon it doesn't fire, it is the custom script. In that case please repost the custom script with
Code:
 code tags
 

jonas

Ultra Cool Member
Yep. The code itself looks good to me though.
Can you post a screenshot of the code in your trigger editor?

Maybe it is accidentally turned off, or in the comment section.

Another thing you can try is a new GUI trigger like this:

event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
 

sunshinex3

You can change this now in User CP.
event : a unit enters the map
condition: type of triggering unit is (Nerubian King)
action: add event to trigger (BideActivate) : (triggering unit) takes damage
"can't find (triggering unit) takes damage"
i think that's why i had to add the custom script library.
 
Last edited:

jonas

Ultra Cool Member
Unfortunately I don't have Wc3 installed, but I was sure there is a GUI function to make that happen.
If there isn't, you can also try with this line of custom script which should do the same:



Another thing you can do is add the following to the custom script you already have:

Code:
if gg_trg_BideActivate == null then
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called but trigger is null")
else
    call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "initialization called and trigger exists")
endif
This should write some text at the beginning of the game. (Let me know if there are any syntax errors... sorry that I can't check that myself)
 

sunshinex3

You can change this now in User CP.
I am going to put this behind me i guess it's not possible with gui this is what i did it turned out fine.

Trigger:
  • BideActivate
    • Events
      • Unit - A unit Is attacked
    • Conditions
      • ((Attacked unit) has buff Biding (NerubianKing)) Equal to True
    • Actions
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Attacked unit)))] = (BideDamageTaken[(Player number of (Owner of (Attacked unit)))] + 1.00)


Number is increased based on how many attacks are made on the unit instead of damage taken, works well with tanks.


Trigger:
  • BideDeactivate
    • Events
      • Unit - A unit Is issued an order with no target
    • Conditions
      • And - All (Conditions) are true
        • Conditions
          • ((Ordered unit) has buff Biding (NerubianKing)) Equal to True
          • (Issued order) Equal to (Order(unimmolation))
    • Actions
      • Set VariableSet TempPoint = (Position of (Ordered unit))
      • Unit - Cause (Ordered unit) to damage circular area after 0.00 seconds of radius 400.00 at TempPoint, dealing (BideDamageTaken[(Player number of (Owner of (Ordered unit)))] x (Real((Level of Bide (NerubianKing) for (Ordered unit))))) damage of attack type Spells and damage type Magic
      • Set VariableSet BideDamageTaken[(Player number of (Owner of (Ordered unit)))] = 0.00
      • Custom script: call RemoveLocation (udg_TempPoint)



causes damage based on number of attacks made on caster and then resets the damage to 0.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Blackveiled Blackveiled:
    count on it then cause you don't live that far from me hah
  • The Helper The Helper:
    really that is cool!
  • The Helper The Helper:
    Hey Tom I added a new Weird tag to the News Prefixes
  • The Helper The Helper:
    What is up Blackveiled?
  • Blackveiled Blackveiled:
    Chillin', lurkin'. :D
  • The Helper The Helper:
    I am working on a bunch of site projects right now doing a bunch of behind the scenes stuff and trying to clean up some stuff that I let slide when I got lazy with the site for a few years...
  • The Helper The Helper:
    Are you in Houston Blackveiled or just in Texas?
  • Blackveiled Blackveiled:
    Houston
  • Blackveiled Blackveiled:
    I've been living here since 2014.
  • The Helper The Helper:
    OK banlord we need to get together soon! The only other member of the site I know in Houston is XXX Conan
  • The Helper The Helper:
    and he does not want none lol
  • The Helper The Helper:
    he put up a picture of his mom one time and she was HOT!
  • The Helper The Helper:
    I wish we still had that
  • Blackveiled Blackveiled:
    Lmao you scared him off I see.
  • The Helper The Helper:
    he will be back
  • The Helper The Helper:
    Conan was like 12 when he started here
  • The Helper The Helper:
    I literally think I was his male role model
  • Blackveiled Blackveiled:
    Yeah I was 12 when I started here as well.
  • The Helper The Helper:
    you guys were just kids
  • The Helper The Helper:
    I was in my 30s when i got the Blizzard MVP
  • The Helper The Helper:
    I am 53
  • Wizard Wizard:
    Happy Birthday!
  • The Helper The Helper:
    not my birthday
  • The Helper The Helper:
    but thanks lol
  • Blackveiled Blackveiled:
    and I'll be 30 in January lmao

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top