System Damage

Jesus4Lyf

Good Idea™
is there a way to block percent of damage taken? if not, why don't you replace this:
JASS:
public function BlockAll takes nothing returns nothing
    set ToBlock[TypeStackLevel]=ToBlock[TypeStackLevel]+GetEventDamage()
endfunction

with this:
JASS:
public function BlockPercent takes real percent returns nothing
    set ToBlock[TypeStackLevel]=ToBlock[TypeStackLevel] + GetEventDamage()*percent
endfunction

percent being any number between 0 and 1

I've changed it like that for my map (hope you don't mind) and it works
You can write a wrapper function.
JASS:
function Damage_BlockPercent takes real percent returns nothing
    call Damage_Block(GetEventDamage()*percent)
endfunction

Best approach, doesn't touch the library. I believe it will inline, too. :)
 

Jesus4Lyf

Good Idea™

muzk

Member
:D

JASS:

    function UnitDamageTargetEx takes unit whichUnit, widget target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
        local boolean result
        set TypeStackLevel=TypeStackLevel+1
        set TypeStackValue[TypeStackLevel]=damageType
        set TypeStackAttack[TypeStackLevel]=attack
        set result=UnitDamageTarget(whichUnit,target,amount,attack,ranged,attackType,damageType,weaponType)
        set TypeStackLevel=TypeStackLevel-1
        return result
    endfunction


I don't understand it. Why arrays and not just non-array globals?
 

Bribe

vJass errors are legion
Because of recursion. Although it would be more efficient (and more intuitive) if he did something like this:

JASS:
function UnitDamageTargetEx takes unit whichUnit, widget target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
    local boolean result
    local damagetype dt = DamageType
    local integer ia = IsAttack
    set IsAttack = attack
    set DamageType = damageType
    set result = UnitDamageTarget(whichUnit, target, amount, attack, ranged, attackType, damageType, weaponType)
    set DamageType = dt
    set IsAttack = ia
    set dt = null
    return result
endfunction
 

Bribe

vJass errors are legion
It is not much more efficient, according to my FPS tests, what is going to matter is repeat-referencing because you are returning a scalar via GetEventDamageType instead of an array lookup, for example. It saves creation of globals and global arrays as well. It's probably easier to code it your way but it's definitely lighter on the processor by hashing it into some locals.
 

Jesus4Lyf

Good Idea™
It is not much more efficient, according to my FPS tests, what is going to matter is repeat-referencing because you are returning a scalar via GetEventDamageType instead of an array lookup, for example. It saves creation of globals and global arrays as well. It's probably easier to code it your way but it's definitely lighter on the processor by hashing it into some locals.
FPS tests... lol, back in my day it was benchmarks or don't say anything.

If you care about that sort of efficiency, you should only have one trigger firing off Damage, and then fork through a tree structure to only fire the correct event responses based on what type of damage, if it's an attack, etc. Isn't this is the most efficient way to support that, since GetEventDamageType would only ever be called once each time?

And if you don't care about that sort of efficiency, good on you, you might even complete a map! :D
 

Bribe

vJass errors are legion
RtC benchmarks don't work any more, so now it's pretty much FPS tests or don't say anything.
 

kStiyl

New Member
I'm having a strange bug with this system

If I add some kind of ability (ex. slow aura-based debuff) on the damage event, Damage_Block seems to bug (it won't block any damage)

I've tested it on your demo map by just switching your demo code with this library below.

After making an attempt to debug this, I found that adding an ability triggers the event.
I do not understand why this would bug the system though; isn't it supposed to be recursive?

I fixed this bug temporarily by adding GetEventDamage() > 0 on 'onDamageActions' in damage library

JASS:
library Test initializer onInit requires Damage
        
    private function onHit takes nothing returns boolean
    	call Damage_BlockAll()
        call UnitAddAbility(GetTriggerUnit(), 'Aasl')
        call UnitRemoveAbility(GetTriggerUnit(), 'Aasl')
        call UnitRemoveAbility(GetTriggerUnit(), 'Basl')
        return false
    endfunction
        
    private function onInit takes nothing returns nothing
        local trigger trg = CreateTrigger()
        call Damage_RegisterEvent(trg)
        call TriggerAddCondition(trg, Condition(function onHit))
        set trg = null
    endfunction

endlibrary


Would appreciate it if you give me a solution. I'm having a huge problem because this is continuously interfering with my debuff system =( (poison, stun etc.)
 

Mr_Bean355

Member
The test scope. I think it is meant to block all damage in the demo map, but when I test it, nothing happens. Unit receive damage as normal. I re-downloadede the demo map and tested it without changing anything - still didn't help.
 

BlackRose

Forum User
Indeed it is meant to block all damage in the demo map. Strange how nothing happens upon testing. It should work without any editing. Place debug messages in the function to see if the code is actually running.
 

Mr_Bean355

Member
JASS:
scope NoDamageOnMap initializer StartZeroDamage
private function BlockAllDamage takes nothing returns boolean
call BJDebugMsg("Damaged!")
call Damage_BlockAll()
return false
endfunction
 
private function StartZeroDamage takes nothing returns nothing
local trigger t=CreateTrigger()
call TriggerAddCondition(t,Condition(function BlockAllDamage))
call Damage_RegisterEvent(t)
endfunction
endscope


Nothing displays :eek:

EDIT: Turns out the issue was the JASSHelper version I have. The latest one (by Cohadar) compiles the map in a strange order, meaning Damage won't work for pre-placed units. After down-grading to an earlier version of JASSHelper, it works fine.
 

Grundy

Ultra Cool Member
So does this system discard "damagetype"s like DAMAGE_TYPE_ACID, DAMAGE_TYPE_COLD, DAMAGE_TYPE_DEATH, DAMAGE_TYPE_DEFENSIVE, etc... and instead uses only 3 damage types, physical, magical, and pure?
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • The Helper The Helper:
    seeing some weird stuff doing some moves to the new Weird News forum please see the bathroom admins
  • The Helper The Helper:
    :) it is weird
  • The Helper The Helper:
    btw it was just lag the weirdness is gone
  • Wizard Wizard:
    I checked!
    +1
  • Blackveiled Blackveiled:
    How is everyone doing?
  • Wizard Wizard:
    Alright!
  • The Helper The Helper:
    Doing well thanks!
  • The Helper The Helper:
    Tom Mai check out the post I just found you made in 2006, from an apparent banned account, I do not remember that happening, the post is in the General Discussion Hall of Fame about record breakers
  • Blackveiled Blackveiled:
    Lmao thats somethin right there.
  • tom_mai78101 tom_mai78101:
    How far back were you looking at?
  • tom_mai78101 tom_mai78101:
    But yes, that was me.
  • The Helper The Helper:
    Do you think I am looking back in the forums for this stuff? LOL, no, I find these posts in the Members Online section or the stats - all these old posts I am bumping and moving around are what people are actually looking at on the website
  • tom_mai78101 tom_mai78101:
    Interesting.
  • The Helper The Helper:
    hey Tom your Burrito news is going viral by TheHelper.net standards LOL
  • The Helper The Helper:
    looks like The Burrito has been shared to facebook lol I am getting the facebook bots in now
  • The Helper The Helper:
    I am going to do one more News Forum like the Weird News but this one is Science News for all the cool science and technology articles in the Archive
  • tom_mai78101 tom_mai78101:
    Hmm, do I need to start posting some of the Science and Technology news to this new section in the future?
  • tom_mai78101 tom_mai78101:
    Or do we need to move the news to their respective sections once the threads are old enough, read to be put into the News Archive?
  • The Helper The Helper:
    The 2nd thing
  • The Helper The Helper:
    I have been moving stuff from the current Headline news like a year old and stuff over when I see it in the logs or members online but mostly I have been moving stuff from the Archives
  • The Helper The Helper:
    It is possible to automate it so that instead of moving to Archive if it has the Science, technology or sci tech tag that it gets archived there instead. I am considering a new Weird News Tag
  • tom_mai78101 tom_mai78101:
    Please do. I'll try to tag the news appropriately when I get the chance.
  • The Helper The Helper:
    The new Discourse forum software we are moving to next does alot with the tags and also hashtags
  • The Helper The Helper:
    OK I found the source of your burrito post stuff it is from Reddit and possibly a facebook post too but definitely reddit

    Staff online

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top