System Damage

[Jesus4Lyf]

is there a way to block percent of damage taken? if not, why don't you replace this:

public function BlockAll takes nothing returns nothing
    set ToBlock[TypeStackLevel]=ToBlock[TypeStackLevel]+GetEventDamage()
endfunction

with this:

public function BlockPercent takes real percent returns nothing
    set ToBlock[TypeStackLevel]=ToBlock[TypeStackLevel] + GetEventDamage()*percent
endfunction

percent being any number between 0 and 1

I've changed it like that for my map (hope you don't mind) and it works

You can write a wrapper function.

function Damage_BlockPercent takes real percent returns nothing
    call Damage_Block(GetEventDamage()*percent)
endfunction

Best approach, doesn't touch the library. I believe it will inline, too.

 

[muzk]

    globals
        private integer BlockNum=0
        private unit array BlockUnit
        private real array BlockUnitLife
        private real array BlockRedamage
        private unit array BlockDamageSource
        
        private timer BlockTimer=CreateTimer()
    endglobals

Does nothing!

 

[Jesus4Lyf]

    globals
        private integer BlockNum=0
        private unit array BlockUnit
        private real array BlockUnitLife
        private real array BlockRedamage
        private unit array BlockDamageSource
        
        private timer BlockTimer=CreateTimer()
    endglobals

Does nothing!

... Well spotted!
You insane, brilliant mind. lol

 

[muzk]

    function UnitDamageTargetEx takes unit whichUnit, widget target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
        local boolean result
        set TypeStackLevel=TypeStackLevel+1
        set TypeStackValue[TypeStackLevel]=damageType
        set TypeStackAttack[TypeStackLevel]=attack
        set result=UnitDamageTarget(whichUnit,target,amount,attack,ranged,attackType,damageType,weaponType)
        set TypeStackLevel=TypeStackLevel-1
        return result
    endfunction

I don't understand it. Why arrays and not just non-array globals?

 

[Bribe]

Because of recursion. Although it would be more efficient (and more intuitive) if he did something like this:

function UnitDamageTargetEx takes unit whichUnit, widget target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
    local boolean result
    local damagetype dt = DamageType
    local integer ia = IsAttack
    set IsAttack = attack
    set DamageType = damageType
    set result = UnitDamageTarget(whichUnit, target, amount, attack, ranged, attackType, damageType, weaponType)
    set DamageType = dt
    set IsAttack = ia
    set dt = null
    return result
endfunction

 

[Jesus4Lyf]

Yep, recursion.

Although it would be more efficient (and more intuitive) if he did something like this

What makes you think that is either more efficient or more intuitive..?

This way it would be trivial to refer to damage that damage is in response to, if I liked..

 

[muzk]

I don't get it yet ... I can't see the recursion there D:

 

[Jesus4Lyf]

I don't get it yet ... I can't see the recursion there D:

Think: What happens if a unit returns 50% of damage taken? UnitDamageTargetEx will fire again before it finishes firing...

 

[Bribe]

It is not much more efficient, according to my FPS tests, what is going to matter is repeat-referencing because you are returning a scalar via GetEventDamageType instead of an array lookup, for example. It saves creation of globals and global arrays as well. It's probably easier to code it your way but it's definitely lighter on the processor by hashing it into some locals.

 

[muzk]

Think: What happens if a unit returns 50% of damage taken? UnitDamageTargetEx will fire again before it finishes firing...

Finally... thx!

 

[Jesus4Lyf]

It is not much more efficient, according to my FPS tests, what is going to matter is repeat-referencing because you are returning a scalar via GetEventDamageType instead of an array lookup, for example. It saves creation of globals and global arrays as well. It's probably easier to code it your way but it's definitely lighter on the processor by hashing it into some locals.

FPS tests... lol, back in my day it was benchmarks or don't say anything.

If you care about that sort of efficiency, you should only have one trigger firing off Damage, and then fork through a tree structure to only fire the correct event responses based on what type of damage, if it's an attack, etc. Isn't this is the most efficient way to support that, since GetEventDamageType would only ever be called once each time?

And if you don't care about that sort of efficiency, good on you, you might even complete a map!

 

[Bribe]

RtC benchmarks don't work any more, so now it's pretty much FPS tests or don't say anything.

 

[codart]

Can i use this system with Abuff from Anitarf. Can't make myself use buff struct, it's fail _ _!

 

[kStiyl]

I'm having a strange bug with this system

If I add some kind of ability (ex. slow aura-based debuff) on the damage event, Damage_Block seems to bug (it won't block any damage)

I've tested it on your demo map by just switching your demo code with this library below.

After making an attempt to debug this, I found that adding an ability triggers the event.
I do not understand why this would bug the system though; isn't it supposed to be recursive?

I fixed this bug temporarily by adding GetEventDamage() > 0 on 'onDamageActions' in damage library

library Test initializer onInit requires Damage
        
    private function onHit takes nothing returns boolean
    	call Damage_BlockAll()
        call UnitAddAbility(GetTriggerUnit(), 'Aasl')
        call UnitRemoveAbility(GetTriggerUnit(), 'Aasl')
        call UnitRemoveAbility(GetTriggerUnit(), 'Basl')
        return false
    endfunction
        
    private function onInit takes nothing returns nothing
        local trigger trg = CreateTrigger()
        call Damage_RegisterEvent(trg)
        call TriggerAddCondition(trg, Condition(function onHit))
        set trg = null
    endfunction

endlibrary

Would appreciate it if you give me a solution. I'm having a huge problem because this is continuously interfering with my debuff system =( (poison, stun etc.)

 

[Mr_Bean355]

The example code in the demo map doesn't work for me. Anyone else have this issue?

 

[BlackRose]

The example code in the demo map doesn't work for me. Anyone else have this issue?

It works fine. What part of it 'doesn't work'?

 

[Mr_Bean355]

The test scope. I think it is meant to block all damage in the demo map, but when I test it, nothing happens. Unit receive damage as normal. I re-downloadede the demo map and tested it without changing anything - still didn't help.

 

[BlackRose]

Indeed it is meant to block all damage in the demo map. Strange how nothing happens upon testing. It should work without any editing. Place debug messages in the function to see if the code is actually running.

 

[Mr_Bean355]

scope NoDamageOnMap initializer StartZeroDamage
private function BlockAllDamage takes nothing returns boolean
call BJDebugMsg("Damaged!")
call Damage_BlockAll()
return false
endfunction
 
private function StartZeroDamage takes nothing returns nothing
local trigger t=CreateTrigger()
call TriggerAddCondition(t,Condition(function BlockAllDamage))
call Damage_RegisterEvent(t)
endfunction
endscope

Nothing displays

EDIT: Turns out the issue was the JASSHelper version I have. The latest one (by Cohadar) compiles the map in a strange order, meaning Damage won't work for pre-placed units. After down-grading to an earlier version of JASSHelper, it works fine.

 

[Grundy]

So does this system discard "damagetype"s like DAMAGE_TYPE_ACID, DAMAGE_TYPE_COLD, DAMAGE_TYPE_DEATH, DAMAGE_TYPE_DEFENSIVE, etc... and instead uses only 3 damage types, physical, magical, and pure?