Snippet DamageId

Dirac

22710180
JASS:
library DamageId /* v1.1.0

*/uses/*
*/  Damage  /* thehelper.net/forums/showthread.php/168144-Damage-Struct

A useful tool for damage identification

**********************************************************************/
globals
//*********************************************************************
//  These are the public constants that determine the damage's id.
//  Custom id represents damage done through coding.
    constant key DAMAGE_ID_CUSTOM
    constant key DAMAGE_ID_MELEE
    constant key DAMAGE_ID_RANGED
    constant key DAMAGE_ID_SPELLS
endglobals
/**********************************************************************
*
*   function RegisterDamageById takes code func, integer damageId returns triggercondition
*       -   Registers the function to the damage id.
*   function UnregisterDamageById takes triggercondition whichCondition, integer damageId returns nothing
*       -   Unregisters the function from the damage id.
*
***********************************************************************
*
*   readonly integer id
*       -   Adds this variable to the Damage struct, returns the
*       -   current damage id.
*
**********************************************************************
*
*   HOW TO IMPLEMENT:
*       -   Import this code into an empty trigger in your map,
*       -   requires NewGen installed. Save the map, reopen it, and
*       -   then delete the "!" exclamation mark from the textmacro 
*       -   below.
*/
    //! runtextmacro DAMAGE_ID_SETUP()

/*********************************************************************
    
This needs to be a textmacro in order to keep the encapsulation correct
and private within the Damage library. Consider this textmacro private.

**********************************************************************/

//! textmacro DAMAGE_ID_EX1
    globals
        private trigger array   DamageIdFire
        private boolean         DamageIdHook = false
        private integer         DamageId = 0
    endglobals
    
    function RegisterDamageById takes code func, integer damageId returns triggercondition
        if DamageIdFire[damageId]==null then
            set DamageIdFire[damageId]=CreateTrigger()
        endif
        return TriggerAddCondition(DamageIdFire[damageId],Filter(func))
    endfunction
    
    function UnregisterDamageById takes triggercondition whichCondition, integer damageId returns nothing
        call TriggerRemoveCondition(DamageIdFire[damageId],whichCondition)
    endfunction
    
    private function CustomDamageDetection takes unit whichUnit, widget target, real amount, boolean attack, boolean ranged, attacktype attackType, damagetype damageType, weapontype weaponType returns boolean
        set DamageIdHook=true
        return false
    endfunction
    
    hook UnitDamageTarget CustomDamageDetection
//! endtextmacro

//! textmacro DAMAGE_ID_EX2
    static method operator id takes nothing returns integer
        return DamageId
    endmethod
//! endtextmacro

//! textmacro DAMAGE_ID_EX3
    local integer prevAdvType = DamageId
//! endtextmacro

//! textmacro DAMAGE_ID_EX4
    if not(DamageIdHook) then
        if GetUnitAbilityLevel(target,'ADab')>0 then
            if IsUnitType(source,UNIT_TYPE_RANGED_ATTACKER) then
                set DamageId = DAMAGE_ID_RANGED
            else
                set DamageId = DAMAGE_ID_MELEE
            endif
        else
            set DamageId = DAMAGE_ID_SPELLS
        endif
    else
        set DamageId = DAMAGE_ID_CUSTOM
        set DamageIdHook = false
    endif
    call UnitRemoveAbility(target,'ADab')
    call TriggerEvaluate(DamageIdFire[DamageId])
//! endtextmacro

//! textmacro DAMAGE_ID_EX5
    set DamageId = prevAdvType
//! endtextmacro

//! textmacro DAMAGE_ID_EX6
    call UnitAddAbility(indexUnit,'ADfb')
//! endtextmacro

//! textmacro DAMAGE_ID_SETUP
    //! externalblock extension=lua ObjectMerger $FILENAME$
        //! i setobjecttype("buffs")
        //! i createobject("BHab","ADab")
        //! i makechange(current,"ftat","")
        //! i makechange(current,"fnam","DAMAGE_DETECTION_BUFF")
        
        //! i setobjecttype("abilities")
        //! i createobject("AIob","ADfb")
        //! i makechange(current,"amat","")
        //! i makechange(current,"asat","")
        //! i makechange(current,"atat","")
        //! i makechange(current,"Idam",1,"0")
        //! i makechange(current,"Iob5",1,"0")
        //! i makechange(current,"abuf",1,"ADab")
        //! i makechange(current,"anam","DAMAGE_DETECTION_ABILITY")
    //! endexternalblock
//! endtextmacro
endlibrary
 

Laiev

Hey Listen!!
[ljass]'ACvp'[/ljass] should be configuration too

If someone change buff of vampiric aura, then probably he change the aura itself
 

Dirac

22710180
It wouldn't matter, the aura is hard coded to only apply the buff to melee units and this can't be modified.
 

Laiev

Hey Listen!!
JASS:
//! textmacro DAMAGE_ID_EX4
    if not(DamageIdHook) then
        if GetUnitAbilityLevel(target,'ADab')>0 then
            if not(IsUnitRanged(source)) then
                set DamageId = 2
            else
                set DamageId = 3
            endif
            call UnitRemoveAbility(target,'ADab')
        else
            set DamageId = 4
        endif
    else
        set DamageId = 1
        set DamageIdHook = false
    endif
    call TriggerEvaluate(DamageIdFire[DamageId])
//! endtextmacro


>>

JASS:
//! textmacro DAMAGE_ID_EX4
    if not(DamageIdHook) then
        if UnitRemoveAbility(target,'ADab') then
            if not(IsUnitRanged(source)) then
                set DamageId = DAMAGE_ID_MELEE
            else
                set DamageId = DAMAGE_ID_RANGED
            endif
        else
            set DamageId = DAMAGE_ID_SPELLS
        endif
    else
        set DamageId = DAMAGE_ID_CUSTOM
        set DamageIdHook = false
    endif
    call TriggerEvaluate(DamageIdFire[DamageId])
//! endtextmacro
 
And does this work with missile attacks? Artillery attacks? Explosion? Some buffs are added after the damage event runs, hence why Advanced Damage Event is so darn complicated.


Also, you do realize that some units may have both a ranged and a melee attack right? : )
 

Dirac

22710180
I'm not going to pretend that your damage library wasn't an inspiration to go ahead and do this.
Yes i'm aware of some of those issues, but don't hate the player, hate the game.
And because this doesn't work all the times it's optional and the user should test it to see if it works for it's needs. Otherwise there's not much that can be done.
I though this was cool because you can register specific damage id events (such as only register spell damage, or ranged damage for this function) and has a way to detect if the unit has ranged capacities, other methods to detect if the damage done was actually melee if the unit would implicate using some sort of buff permanently attached to the target such as frost armor or thorns aura, i think vampiric aura was a good approach.
 

PurgeandFire

zxcvmkgdfg
Make sure you readd the exclamation point for the [ljass]//! runtextmacro[/ljass]. (it is missing right now) By default it should be there. :)

Also, for IsUnitRanged, isn't there already [ljass]IsUnitType( u, UNIT_TYPE_RANGED_ATTACKER )[/ljass]? Although, I haven't tested it thoroughly so I can't guarantee it works.

Otherwise nice.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday
  • tom_mai78101 tom_mai78101:
    I found out you can't delete nor hide redirect links to existing threads. It will just stay there. I have no choice now but to start moving thread redirects to News Archive.
  • The Helper The Helper:
    That is not the way that it works for me I can delete redirects you just have to hit refresh sometimes big deletes will take a while as long as moves\
  • The Helper The Helper:
    You don't have to do that you can just leave stuff there in headline news for up to a year it was already down to like 8 months there is no rush.

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top