Does this leaks

[Dirac]

Im a begineer on JASS and leak removing... so

• Frostfire Bolt
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Frostfire bolt
  • Actions
    • Set FFBtarget = (Target point of ability being cast)
    • Set FrostfireMage = (Casting unit)
    • Set FFBpointinit = (Position of FrostfireMage)
    • Unit - Create 1 FFB Progectile for (Owner of FrostfireMage) at FFBpointinit facing Default building facing degrees
    • Set FFBdummys[1] = (Last created unit)
    • Unit - Create 1 FFB Progectile (FIRE) for (Owner of FrostfireMage) at FFBpointinit facing Default building facing degrees
    • Set FFBdummys[2] = (Last created unit)
    • Trigger - Turn on Frostfire Bolt Slide <gen>

• Frostfire Bolt Slide
  • Events
    • Time - Every 0.01 seconds of game time
  • Conditions
  • Actions
    • Set FFBslide = (FFBslide + 15.00)
    • For each (Integer A) from 1 to 2, do (Actions)
      • Loop - Actions
        • Unit - Move FFBdummys[(Integer A)] instantly to (FFBpointinit offset by FFBslide towards (Angle from FFBpointinit to FFBtarget) degrees)
        • Set TempGroup = (Units within 150.00 of (Position of FFBdummys[(Integer A)]))
        • Unit Group - Pick every unit in TempGroup and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) belongs to an enemy of (Owner of FrostfireMage)) Equal to True
                • ((Picked unit) is A structure) Equal to False
                • ((Picked unit) has buff Frostfire Effect ) Equal to False
              • Then - Actions
                • Set TempPoint = (Position of (Picked unit))
                • Unit - Create 1 Dummy for (Owner of FrostfireMage) at TempPoint facing Default building facing degrees
                • Custom script: call RemoveLocation (udg_TempPoint)
                • Unit - Add Frostfired to (Last created unit)
                • Unit - Set level of Frostfired for (Last created unit) to (Level of Frostfire bolt for ShadowbloodMage)
                • Unit - Order (Last created unit) to Neutral Alchemist - Acid Bomb (Picked unit)
                • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
                • Unit - Cause FrostfireMage to damage (Picked unit), dealing ((75.00 x (Real((Level of Frostfire bolt for FrostfireMage)))) + ((Real((Intelligence of FrostfireMage (Include bonuses)))) x (0.15 x (Real((Level of Frostfire bolt for FrostfireMage)))))) damage of attack type Spells and damage type Normal
              • Else - Actions
        • Custom script: call DestroyGroup (udg_TempGroup)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • FFBslide Greater than or equal to (300.00 + (200.00 x (Real((Level of Frostfire bolt for FrostfireMage)))))
      • Then - Actions
        • Set FFBslide = 0.00
        • Set FFBpointinit = (Position of FrostfireMage)
        • Custom script: call RemoveLocation (udg_FFBpointinit)
        • Trigger - Turn off (This trigger)
      • Else - Actions

 

[lindenkron]

Use WC3 not W3C

[del]Edit; do me a bigger favour, put it in /code as well if possible ^^[/del]
Doesn't look like it leaks to me.
But from what i've heard, using 0.01 sec aint smart.. go to 0.03 / 0.05 if possible.

 

[TideOfChaos]

The only leak I can see is the leaks you get from creating units, which is very small. I can't remember the Custom Script of the top of my head though.

 

[Dinowc]

I'm not on my pc, but after having a quick look, I have found 1 leaky point
(the bolded one):

                Set TempGroup = (Units within 150.00 of ([B]Position of FFBdummys[/B][(Integer A)]))

and by the way, to ensure leaklessility (is there a such word lol?) remove the points in the first trigger, and then set them again in the second and after you done all the actions using them, destroy them and so on...

I'm not on my pc now, but I'll show you what I mean after I get home...

 

[vypur85]

Set FFBtarget = (Target point of ability being cast) <-- [I]Not removed[/I]
# Unit - Move FFBdummys[(Integer A)] instantly to [B](FFBpointinit offset by FFBslide towards (Angle from FFBpointinit to FFBtarget) degrees)[/B]
# Set TempGroup = (Units within 150.00 of [B](Position of FFBdummys[(Integer A)]))[/B]

Bolded stuffs are leaks.