System DoubleClick

[Azlier]

Small update. Doesn't use the trigger attachment anymore, thanks to an idea from Vex.

 

[Jesus4Lyf]

I read the WC3Campaigns post in regards to what it was.

So tell me, have you handled situations in which the timers are paused?

Because that would mess up the queue order.

 

[Azlier]

I did test it, and ran into no problems. Perhaps I should ask at WC3C.

 

[Jesus4Lyf]

The errors would likely only come up as soon as there is more than one player in the game. I imagine it would possibly extend the double click time to infinite for each player whenever another player double clicks. Or something. But I haven't read the code closely yet. Just wanted to note this possibility...

Edit: I'd like to increase my suspicions.

call PauseTimer(ClickTimer[Id])

I note that no effort is made to remove anything from the queue. Your queue works like this (in case you weren't aware):

Timer: . . .Data: . . . . . . . . .Expires:
TimerA . . Player Number 1 . .Second 1.5
TimerB . . Player Number 2 . .Second 1.6

Then you stop TimerA let's say, using that pause. That means (unless I missed something in my skim):

Timer: . . .Data: . . . . . . . . .Expires:
TimerB . . .Player Number 1 . .Second 1.5
. . . . . . . .Player Number 2 . .Second 1.6

Major problems. But you clearly need two timers, meaning two players, for this instability to show up.

Careful, Azlier!
To avoid attachment in this case, with still O(1) complexity, you need a linked list of instances to fire, and if a timer is paused you also need to remove its current node from the linked list.
This means a doubly linked list. I don't know if you're up to writing this yourself or not. Give it a shot if you like.

Edit: Try this. I haven't syntax checked it or anything else though, be warned...

library YourLib // Just copy the contents in and use the functions mentioned at the bottom.
    private struct QueueNode
        QueueNode next
        QueueNode prev
        integer playerNumber
        method attachEnd takes integer playerNumber returns QueueNode
            local QueueNode new=QueueNode.allocate()
            set new.next=0
            set new.prev=this
            set this.next=new
            return new
        endmethod
        private method onDestroy takes nothing returns nothing
            set this.next.prev=this.prev
            set this.prev.next=this.next
            set this.playerNumber=0
        endmethod
    endstruct
    
    globals
        private QueueNode First=0
        private QueueNode Last=0
        private QueueNode array PlayersNode
    endglobals
    
    private function AddToQueue takes integer playerNumber returns nothing
        set Last=Last.attachEnd()
        if First==0 then
            set First=Last
        endif
        set Last.playerNumber=playerNumber
        set PlayersNode[playerNumber]=Last
    endfunction
    
    private function RemoveNode takes QueueNode n returns nothing
        if First==n then
            set First=First.next
        endif
        if Last==n then
            set Last=Last.prev
        endif
        call n.destroy()
    endfunction
    private function RemoveFromQueue takes integer playerNumber returns nothing
        if PlayersNode[playerNumber].playerNumber!=playerNumber then
            return // Fail
        endif
        call RemoveNode(PlayersNode[playerNumber])
    endfunction
    private function Dequeue takes nothing returns integer
        local integer playerNumber=First.playerNumber
        call RemoveNode(First)
        return playerNumber
    endfunction
    
    // Use AddToQueue(playerNumber) when starting a timer.
    // Use RemoveFromQueue(playerNumber) when stopping (pausing) a timer.
    // Use Dequeue() to get the player number for the expiring timer.
endlibrary

Try to understand it before using it.

 

[Azlier]

I'm fairly sure that going back to triggers are faster than that linked list solution, with the extra function calls and all.

 

[Jesus4Lyf]

Yeah, probably.

 

[Darthfett]

You may want to add the library requirement of Event for the system, so people won't get errors/will get the correct errors when they import the system with/without Event.

library DoubleClick initializer Init requires Event

 

[Azlier]

I never did that? Huh. Done.