Exclude dropped item from counting function

LurkerAspect

Now officially a Super Lurker
XXXX==--SOLVED--==XXXX

Hi again all :D I'm becoming a main source of rep for some of you :D

Anyway, my problem today is that I'm running a function every time a unit drops an item, however the function that follows it almost immediately is still counting the item the unit just dropped, which is messing with my other systems. Any tips on how to fix this?
Here's the code:
JASS:
private function ElementalTally takes unit u returns integer //this is the function that gets run immediately from the actions; this is the function that is counting the dropped item
    local integer i = 1
    local boolean has_air = false
    local boolean has_dark = false
    local boolean has_earth = false
    local boolean has_fire = false
    local boolean has_light = false
    local boolean has_water = false
    local integer tally = 0
    loop
        exitwhen i > 6 
        if GetItemTypeId(UnitItemInSlot(u,i)) == AIR_ITEM and has_air == false then
            set has_air = true
            set tally = tally+32
        elseif GetItemTypeId(UnitItemInSlot(u,i)) == DARK_ITEM and has_dark == false then
            set has_dark = true
            set tally = tally+16
        elseif GetItemTypeId(UnitItemInSlot(u,i)) == EARTH_ITEM and has_earth == false then
            set has_earth = true
            set tally = tally+8
        elseif GetItemTypeId(UnitItemInSlot(u,i)) == FIRE_ITEM and has_fire == false then
            set has_fire = true
            set tally = tally+4
        elseif GetItemTypeId(UnitItemInSlot(u,i)) == LIGHT_ITEM and has_light == false then
            set has_light = true
            set tally = tally+2
        elseif GetItemTypeId(UnitItemInSlot(u,i)) == WATER_ITEM and has_water == false then
            set has_water = true
            set tally = tally+1
        endif
        set i = i+1
    endloop
    return tally
endfunction

//bla bla bla

private function Actions2 takes nothing returns nothing
    local unit u = GetTriggerUnit()
    call RemoveElementalPowers(u)
    call UnitAddAbility(u,ELEMENTAL_ABILITY[ElementalTally(u)])
    set u = null
endfunction

private function Conditions1 takes nothing returns boolean
    return GetUnitTypeId(GetTriggerUnit()) == 'h000' and not UnitHasItemAlready(GetTriggerUnit(),GetManipulatedItem()) and IsItemElemental(GetManipulatedItem())
endfunction

Don't worry about the other undefined functions and global variables, they don't affect the performance of the main tally function.

Any help is much appreciated :D
 

Tyrulan

Ultra Cool Member
It sounds like when an item is dropped it is still considered as 'Manipulated' and in the inventory. I would add a parameter to your tally function and do a not equals comparison to exclude it.

Let me know if this helps you with your problem. If not, I'll investigate further.

EDIT: Apologies, did not read the SOLVED tag at the front of the post. Could you post the solution please? Intellectual curiosity.
 

LurkerAspect

Now officially a Super Lurker
I modified the functions; ElementalTally now takes an item as well as a unit argument, and then checks if the current item in slot is the given item, and if it is, it's not counted. That way, I just input the GetManipulatedItem(), and it works perfectly :). It was fairly simple actually. Basically, the function looks like this now:
JASS:
function GetElementalTally takes unit u, item exception returns integer
    //exception is the item you DON'T want added to tally
    //use with 'Drop' functions so that the dropped element doesn't get counted
    local integer i = 0
    local boolean has_air = false
    local boolean has_dark = false
    local boolean has_earth = false
    local boolean has_fire = false
    local boolean has_light = false
    local boolean has_water = false
    local integer tally = 0
    set tally = 0
    loop
        exitwhen i > 6 
        if UnitItemInSlot(u,i) != exception then
            if GetItemTypeId(UnitItemInSlot(u,i)) == AIR_ITEM and has_air == false then
                set has_air = true
                set tally = tally+32
            elseif GetItemTypeId(UnitItemInSlot(u,i)) == DARK_ITEM and has_dark == false then
                set has_dark = true
                set tally = tally+16
            elseif GetItemTypeId(UnitItemInSlot(u,i)) == EARTH_ITEM and has_earth == false then
                set has_earth = true
                set tally = tally+8
            elseif GetItemTypeId(UnitItemInSlot(u,i)) == FIRE_ITEM and has_fire == false then
                set has_fire = true
                set tally = tally+4
            elseif GetItemTypeId(UnitItemInSlot(u,i)) == LIGHT_ITEM and has_light == false then
                set has_light = true
                set tally = tally+2
            elseif GetItemTypeId(UnitItemInSlot(u,i)) == WATER_ITEM and has_water == false then
                set has_water = true
                set tally = tally+1
            endif
        endif
        set i = i+1
    endloop
    //call BJDebugMsg("tally = "+I2S(tally))
    return tally
endfunction
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • C Cherry.Grove:
    My boyfriend is super into Bethesda modding so I'm probably going to join him in that for a bit, then move on to making mobile/browser games.
  • C Cherry.Grove:
    I mostly just want to look at my old projects because I know I posted uploads on here somewhere.
  • C Cherry.Grove:
    My one game was basically Among Us but you sabotaged an entire medieval city simulated drastically inefficiently with dynamic NPCs :S
  • C Cherry.Grove:
    of course I never finished it x D
  • jonas jonas:
    xD
  • jonas jonas:
    I think you can still run the original game, just there's a chance your map won't work with the newer patches
  • jonas jonas:
    what development framework have you been looking at for mobile development?
  • jonas jonas:
    I'm currently creating (as a hobby) a space invaders like game for mobile using Xamarin, after starting a few larger projects that I also may not have finished :rolleyes::p
  • The Helper The Helper:
    Awesome! you should look at the Atari VCS platform it does not have a huge user base but the one it has is super active at around 11k and they have no games in there store
  • The Helper The Helper:
    basically it is linux
  • The Helper The Helper:
    OMG it is BanLord as Blackveiled on the forum
  • The Helper The Helper:
    what is up buddy
  • jonas jonas:
    thanks for the tip, that sounds cool. Never heard about the VCS before but seems like it should be a good match
  • tom_mai78101 tom_mai78101:
    The winter vacation left a toll on me. I missed staying up late and sleeping in late.
  • C Cherry.Grove:
    i haven't looked into it yet
  • C Cherry.Grove:
    If I could use something Python compatible it would save me some learning
  • C Cherry.Grove:
    But Unity might be easiest
  • C Cherry.Grove:
    looking at old posts here makes me happy. Makes me be all like "wow I was pretty smart in 2009"
  • C Cherry.Grove:
    mostly failing at life through adulthood really demotivated me for a while
  • C Cherry.Grove:
    ....what I don't get is why the fuck they would force us to permanently convert to a version of the game everyone fucking hated : \
  • C Cherry.Grove:
    Raid Shadow Legends texture pack smh
  • jonas jonas:
    Most people fail at life throughout their adulthood. Sometimes we get to learn from it. Usually it just feels like crap.
    +1
  • The Helper The Helper:
    What does not kill you makes you stronger is what they say
  • C Cherry.Grove:
    for real! :cool:

    Members online

    Affiliates

    Hive Workshop NUON Dome
    Top