Faster/Efficient Code

XeRo13g

New Member
I'm not sure why this is confusing.
The main trigger is just a periodic event, set to 1 second.
...And yes, one can say that it catches events in an indirect way but only those that don't need any accuracy.

For example, I wish that when a hero enters a specific rect for the first time, to update the multiboard:
There is a trigger that catches the first time event-unit enters rect and sets a boolean to true.
The main trigger contains this code:
JASS:
if boolean==true then
set boolean=false
call multiboard_update()
endif


The only difference with the first way is that I would use call TriggerExecute instead of call function and consequently I would need to have the 'multiboard update' as a separate trigger than a function over the main trigger.


Don't do this.

This is a million times slower than having individual triggers.

Regular triggers are way faster than this, just trust me on that.

There are other disadvantages of this method like the slow firing rate (which in itself can cause many more problems).

In short: Stick with regular triggers.
How come it's slower, can you please elaborate?

PS. I don't mind if those functions delay a bit since as I've already said, no accuracy is required of those but if by "slow", you mean heavy, then I might need to revert to the first way and break those functions back to separate triggers.
 

Dirac

22710180
What sevion ment it's not related to code speed at all, what he meant is that there would always be a lapse of time between the timer and the actual moment when the event takes place.
Best thing to do, update your multiboard once the event fires, don't use a periodic timer for it.
In my map i update the multiboard every time a unit dies, takes damage or enters the game. Each event updates the corresponding multiboard values
 

XeRo13g

New Member
What sevion ment it's not related to code speed at all, what he meant is that there would always be a lapse of time between the timer and the actual moment when the event takes place.
Best thing to do, update your multiboard once the event fires, don't use a periodic timer for it.
In my map i update the multiboard every time a unit dies, takes damage or enters the game. Each event updates the corresponding multiboard values
To update the multiboard directly from the event (unit enters rect), requires a separate trigger, it's the way I used to have it. Also, this is not a one-time update, each time a hero will enter a new rect, the multiboard will be updated using the same boolean, so this is not a useless boolean that checks every 1 second for the whole game, just for firing once.

PS. By 'multiboard update', I don't mean changing a 1-2 values on the board. It sets up the multiboard using several different values and icons.
 

chobibo

Level 1 Crypt Lord
You can use a single trigger for that; use conditional statements to check for a specific rect, then execute the actions associated with that rect.
 

Sevion

The DIY Ninja
Considering the possible size of such a script, it's totally possible that it could be slow speed-wise.

The script has to check every single if/then statement before firing anything.
 

chobibo

Level 1 Crypt Lord
I mistook the rect enter event for the spell event, I forgot that rects have dedicated events, my bad, sorry.
 

XeRo13g

New Member
The script has to check every single if/then statement before firing anything.
So, in this case:

JASS:
if condition1==true then
   if condition2==true then
   endif
endif


The script would check the condition2 before firing anything, even if condition 1 is false?
 

Laiev

Hey Listen!!
Also this:

JASS:

if false /*the if stop here and will ignore the other conditions*/ and true and true and true and true and true and true and true then
endif
 

Sevion

The DIY Ninja
So, in this case:

JASS:
if condition1==true then
   if condition2==true then
   endif
endif


The script would check the condition2 before firing anything, even if condition 1 is false?
No. It'll check every single first level condition, though, up to the point Laeiv pointed out. If it hits one false statement in an if argument, it'll stop checking that one.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Jesus4Lyf Jesus4Lyf:
    Hmm, how to summarize... Moved to the USA and got married. Became a professional software engineer and solution lead. Learning Godot for game dev. :)
  • jonas jonas:
    So you are pursuing game dev as a hobby? What industry is your dayjob in?
  • jonas jonas:
    FAANG?
  • Jesus4Lyf Jesus4Lyf:
    Not quite FAANG, less pay for a less hours/stress. Yeah, game dev as a hobby.
  • jonas jonas:
    makes sense. Do we have a hobby game dev subforum to showcase some work?
  • Blackveiled Blackveiled:
    Happy Thursday
    +1
  • The Helper The Helper:
    Happy Thursday!
  • The Helper The Helper:
    TGIF!
  • The Helper The Helper:
    hey tom_mai please do not archive anymore news
  • Ghan Ghan:
    AMD Ryzen 7000 next week :D
    +1
  • The Helper The Helper:
    noice!
  • tom_mai78101 tom_mai78101:
    "hey tom_mai please do not archive anymore news" ----> Got it. What should we do with the "News Archive" subforum?
  • The Helper The Helper:
    I think leave it for real old news that cannot be sorted the reason we had it in the first place was a server issue that we do not have anymore. I don't want to get rid of the archive just not put anything in it for now until we figure it out more
  • The Helper The Helper:
    The side chat has nothing on the discord. it is not possible but the biggest thing on my wish list right now is a sidechat channel on the disord that hooks up to this...
  • Ghan Ghan:
    I've been selected for the Diablo IV beta.
    +1
  • Ghan Ghan:
    Woo!
    +1
  • The Helper The Helper:
    that is so cool
  • V-SNES V-SNES:
    Eh just noticed the new discord section on the side. Looks great!
    +1
  • Blackveiled Blackveiled:
    :( feels bad I can't ever get selected for any beta I sign up for. It's annoying as heck.
    +1
  • The Helper The Helper:
    Hello mgarcia! Happy Monday everyone!
  • The Helper The Helper:
    Happy Tuesday! :)

    The Helper Discord

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top