For Loop integer skipping

WildTurkey

Previously known as giv_me_rep
So I am running this omnislash inspired trigger with a simple loop a from 1-10.

Sometimes it hits every number from 1-10 but most of the time it skips from 4-8 and stuff and I dont understand why or how to fix?

code below

Code:
Test Spell
    Events
        Unit - A unit Starts the effect of an ability
    Conditions
        (Ability being cast) Equal to 360 No Scope
    Actions
        Set Temp_Unit = (Triggering unit)
        Set Temp_Point = (Position of Temp_Unit)
        Set Temp_UG[1] = (Units within 500.00 of Temp_Point matching ((Owner of (Matching unit)) Equal to Player 12 (Brown)))
        Set Temp_UG[2] = (Random 1 units from Temp_UG[1])
        Custom script:   call RemoveLocation (udg_Temp_Point)
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Number of units in Temp_UG[2]) Equal to 1
            Then - Actions
                Unit - Make Temp_Unit Invulnerable
                Special Effect - Create a special effect attached to the chest of Temp_Unit using Abilities\Spells\NightElf\Blink\BlinkTarget.mdl
                Special Effect - Destroy (Last created special effect)
                For each (Integer A) from 1 to 10, do (Actions)
                    Loop - Actions
                        Wait 0.50 seconds
                        Unit Group - Pick every unit in Temp_UG[2] and do (Actions)
                            Loop - Actions
                                Game - Display to (All players) the text: (String((Integer A)))
                                Set Temp_TargetUnit = (Picked unit)
                                Set Temp_Point = (Position of Temp_TargetUnit)
                                Unit - Move Temp_Unit instantly to Temp_Point, facing Temp_Point
                                Custom script:   call RemoveLocation (udg_Temp_Point)
                                Animation - Play Temp_Unit's Attack Slam animation
                                Unit - Cause Temp_Unit to damage Temp_TargetUnit, dealing (50.00 x (Real((Level of 360 No Scope  for Temp_Unit)))) damage of attack type Hero and damage type Normal
                                Special Effect - Create a special effect attached to the chest of Temp_Unit using Abilities\Spells\NightElf\Blink\BlinkTarget.mdl
                                Special Effect - Destroy (Last created special effect)
                        Custom script:   call DestroyGroup(udg_Temp_UG[1])
                Game - Display to (All players) the text: finished
                Custom script:   call DestroyGroup(udg_Temp_UG[2])
                Unit - Make Temp_Unit Vulnerable
            Else - Actions
 

Accname

2D-Graphics enthusiast
You have a wait within your loop. Never use waits.

The problem is that there is probably some other kind of trigger somewhere in your map. And that other trigger ALSO uses the for-each(A) loop.
Because of the wait you give the other trigger the chance to run as well, simultaneously, messing up the results of both triggers because the IntegerA value is changed by both triggers.

When you want to work with the Wc3 editor you have to learn the golden rule:
Wait == Bad
 

WildTurkey

Previously known as giv_me_rep
Perfect, I just made a decent jump and knockback system so I guess Ill run something similar for this.
 

Accname

2D-Graphics enthusiast
Still wont work if he is able to cast the ability with 2 units or with the same unit before the original effect is over.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    I have a GIF though
  • tom_mai78101 tom_mai78101:
    In the GIF, I've configured it so the lower the "Main Value" is, the better. I had to compress it pretty far down though.
  • tom_mai78101 tom_mai78101:
    And this is the thread with the video that shows the wall clip. https://tasvideos.org/Forum/Topics/23453
    +2
  • tom_mai78101 tom_mai78101:
    Hmm, about the Headline News, I noticed threads are being moved into the subforum (Health News, Environmental News, etc.). When that happens, the TH Forum Home page loses the articles, and instead would show old articles posted 1 or 2 weeks ago.
  • tom_mai78101 tom_mai78101:
    What do we do with the Home page?
  • Ghan Ghan:
    I added those forums to the filter for that widget.
    +1
  • tom_mai78101 tom_mai78101:
    Oh nice. They're back. Thanks.
  • tom_mai78101 tom_mai78101:
    Now I think it makes more sense for me to put news in their own subforums, without worry.
  • The Helper The Helper:
    Awesome Ghan thanks! I was purposely not moving the first 15 news articles in Headline news to the different subforums but I guess I don't have to do that now?
  • tom_mai78101 tom_mai78101:
    Question: Is there a way to remove thread redirects? It creates a copy of the moved thread and takes up space, and I am leaning towards wanting to remove them in the Headline News. But if they have an expiration date, I guess I'm fine with it.
  • The Helper The Helper:
    If you move a thread please leave a permanent redirect. You can delete any redirects after 6 months. The redirects are left to help Search Engines find the moved content.
  • tom_mai78101 tom_mai78101:
    What if you move the permanent redirect, not the thread?
  • The Helper The Helper:
    I think that works but I have not messed with it. You can delete redirects though if you have to that will not delete the original thread
  • The Helper The Helper:
    if a redirect ends up in the same forum as the post it goes to though I think the redirect drops or fails or something but they are not bugged out and when you are working on an indirect the original post is safe.
  • The Helper The Helper:
    Happy Early Friday :)
    +1
  • V-SNES V-SNES:
    Happy Friday :)
  • tom_mai78101 tom_mai78101:
    Fun Friday for me
  • tom_mai78101 tom_mai78101:
    Happy Fun Friday to all.
    +2
  • The Helper The Helper:
    Happy Sunday everyone!!!
  • V-SNES V-SNES:
    Happy Sunday!!!
    +1
  • jonas jonas:
    Happy monday :p
  • jonas jonas:
    Everyone hates mondays?
    +1
  • The Helper The Helper:
    Happy Tuesday!
  • jonas jonas:
    Happy belated tuesday

    Staff online

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top