FPS Problems with Spells

kelogsloops

You can change this now in User CP.
Reaction score
45
So I have a spell that goes like this

Fires a powerful arrow enchanted with wind. The arrow deals 80 damage to all enemy units that it pierces. If the enemy's back is exposed to the arrow's trajectory, deals an extra 60 damage as well as reduces armor by 4 and giving temporary vision.

That's the jist of it. The spell is based of Shockwave to deal damage whilst the backstab and Faerie Fire effect is added via trigger. I just got hte spell working i think, but I seem to encounter a few problems. Firstly, sometimes I'm not even sure whether the Shockwave spell deals damage. I nulled the effect of the 'backstab' damage and it seems like it does nothing. Any ideas? Secondly. whenever I CAST the spell, the FPS goes down CRAZY, like 65 to 55, 55 to 45 etc. It gets incredibly low and I've checked over and over but I can't see any problems. Please help!

Here are my triggers.
Trigger:
  • Piercing Shot
    • Events
      • Unit - A unit Starts the effect of an ability
    • Conditions
      • (Ability being cast) Equal to Piercing Shot
    • Actions
      • Set Caster = (Casting unit)
      • Set Target_Loc = (Target point of ability being cast)
      • Set Temp_Point = (Position of Caster)
      • Unit - Create 1 Windy Arrow for (Owner of Caster) at (Position of (Casting unit)) facing (Angle from (Position of Caster) to Target_Loc) degrees
      • Unit Group - Add (Last created unit) to UnitGroup
      • Hashtable - Save (1400.00 / 1550.00) as 2 of (Key (Last created unit)) in hashtable
      • Hashtable - Save (Angle from (Position of Caster) to (Target point of ability being cast)) as 1 of (Key (Last created unit)) in hashtable
      • Hashtable - Save Handle Of(Last created unit) as 3 of (Key (Last created unit)) in hashtable
      • Custom script: call RemoveLocation(udg_Temp_Point)
      • Custom script: call RemoveLocation(udg_Target_Loc)



Trigger:
  • Piercing Shot Move
    • Events
      • Time - Every 0.02 seconds of game time
    • Conditions
    • Actions
      • Unit Group - Pick every unit in (Units of type Windy Arrow) and do (Actions)
        • Loop - Actions
          • Set Unit = (Load 3 of (Key (Picked unit)) in hashtable)
          • Set Angle = (Load 1 of (Key (Picked unit)) from hashtable)
          • Set RemainingTime = (Load 2 of (Key (Picked unit)) from hashtable)
          • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            • If - Conditions
              • RemainingTime Greater than 0.00
            • Then - Actions
              • Unit - Move (Picked unit) instantly to ((Position of (Picked unit)) offset by 36.00 towards Angle degrees)
              • Hashtable - Save (RemainingTime - 0.02) as 2 of (Key (Picked unit)) in hashtable
              • Destructible - Pick every destructible within 150.00 of (Position of (Picked unit)) and do (Actions)
                • Loop - Actions
                  • Destructible - Kill (Picked destructible)
              • Unit Group - Pick every unit in (Units within 150.00 of (Position of Unit)) and do (Actions)
                • Loop - Actions
                  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    • If - Conditions
                      • ((Picked unit) has buff Pierced ) Equal to False
                      • ((Picked unit) belongs to an enemy of (Owner of Unit)) Equal to True
                      • Or - Any (Conditions) are true
                        • Conditions
                          • And - All (Conditions) are true
                            • Conditions
                              • (Facing of (Picked unit)) Less than or equal to (Angle + 90.00)
                              • (Facing of (Picked unit)) Greater than or equal to (Angle - 90.00)
                    • Then - Actions
                      • Unit - Create 1 Wisp for (Owner of Unit) at (Position of (Picked unit)) facing Default building facing degrees
                      • Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
                      • Unit - Cause Unit to damage (Picked unit), dealing 60.00 damage of attack type Chaos and damage type Divine
                      • Special Effect - Create a special effect attached to the chest of (Picked unit) using Objects\Spawnmodels\Human\HumanBlood\BloodElfSpellThiefBlood.mdl
                      • Special Effect - Destroy (Last created special effect)
                      • Unit - Add Piercing Shot to (Last created unit)
                      • Unit - Order (Last created unit) to Night Elf Druid Of The Talon - Faerie Fire (Picked unit)
                    • Else - Actions
                      • Do nothing
            • Else - Actions
              • Unit Group - Remove (Picked unit) from (Last created unit group)
              • Unit - Kill (Picked unit)
              • Hashtable - Clear all child hashtables of child (Key (Picked unit)) in (Last created hashtable)



IT WOULD BE REALLY APPRECIATED!
 

Wratox1

Member
Reaction score
22
first of all, use the wc3-tags around your code, it will make the code so much easier to read and understand;)
 

Moradiae

TH.net Regular
Reaction score
14
I don't really see anything wrong with the main actions, I think the problem's with your hashtable

but first, I see you didn't use the unit group "UnitGroup" at all, so you can just simply cut that line out

now

Exactly how did you achieve

Trigger:
  • Hashtable - Save (real) as 2 of (Key (Last created unit)) in hashtable

and

Trigger:
  • Set Unit = (Load 3 of (Key (Picked unit)) in hashtable)

?

as far as I can tell, the (key (Last created unit)) and (key(picked unit)) are simply string id, so that could be a reason why it's not working. Unless there's something I am missing here..



Because the 2 hashtable indexes use integer, you need to set unit's handle Id to a variable first, then use that as the hashtable index:

Trigger:
  • Actions
    • Set Temp_Unit = (Last created unit)
    • Custom Script: set udg_Temp_Handle (integer) = GetHandleId(Temp_Unit)
    • Hashtable - Save (140/155) as 2 of (Temp_Handle) in hashtable
    • Hashtable - Save (angle(...)) as 1 of (Temp_Handle) in hashtable
    • -
    • -
    • ------- and you don't need this line:-------
    • Hashtable - Save Handle of (Last Created unit) as 3 of (Key (Last created unit)) in hashtable
    • -------you get your windy arrow in the periodic trigger by (picked unit) anywayy--------




so then when you pick the Windy arrow, you do:
Trigger:
  • Actions
    • Set Temp_Unit = (Picked unit)
    • Custom Script: set udg_Temp_Handle = GetHandleId(Temp_Unit)
    • Set Angle = (Load 1 of (Temp_Handle) in hashtable
    • Set Remainingtime = (Load 2 of (Temp_Handle) in hashtable
    • -
    • -
    • -----and delete the line:------
    • Set Unit = (Load 3 of (Key (Picked unit)) in hashtable)
    • ------ it's the same as (picked unit)------


now within the periodic trigger, update the remaining time by saving like above:
Trigger:
  • Actions
    • Hashtable - Save (RemainingTime - 0.02) as 2 of (Temp_Handle) in hashtable
    • -
    • -
    • --and when you clean, again, use the Temp_Handle---
    • Hashtable - Clear all child hashtables of child (Temp_Handle) in hashtable
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
  • The Helper The Helper:
    Happy Wednesday!
    +1

      The Helper Discord

      Members online

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top