Game crashes with gold split trigger

N

Nathano

Guest
I have a map that uses about 150 triggers. All went fine, until i added those triggers:

HTML: 
Gold Split Light
    Events
        Player - Player 1 (Red)'s Current gold becomes Greater than 100.00
    Conditions
    Actions
        Player Group - Pick every player in (All allies of Player 1 (Red)) and do (Player - Add 10 to (Picked player) Current gold)
        Player - Set Player 1 (Red) Current gold to ((Player 1 (Red) Current gold) - 100)


Gold Split Dark
    Events
        Player - Player 7 (Green)'s Current gold becomes Greater than 100.00
    Conditions
    Actions
        Player Group - Pick every player in (All allies of Player 7 (Green)) and do (Player - Add 10 to (Picked player) Current gold)
        Player - Set Player 7 (Green) Current gold to ((Player 7 (Green) Current gold) - 100)
Now each time the gold of player 1 or player 7 goes over 100, the game simply crashes without an error message. Idea anyone?
 
Code: 
Untitled Trigger 001
    Events
        Player - Player 1 (Red)'s Current gold becomes Greater than or equal to 100.00
    Conditions
    Actions
        Player Group - Pick every player in (All allies of Player 1 (Red)) and do (Actions)
            Loop - Actions
                Player - Add (100 mod (Team number of Player 1 (Red))) to (Picked player) Current gold

That should be it :D
 
try just having it set the players gold to zero instead of the num -100, it might be making it negative for some reason
 
You were right AgentPaper, it did become negative

I think I figured out why. Apparently, the trigger is run before the value that makes the gold go over 100 is added. For example, if player 1 has 90 gold and gets 20 gold, it would give all his allies 10 gold, substract 100 from it's own gold (making it -10) and then add 20.

The following trigger has the same effect and doesn't crash the game :cool: :

HTML: 
Gold Split Dark
    Events
        Time - Every 5.00 seconds of game time
    Conditions
        (Player 7 (Green) Current gold) Greater than or equal to 100
    Actions
        Player Group - Pick every player in (All allies of Player 7 (Green)) and do (Player - Add 10 to (Picked player) Current gold)
        Player - Set Player 7 (Green) Current gold to ((Player 7 (Green) Current gold) - 100)

Thanks for the replies.
 
But that trigger can also result in negativ vaules.

I think this is the problem:

I checked the Allies of Player function and it returns "all allies of specified player, including him/herself"

There is a risk of a infinit loop. (in some weird way. The trigger should only execute when a players gold goes over 100)

I tested it with two tiggers:


Code: 
Add more
    Events
        Player - Player 1 (Red)'s Current gold becomes Greater than 100.00
    Conditions
    Actions
        Player - Add 10 to Player 1 (Red) Current gold

Code: 
Gold
    Events
        Player - Player 1 (Red) types a chat message containing -gold as An exact match
    Conditions
    Actions
        Player - Add 101 to Player 1 (Red) Current gold

Somebody who wantds to guess what happens?

Thats right, the games crashes when I type "-gold".

To fix this:

Code: 
Add more
    Events
        Player - Player 1 (Red)'s Current gold becomes Greater than 100.00
    Conditions
    Actions
        Trigger - Turn off (This trigger)
        Player - Add 10 to Player 1 (Red) Current gold
        Trigger - Turn on (This trigger)
 
phyrex1an said:
But that trigger can also result in negativ vaules.
Click to expand...
The last trigger I posted cannot result in negative values, because I didn't use the event:
HTML: 
Events
        Player - Player 1 (Red)'s Current gold becomes Greater than 100.00
Conditions
Actions
Instead I used the condition:
HTML: 
Events
Conditions
        (Player 1 (Red) Current gold) Greater than or equal to 100
Actions
That way, player 1's gold will always be at least 100, and ([a value of 100 or greater] - 100) is always positive. Also, I know that giving gold to all allies of player 1 will also give gold to player 1, but that's no problem. Even if I give 1000 gold in the game to player 1, it will just distribute across 50 seconds, generating another 100 gold for player 1 in the process, making it execute once more and giving everyone another 10 gold, but not crashing the game. I tested it to the extreme, and it worked exactly as planned :)
 
(First I didnt see that condition, sorry)
My post wasnt to say your new trigger is a bad one...

I posted it to show that the crash was not caused by negative vaules


Prof:
Code: 
    Events
        Player - Player 1 (Red) types a chat message containing -gold as An exact match
    Conditions
    Actions
        Player - Set Player 1 (Red) Current gold to ((Player 1 (Red) Current gold) - 999)
No crash even with 5 gold.

the crashes was caused by a infinit loop in the trigger.



Your new trigger is better than the old one.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    I think on the new one they did change it, but idk. I don't really care whatever the government is doing right now because it's consistently absurd. Like what is RFK doing in charge of health anything? I love the bear story because WTF was that, but also, pretty much every time he talks it's WTF. Like even his voice sounds microwaved
     +1
  • Varine Varine:
    The pyramid is fucking dumb as shit, no matter how you arrange it.
  • Varine Varine:
    It's actually remarkably easy to make mayonnaise though. Fun fact, it USED to kind of be a French mother sauce. I believe that Careme considered it one, it may have been aioli but that has also built a different meaning than it used to. An aioli is just mayonnaise I mixed with other shit typically, I didn't start it don't come at me
  • Varine Varine:
    It's very hard to do it on a large scale though
  • Varine Varine:
    Depending on how you pour the oil the consistency can vary wildly, but that's true for most emulsions. I can only make about two quarts at a time with my robo coup, and if I have to make several in series because I forgot to order it becomes really obvious even when I do it. We have to wait and mix them all together to make sure we have the same thing.
  • Varine Varine:
    Hollandaise is also kind of like that, emulsions require a very steady hand to do exactly the same every time.
  • Varine Varine:
    Luckily I live in an age with electricity so it's way fucking faster, but when I was just a boy trying to find my place I had some hardcore chefs that made use do things like that by hand. It is WAY easier to get right by hand because you control it and can feel it, but it takes soooooo much longer. And on the scale a modern kitchen requires... I serve 400-500 guests on average per day right now, if I had 100 then we could do things way better
  • Varine Varine:
    But we can't do that. In the winter yeah, but I HAVE to get people through here right now so I can afford the staff that we CAN do that. We have about 100 days of summer, and if that summer doesn't make us what it will, then I can't operate the other most of the year with my staff. The owner is talking about closing two days a week to cut down on labor, I told him he should cut down on vacations and it did not go great. I do think I won though, I have to keep my fucking core staff and they have to be gainfully employed
  • Varine Varine:
    Sure some of them might take a second job, but I can't just cut my entire staff to unlivable hours, nor can I can cut them off all winter if I want them to come back.
  • Varine Varine:
    And also, there is no fucking way I'm pulling these hours come september. I only do this right now because I have to, the second I don't have to be the one doing it I won't be
  • Varine Varine:
    I have a 5 person core staff in the kitchen, not including me or Chef Ben
  • Varine Varine:
    Though two of those people are likely not making it this year. One of them has been replaced, the other I am kind of trying to. He's being a giant bitch, today I had to get onto him because in the three hours before I left he had taken like thirty minutes for cigarette breaks
  • Varine Varine:
    And he was also complaining to me the other day that he was out of weed so couldn't smoke any before work that day, and was confused about why I was annoyed he was telling me, his boss, that he is smoking weed everyday before work.
     +1
  • Varine Varine:
    Like yeah I can tell. I don't need to fucking know.
  • Varine Varine:
    So now he's getting scrutinized and will not be top of the list. I know I don't have the smartest people but I do expect them to have some common fucking sense
  • Varine Varine:
    I did do a rare thing for me and hire a girl last month without warning. Everyone was made at me because I started her at like 21, but she worked with me before and I was like don't care. She made 19 at her old job and I wanted her to come work with me, she is the best
     +1
  • Varine Varine:
    I'm going to get her a raise at the end of the summer. She wants to go to school again, but I want her to still work with me so.... she kind of can just tell me what the price is. I can go to 25 if she keeps up. I need to get her onto line more, that's what she wants, but I need her where she is and it's not fair that she doesn't get the little bit of raise that comes with it. She can do it no problem, I've worked with her there.
  • Varine Varine:
    It's just hard to move and train people unnecessarily right now. And also the line fucking sucks, it's not any more fun. This is turn and burn so I have the bankroll, and everyone suffers for it
  • Varine Varine:
    Eventually we'll get it balanced, we'
  • Varine Varine:
    we're starting online orders and stuff, but I also turn that off all the time because I barely keep up trying to be the best at Sysco shit
  • Varine Varine:
    I think it's gonna be a good fall and winter though. We're going to have a good staff, they will get along, they will be able to manage the workload and the complications, they know how to really cook this year, like every person on line knows their steak temps. Some of them use thermometers a lot and they don't always use them right, but they do know how to do it. Failure, especially in this field, is the only way to get better. They'll get it
  • Varine Varine:
    They won't get feel down while they do the thermometer, but we didn't have an instant read probe when I was learning. Like they did but god knows how off it is, you HAD to do it by feel. Even if the chef was fine with me bringing my own, it takes too long. Poke and know
  • The Helper The Helper:
    420 threads in the Artificial Intelligence forum :)
  • The Helper The Helper:
    Happy Monday!
     +1
  • The Helper The Helper:
    and then it was Tuesday!
     +1

      The Helper Discord

      Members online

      No members online now.
      Online now:
      386 (members: 0, guests: 386)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials
      Top