Game Freezing

S

somesexyguy

Guest
Hello, me again. I have developed a simple ranking system where every 5 levels, a player increases in rank, which enables abilities that are unlocked after every promotion. When a hero levels up to another rank, the upgrade "hero rank" is increased to match the level of the rank ability, which tells the player which rank he/she is. but whenever a hero ranks up, it freezes, and i am unsure why. perhaps someone can point out what it is...

Code: 
Increase
    Events
        Unit - A unit Gains a level
    Conditions
    Actions
        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
            If - Conditions
                (Hero level of (Triggering unit)) Equal to 5
            Then - Actions
                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                Player - Set the current research level of Rank: Private  to 2 for (Owner of (Triggering unit))
                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
            Else - Actions
                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                    If - Conditions
                        (Hero level of (Triggering unit)) Equal to 10
                    Then - Actions
                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                        Player - Set the current research level of Rank: Private  to 3 for (Owner of (Triggering unit))
                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                    Else - Actions
                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                            If - Conditions
                                (Hero level of (Triggering unit)) Equal to 15
                            Then - Actions
                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                Player - Set the current research level of Rank: Private  to 4 for (Owner of (Triggering unit))
                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                            Else - Actions
                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                    If - Conditions
                                        (Hero level of (Triggering unit)) Equal to 20
                                    Then - Actions
                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                        Player - Set the current research level of Rank: Private  to 5 for (Owner of (Triggering unit))
                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                    Else - Actions
                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                            If - Conditions
                                                (Hero level of (Triggering unit)) Equal to 25
                                            Then - Actions
                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                Player - Set the current research level of Rank: Private  to 6 for (Owner of (Triggering unit))
                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                            Else - Actions
                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                    If - Conditions
                                                        (Hero level of (Triggering unit)) Equal to 30
                                                    Then - Actions
                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                        Player - Set the current research level of Rank: Private  to 7 for (Owner of (Triggering unit))
                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                    Else - Actions
                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                            If - Conditions
                                                                (Hero level of (Triggering unit)) Equal to 35
                                                            Then - Actions
                                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                Player - Set the current research level of Rank: Private  to 8 for (Owner of (Triggering unit))
                                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                            Else - Actions
                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                    If - Conditions
                                                                        (Hero level of (Triggering unit)) Equal to 40
                                                                    Then - Actions
                                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                        Player - Set the current research level of Rank: Private  to 9 for (Owner of (Triggering unit))
                                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                    Else - Actions
                                                                        If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                            If - Conditions
                                                                                (Hero level of (Triggering unit)) Equal to 45
                                                                            Then - Actions
                                                                                Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                                Player - Set the current research level of Rank: Private  to 10 for (Owner of (Triggering unit))
                                                                                Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                            Else - Actions
                                                                                If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                                                                                    If - Conditions
                                                                                        (Hero level of (Triggering unit)) Equal to 50
                                                                                    Then - Actions
                                                                                        Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                                                                                        Player - Set the current research level of Rank: Private  to 11 for (Owner of (Triggering unit))
                                                                                        Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                                                                                    Else - Actions
 
Exide

Exide

I am amazingly focused right now!
Reaction score
448
I can't see anything that will cause the game to crash in this trigger.
However, I don't like the one million If / Then / Else functions on top of eachother like that. :p
"Elseif" might do the trick for you, there. ;)

Are you sure that this trigger causes the crash? (Are there any other trigger with the same, or similar event?)
Try disabling this trigger and test the game again, to be sure.
 
1

131ackout

Guest
It's freezing because there's like a million actions and If / Then / Else function..

Just simple make a trigger that when the event that the hero gains level..

Then the condition was the unit-type of that hero and level equals to 5..

Then the action are what the hero is removed and created it at that where the place that old hero is removed.
That way, you don't have the leak actions and triggers..
 
Exide

Exide

I am amazingly focused right now!
Reaction score
448
I wrote a small piece of JASS, using elseif. It looks like this:

JASS:

function Trig_Increase_Actions takes nothing returns nothing
    local integer UnitLevel = GetUnitLevel(GetTriggerUnit())

    if UnitLevel == 5 then
      //Your Actions Here.
      elseif UnitLevel == 10 then
        //Your Actions Here.
      elseif UnitLevel == 15 then
        //Your Actions Here..
      elseif UnitLevel == 20 then
        //And so on..
      elseif UnitLevel == 50 then
        //Your Actions Here.
    endif 

endfunction

function InitTrig_Increase takes nothing returns nothing
    local trigger gg_trg_Increase = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Increase, EVENT_PLAYER_HERO_LEVEL )
    call TriggerAddAction( gg_trg_Increase, function Trig_Increase_Actions )  
endfunction


-All you need to add is your actions, where it says "//Your Actions Here.".
 
S

somesexyguy

Guest
well I'm not replacing a hero, all the trigger does is level up the upgrade and the ability called "Hero Rank". And i just finished testing it with only ranking up when a hero reaches level 5, and it still freezes up, so my guess it has something to do with leveling up the upgrade or the ability.
 
vypur85

vypur85

Hibernate
Reaction score
803
Code: 
Increase
    Events
        Unit - A unit Gains a level
    Conditions
    Actions
        For every Integer A 1 to 10 loop do actions
           Loop - Actions
               If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                   If - Conditions
                       (Hero level of (Triggering unit)) Equal to (Integer A * 5) 
                   Then - Actions
                       Game - Display to (All players) the text: |CFF00AEEBYou Have ...
                       Player - Set the current research level of Rank: Private  to (Integer A + 1) for (Owner of (Triggering unit))
                       Unit - Set level of Hero Rank  for (Triggering unit) to (Current research level of Rank: Private  for (Owner of (Triggering unit)))
                   Else - Actions

Simplified version. Not sure why it 'freezes' though. Define 'freeze'. It had a moment of lag or the game crashes?


> It's freezing because there's like a million actions and If / Then / Else function..
Lol... This is not true.
 
S

somesexyguy

Guest
well, when it "freezes" the screen freezes up, everything stops working, and it does it to other players as well. It does so after it performs the actions, such as display the message and level up the ability and upgrade, but i will try the trigger above, seems much more efficient. Thank you.




-Update: Yes! I Finally found out what the problem was, in the end, it wasn't the trigger that was flawed, but the hero rank ability itself; I based this ability off of "pillage" which I'm guess cannot be leveled and caused the freeze. I am now using a different ability and it works out fine. Thanks to everyone who helped me.
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    How can you tell the difference between real traffic and indexing or AI generation bots?
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/

      The Helper Discord

      Staff online

      Members online

      Online now:
      420 (members: 2, guests: 418)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top