System Hero Selection System 1.30b

Vestras

Retired
Reaction score
248
ok so yea I am a tard

my bad

instead of relaseing a new version, heres a quick fix:

in the HSS Trigger, go to the function named "GetSelectionOrders"

its about 1/4 the way down

near the beginning find the part that reads:

JASS:
if bj_isSinglePlayer then
    return false
endif


add a not in front of the bj_isSinglePlayer, so that is now reads:

JASS:
if not bj_isSinglePlayer then
    return false
endif


if you have any others issues plz let me know

kekeke ^_^ of course. Well, I'll do that.
 

cr4xzZz

Also known as azwraith_ftL.
Reaction score
51
Guh... Without AMHS the system works perfectly. I can't seem to find any problems in the implementation, I guess it's because of AMHS itself. Too bad. Well, whatever.

But you should release a new version though. I mean, how hard can it be? Just one not. ^^
 

emjlr3

Change can be a good thing
Reaction score
395
i should :)

maybe tonight, I may have the time
 

cr4xzZz

Also known as azwraith_ftL.
Reaction score
51
Hmm, why don't you put the HSSSetup in the HSS trigger? This will make it only 1 trigger and will make it easier to implement (probably..).
Btw I'm having some problems with that trigger PostHeroCreation (btw u didn't said it's needed). It doesn't show the special effect when the Hero is created.
 

emjlr3

Change can be a good thing
Reaction score
395
its not needed, unless you want to do special things with your heroes once they are created
 

emjlr3

Change can be a good thing
Reaction score
395
updated to include minor coding change
 

emjlr3

Change can be a good thing
Reaction score
395
moved - poke me if you disagree
 

Rommel

New Member
Reaction score
13
Wa..I was looking for a cool HSS for my AOS i finally marked your system.
Its quite nice while Vex's is old
I also agree with you that "repick" is a flaw option. I hate it. :thup:
Im abit hurry so will rep you later. :D
 

Renendaru

(Evol)ution is nothing without love.
Reaction score
309
Sorry to revive old threads, but I found a bug in it kinda... In 1.30b when you pick a hero it crashes all other player if you pick a unit, and if someone else does, it crashes the rest cept the host and the picking player.
 

emjlr3

Change can be a good thing
Reaction score
395
odd that your the first to notice this....
 

Romek

Super Moderator
Reaction score
963
odd that your the first to notice this....
He isn't.
It happened when I tried it out ages ago. I thought it was a problem on my side though.

When testing a friends map who uses this, it also happened. I was going to post here, but... I forgot :p

Either way, This is the best HSS I've seen :D
 

Renendaru

(Evol)ution is nothing without love.
Reaction score
309
I figured out what causes it. If you enable DoubleHeroes and RemoveChosen, it d/cs. But turning of RemoveChosen fixes it. o_O
 

emjlr3

Change can be a good thing
Reaction score
395
strange indeed - no clue why that would desync - it never happened to me
 

Renendaru

(Evol)ution is nothing without love.
Reaction score
309
Could it be the part that does,

JASS:
call RemoveUnit(u)


?

You had said there, hope for no bugs.
 

emjlr3

Change can be a good thing
Reaction score
395
considering that is the only difference - one would assume

but removing a unit does not desync players - and the outcome sounds like a desync, not a crash - so I am really at a loss here
 

Romek

Super Moderator
Reaction score
963
considering that is the only difference - one would assume

but removing a unit does not desync players - and the outcome sounds like a desync, not a crash - so I am really at a loss here
Removing a unit does cause desyncs doesn't it?

The problem is a desync, not a crash (Whoever claimed that :p).

Maybe showing / hiding a timerdialog for a Local Player desyncs?
 

emjlr3

Change can be a good thing
Reaction score
395
if i tried to remove a unit for 1 player, maybe, but not just removing a unit period
i mentioned a crash simply because remove unit I can see somehow causing a crash, in some way - but like i said, a desync is the issue - and I cant see how or why it would

sync you said turning off removal of chosen heroes stopped the issues, and removeunit is the only difference....
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top