Spell Ice Trap

Discussion in 'Spells' started by BRUTAL, Jun 24, 2008.

  1. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    if it was ranged it could,
    and a melee hero can still attack a trapped enemy unit.
     
    • Like Like x 1
  2. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    bump
    -merged two triggers
    -made immolation a custom ability
     
  3. CaptDeath

    CaptDeath New Member

    Ratings:
    +103 / 0 / -0
    nice spell:) 5/5 and a +rep
     
    • Like Like x 1
  4. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    thank you
     
  5. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    bump
    redid the spell in vjass, my first vjass spell ><
     
  6. mordocai

    mordocai New Member

    Ratings:
    +17 / 0 / -0
    should make it dome like :D
     
  7. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    like being tottaly enclosed overtop aswell or something? ;o
    maybe.
    any comments on the code? D:
     
  8. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    bump
    edited code
     
  9. BlackRose

    BlackRose Forum User

    Ratings:
    +239 / 0 / -0
    Tested, it is good. Though I have seen other spells like this. The only thing I dislike is the testing map. I don't like clicking icons, I like pressing ESCape to restore cooldown and mana.

    >should make it dome like
    Then you can't see! Unless you use some dome model like Freezing Ring or something.

    The coding, I'm not good at JASS <It looks fine>, but the function names are funny. qwe? c?
     
    • Like Like x 1
  10. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    ah well, its just a test map :p

    c = condition
    a = action
    qwe = my initializer function name

    idk how i thought of qwe but thats just what i use lol
    thanks anyways
     
  11. SerraAvenger

    SerraAvenger Cuz I can

    Ratings:
    +236 / 0 / -0
    Use more descriptive ones, like INIT, Actions and Conditions.
    Also, please make Duration and Distance functions:
    JASS:
    function Duration takes integer level returns real
        return 6 + 3 * level
    endfunction
    
    function Distance takes integer level returns real
        return 270 + 20 * level
    endfunction

    also fix this:

    JASS:
    // - copy and paste the triggers 'ice trap', 'remove', and 'TT'

    good spell other than that : )
     
  12. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    i suppooooooose i can change the function names to more obviousy ones when submitting
    whats wrong with that comment lol
     
  13. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    bump
    updated
     
  14. TriggerHappy

    TriggerHappy ...

    Ratings:
    +341 / 0 / -0
    I haven't looked at any other comments, so sorry if I said something already stated.

     
  15. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    >Why is your struct public?
    ah, must have forgotten to change that from before, thanks

    >Make your DURATION,DISTANCE function's constant. Also give c a better name.
    omg, serra avenger told me to make them into functions so they could be configurable to the users needs

    >
    JASS:
    local player p = GetOwningPlayer(.caster)

    needs to be nulled.
    why does it need to be nulled? its a player variable o_O dont tell me i didnt know they had to be nulled this whole time T_T

    oh, so should i set SpellTargerLoc() in a varible :p

    alright; i'll update this soon
     
  16. TriggerHappy

    TriggerHappy ...

    Ratings:
    +341 / 0 / -0
    Constant functions :p

    JASS:
    private constant function name ect..


    Players extend a handle, and they need to be nulled.

    Yes.

    You may also want to change your scope to a library, so it can require TT.

    JASS:
    library icetrap initializer qwe required TT
     
  17. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    ohhhhhhhhh ;o

    omg fuck, now i have to add that nulling into everythign ive ever done T_T

    i see, alright
     
  18. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    updated;
    changed what was mentioned, except the 'library icetrap initializer qwe required TT' part gave me errors so i left it alone :confused:
     
  19. TriggerHappy

    TriggerHappy ...

    Ratings:
    +341 / 0 / -0
    I was wrong about this, or at least I'm pretty sure I am.

    Better get a leak expert to verify :p
     
  20. BRUTAL

    BRUTAL I'm working

    Ratings:
    +118 / 0 / -0
    i hope your wrong : o
    i think it doesnt need to be nulled; not that i would know, but i remember asking about nulling before and players were listed as not needing to :rolleyes:
     

Share This Page