Spell Ice Trap

[BRUTAL]

if it was ranged it could,
and a melee hero can still attack a trapped enemy unit.

 

[BRUTAL]

bump
-merged two triggers
-made immolation a custom ability

 

[CaptDeath]

nice spell 5/5 and a +rep

 

[BRUTAL]

thank you

 

[BRUTAL]

bump
redid the spell in vjass, my first vjass spell ><

 

[mordocai]

should make it dome like

 

[BRUTAL]

like being tottaly enclosed overtop aswell or something? ;o
maybe.
any comments on the code? D:

 

[BRUTAL]

bump
edited code

 

[BlackRose]

Tested, it is good. Though I have seen other spells like this. The only thing I dislike is the testing map. I don't like clicking icons, I like pressing ESCape to restore cooldown and mana.

>should make it dome like
Then you can't see! Unless you use some dome model like Freezing Ring or something.

The coding, I'm not good at JASS <It looks fine>, but the function names are funny. qwe? c?

 

[BRUTAL]

ah well, its just a test map

but the function names are funny. qwe? c?

c = condition
a = action
qwe = my initializer function name

idk how i thought of qwe but thats just what i use lol
thanks anyways

 

[SerraAvenger]

Use more descriptive ones, like INIT, Actions and Conditions.
Also, please make Duration and Distance functions:

function Duration takes integer level returns real
    return 6 + 3 * level
endfunction

function Distance takes integer level returns real
    return 270 + 20 * level
endfunction

also fix this:

// - copy and paste the triggers 'ice trap', 'remove', and 'TT'

good spell other than that : )

 

[BRUTAL]

i suppooooooose i can change the function names to more obviousy ones when submitting
whats wrong with that comment lol

 

[BRUTAL]

bump
updated

 

[TriggerHappy]

I haven't looked at any other comments, so sorry if I said something already stated.

• Why is your struct public?
• Make your DURATION,DISTANCE function's constant. Also give c a better name.

• local player p = GetOwningPlayer(.caster)

  needs to be nulled.

•     set data.x = GetLocationX (GetSpellTargetLoc())
      set data.y = GetLocationY (GetSpellTargetLoc())

  Leaks.

•     set data.caster = u
      set data.x = GetLocationX (GetSpellTargetLoc())
      set data.y = GetLocationY (GetSpellTargetLoc())
      set data.angle = GetUnitFacing(u) + 140
      set data.angle2 = GetUnitFacing(u) + 140 + (ADD_ANGLE / 2)

  You should move all that into a create method.

 

[BRUTAL]

>Why is your struct public?
ah, must have forgotten to change that from before, thanks

>Make your DURATION,DISTANCE function's constant. Also give c a better name.
omg, serra avenger told me to make them into functions so they could be configurable to the users needs

>

local player p = GetOwningPlayer(.caster)

needs to be nulled.
why does it need to be nulled? its a player variable dont tell me i didnt know they had to be nulled this whole time T_T

oh, so should i set SpellTargerLoc() in a varible

alright; i'll update this soon

 

[TriggerHappy]

omg, serra avenger told me to make them into functions so they could be configurable to the users needs

Constant functions

private constant function name ect..

Players extend a handle, and they need to be nulled.

oh, so should i set SpellTargerLoc() in a varible

Yes.

You may also want to change your scope to a library, so it can require TT.

library icetrap initializer qwe required TT

 

[BRUTAL]

ohhhhhhhhh ;o

omg fuck, now i have to add that nulling into everythign ive ever done T_T

i see, alright

 

[BRUTAL]

updated;
changed what was mentioned, except the 'library icetrap initializer qwe required TT' part gave me errors so i left it alone

 

[TriggerHappy]

needs to be nulled.
why does it need to be nulled? its a player variable dont tell me i didnt know they had to be nulled this whole time T_T

I was wrong about this, or at least I'm pretty sure I am.

Better get a leak expert to verify

 

[BRUTAL]

i hope your wrong : o
i think it doesnt need to be nulled; not that i would know, but i remember asking about nulling before and players were listed as not needing to