Spell Ice Trap

BRUTAL

I'm working
Reaction score
118
like being tottaly enclosed overtop aswell or something? ;o
maybe.
any comments on the code? D:
 

BlackRose

Forum User
Reaction score
239
Tested, it is good. Though I have seen other spells like this. The only thing I dislike is the testing map. I don't like clicking icons, I like pressing ESCape to restore cooldown and mana.

>should make it dome like
Then you can't see! Unless you use some dome model like Freezing Ring or something.

The coding, I'm not good at JASS <It looks fine>, but the function names are funny. qwe? c?
 

BRUTAL

I'm working
Reaction score
118
ah well, its just a test map :p

but the function names are funny. qwe? c?
c = condition
a = action
qwe = my initializer function name

idk how i thought of qwe but thats just what i use lol
thanks anyways
 

SerraAvenger

Cuz I can
Reaction score
234
Use more descriptive ones, like INIT, Actions and Conditions.
Also, please make Duration and Distance functions:
JASS:
function Duration takes integer level returns real
    return 6 + 3 * level
endfunction

function Distance takes integer level returns real
    return 270 + 20 * level
endfunction

also fix this:

JASS:
// - copy and paste the triggers &#039;ice trap&#039;, &#039;remove&#039;, and &#039;TT&#039;

good spell other than that : )
 

BRUTAL

I'm working
Reaction score
118
i suppooooooose i can change the function names to more obviousy ones when submitting
whats wrong with that comment lol
 
Reaction score
341
I haven't looked at any other comments, so sorry if I said something already stated.

 

BRUTAL

I'm working
Reaction score
118
>Why is your struct public?
ah, must have forgotten to change that from before, thanks

>Make your DURATION,DISTANCE function's constant. Also give c a better name.
omg, serra avenger told me to make them into functions so they could be configurable to the users needs

>
JASS:
local player p = GetOwningPlayer(.caster)

needs to be nulled.
why does it need to be nulled? its a player variable o_O dont tell me i didnt know they had to be nulled this whole time T_T

oh, so should i set SpellTargerLoc() in a varible :p

alright; i'll update this soon
 
Reaction score
341
omg, serra avenger told me to make them into functions so they could be configurable to the users needs

Constant functions :p

JASS:
private constant function name ect..


Players extend a handle, and they need to be nulled.

oh, so should i set SpellTargerLoc() in a varible

Yes.

You may also want to change your scope to a library, so it can require TT.

JASS:
library icetrap initializer qwe required TT
 

BRUTAL

I'm working
Reaction score
118
ohhhhhhhhh ;o

omg fuck, now i have to add that nulling into everythign ive ever done T_T

i see, alright
 

BRUTAL

I'm working
Reaction score
118
updated;
changed what was mentioned, except the 'library icetrap initializer qwe required TT' part gave me errors so i left it alone :confused:
 
Reaction score
341
needs to be nulled.
why does it need to be nulled? its a player variable o_O dont tell me i didnt know they had to be nulled this whole time T_T

I was wrong about this, or at least I'm pretty sure I am.

Better get a leak expert to verify :p
 

BRUTAL

I'm working
Reaction score
118
i hope your wrong : o
i think it doesnt need to be nulled; not that i would know, but i remember asking about nulling before and players were listed as not needing to :rolleyes:
 
General chit-chat
Help Users
  • No one is chatting at the moment.

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top