if ability is ultimate?

[XeNiM666]

well simple question...
how would i know/set if an ability is an ultimate?

 

[Ayanami]

Hmm, how about storing the ability in a variable array, and looping through the variables to check if it's an ultimate Could be inefficient though.

Or maybe, you could store a boolean in a hashtable with the parent key set as the ability raw code.

 

[NeuroToxin]

Or, go to the ability you made, and change the required level to 6?

 

[Weep]

If it is a hero spell and its minimum required level is higher than 1, WC3 considers it an "ultimate", with a few exceptions (eg. Phoenix Fire).

 

[KaerfNomekop]

If it is a hero spell and its minimum required level is higher than 1, WC3 considers it an "ultimate", with a few exceptions (eg. Phoenix Fire).

Is Phoenix Fire an ultimate? It's not even a hero ability.

 

[Weep]

Is Phoenix Fire an ultimate? It's not even a hero ability.

No. What I mean is that even if you edit its settings to fit the profile of an "ultimate", it still won't target spell immune units even if the gameplay constants are set to allow ultimates to do so.

 

[luorax]

Well, with a simple JASS function and a custom script we can do it:

1, You'll have to add some simple letters to your ulti's end: " (U)" (e.g. "Avatar" >> "Avatar (U)")
2, Copy my function to your map's header
3, To test whether an ability is ulti or not, just call that function.

Function:

function IsAbilityUltimate takes integer id returns boolean
    local string s = GetObjectName(id)
    return SubString(s, StringLength(s)-4, StringLength(s)) == " (U)"
endfunction

Usage:

if IsAbilityUltimate('A006') then
        call BJDebugMsg("ULTI")
    else
        call BJDebugMsg("NOT ULTI")
    endif

Hope I helped you

Note that you have to rename the function not the tooltip. The name is invisible for the players, so we can do with it whatever we would like to.

 

[DioD]

not really smart way to change name of every skill, when you simply can make database with skills you need.

 

[luorax]

Yes, but takes about 2 mins to edit them, and will work faster in-game.

 

[meOme]

I would do it like this:

function IsAbilityUltimate takes integer id returns boolean
    return ( id == 'A001' or id == 'A002' or id == 'A003' or id == 'A004' or id == 'A005' )
endfunction

(A001, A002, A003, A004 and A005 are ultimates)

You're just comparing some integers (as many as there are heroes), I don't think you will get any performance problems from that.

/edit: Of course, you can't put this function in the map header, but I don't think that's that much of a problem.

 

[DioD]

comparing 2 integers is MUCH MORE faster then substrings.

 

[luorax]

I haven't said that substrings are faster than comparing two integers...
Please read the whole topic if you would like to comment...

 

[DioD]

and will work faster in-game.

forgot your own post...lololol...

 

[Sevion]

Hmm?

Use a struct...

keyword ultimateList

globals
    ultimateList spells
endglobals

struct ultimateList extends array
    private boolean isUltimateX

    // Not explicitly required, but if you wish to do something upon setting the boolean...
    public method operator isUltimate= takes integer i, boolean flag returns nothing
        set spells<i>.isUltimateX = flag
    endmethod

    public method operator isUltimate takes integer i returns boolean
        debug if spells<i>.isUltimateX = null then
            debug DisplayTextToPlayer(GetLocalPlayer(), 0, 0, &quot;Warning (isUltimate): Null boolean!&quot;)
            debug // Do something else? I.E. return false ?
        debug endif
        return spells<i>.isUltimateX
    endmethod
    
    private static method onInit takes nothing returns nothing
        set spells = thistype.allocate()
        set spells[A000].isUltimateX = true
        set spells[A001].isUltimateX = true
    endmethod
endstruct

//usage

scope myTest initializer init
    private function init takes nothing returns nothing
        if ( ultimates[A000].isUltimate ) then
            // Do Something
        else
            // Do Something Else
        endif
    endfunction
endscope
</i></i></i>

There's a little work in initialization.

A little less efficient than the if ... or ... or ... or ... then method, but prettier and the efficiency impact is moot.

You can also use this as an interface to add additional features.

It has been a while since I vJASSed, so my scripting may be a bit rusty.

You could also wrap the struct into a library and privatize the entire struct to stop users from making duplicate structs. Just make the "spells" variable public.

 

[luorax]

forgot your own post...lololol...

Mr. Egoism, I still can't say anything else: read the whole post if you would like to comment.

 

[DioD]

A000 is large integer and will not fit 8190 limit for arrays.

you must use ID - A000 or other way to fit ID into 8190 bounds.

 

[Sevion]

Ah, now I remember. You are correct. Anyhow, it's a quick fix.