IKilledKEnny's JASS Question Theard, I love to give +REP :)

[IKilledKEnny]

Jesus, thanks to all the pointers Andrew! It shows that I'm a begginer.

Anyway doesn't this line

call UnitAddAbilityBJ( 'Arav', cast )

add crow form?

Edit: So sorry but another problem (lol those spells were supposed to be in a released spell pack, I guess I'll have to give you all tons of credits ), anyway I'm trying to work on this spell and I just checked it and it doesn't work. I believe the bolded line is what screws it (I removed if / then / else to be sure i's not luck that does it)

function Trig_Air_Shield_Conditions takes nothing returns boolean
    if ( not ( UnitHasBuffBJ(GetSpellTargetUnit(), 'B000') == true ) ) then
        return false
    endif
    if ( not ( GetUnitAbilityLevelSwapped('ANab', GetSpellTargetUnit()) >= GetUnitAbilityLevelSwapped(GetSpellAbilityId(), GetSpellAbilityUnit()) ) ) then
        return false
    endif
    return true
endfunction

function Trig_Air_Shield_Actions takes nothing returns nothing
    local location AHLoc
    local unit dum
    local unit vic
    local unit ref
        set vic = GetSpellAbilityUnit()
        set ref = GetSpellTargetUnit()
        set AHLoc = GetUnitLoc(GetSpellTargetUnit())
        call CreateNUnitsAtLoc( 1, 'h001', GetOwningPlayer(GetSpellTargetUnit()), AHLoc, GetUnitFacing(GetSpellTargetUnit()) )
        set dum = GetLastCreatedUnit()
        call UnitAddAbilityBJ( GetSpellAbilityId(), dum )
        call SetUnitAbilityLevelSwapped( GetSpellAbilityId(), dum, GetUnitAbilityLevelSwapped(GetSpellAbilityId(), GetSpellAbilityUnit()) )
        call TriggerSleepAction (1.00)
        call SetUnitAnimation( ref, "cast" )
[B]        call IssueTargetOrderBJ( dum, AbilityId2String(GetSpellAbilityId()), vic)[/B]

endfunction

//===========================================================================
function InitTrig_Air_Shield takes nothing returns nothing
    set gg_trg_Air_Shield = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Air_Shield, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Air_Shield, Condition( function Trig_Air_Shield_Conditions ) )
    call TriggerAddAction( gg_trg_Air_Shield, function Trig_Air_Shield_Actions )
endfunction

 

[Andrewgosu]

No, "Crow Form" raw code is 'Amrf'.

 

[IKilledKEnny]

Nope, I used that before and saw it doesn't work so I tried what sooda (or chocobo? ) said about using Arav and both didn't work...

 

[emjlr3]

crow form works, so does metamorphisis I believe

 

[IKilledKEnny]

Well, I guess i did somthing really wrong, but it doesn't work for me... What do you think the problem might be? Would you mind if I'll post the map and I'll say what are the problems in each Trigger, and you will try to fix them? I know it's a lot of work, but I would really appreciate that.

Thanks!

 

[Andrewgosu]

Well, try this one. I optimized the code, too.

function Trig_Air_Shield_Conditions takes nothing returns boolean
    return ( ( GetUnitAbilityLevel( GetSpellTargetUnit(), 'B000' ) > 0 ) and (( GetUnitAbilityLevel(GetSpellTargetUnit(), 'ANab' ) >= GetUnitAbilityLevel( GetTriggerUnit(), GetSpellAbilityId()))))
endfunction

function Trig_Air_Shield_Actions takes nothing returns nothing
    local unit     a  =  GetTriggerUnit()
    local unit     b  =  GetSpellTargetUnit()
    local real     x  =  GetUnitX( b )
    local real     y  =  GetUnitY( b )
    local real     r  =  GetUnitFacing( b )
    local integer  i  =  GetSpellAbilityId()
    local unit     c  =  CreateUnit( GetOwningPlayer( b ), 'h001', x, y, r ) 

    if ((GetRandomInt(1, 100) <= (GetUnitAbilityLevel( b, 'A002' ) * 15))) then
        call UnitAddAbility( c, i )
        call SetUnitAbilityLevel( c, i, GetUnitAbilityLevel( a, i ) )
        call TriggerSleepAction ( 1.00 )
        call SetUnitAnimation( b, "cast" )
        call IssueTargetOrderById( c, i, b )
    endif
    
    set a = null
    set b = null
    set c = null    
endfunction

//===========================================================================
function InitTrig_Air_Shield takes nothing returns nothing
    set gg_trg_Air_Shield = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Air_Shield, EVENT_PLAYER_UNIT_SPELL_EFFECT )
    call TriggerAddCondition( gg_trg_Air_Shield, Condition( function Trig_Air_Shield_Conditions ) )
    call TriggerAddAction( gg_trg_Air_Shield, function Trig_Air_Shield_Actions )
endfunction

 

[IKilledKEnny]

New question.

I'm trying to get a learned skill's id. I figured the following line should work, however it disables my trigger for an unknown reason. When I ran it in JASSCraft it says I have too many arguments.

function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'==true
endfunction

 

[Chocobo]

New question.

I'm trying to get a learned skill's id. I figured the following line should work, however it disables my trigger for an unknown reason. When I ran it in JASSCraft it says I have too many arguments.

function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'==true
endfunction

function Sap Conditions takes nothing returns boolean
return GetSpellAbilityId(GetLearnedSkill())=='A000'
endfunction

instead.

 

[IKilledKEnny]

Thanks. Next Question.

I tryed to do this:

set dummy=CreateNUnitsAtLoc(1,id,p,ld,bj_UNIT_FACING)

Like I was told I can do it, however it disabled the trigger. When I did

call CreateNUnitsAtLoc(1,id,p,ld,bj_UNIT_FACING)
set dummy=GetLastCreatedUnit

it worked fine however.

 

[AceHart]

> Like I was told I can do it

I guess that someone also said "with the action 'CreateUnit'"? If not, he should have.

 

[IKilledKEnny]

local unit dummy=CreateUnit(id,p,ld,bj_UNIT_FACING)

Still doesn't work.

 

[AceHart]

CreateUnit(player, unitid, x, y, facing)
or
CreateUnitAtLoc(player, unitid, location, facing)

 

[IKilledKEnny]

Works like a charm. Many thanks.

 

[IKilledKEnny]

Yet, another question. Why is this trigger disabled? (This is just a part of the trigger)

function TFGC takes nothing returns boolean
return GetFilterUnit()!=GetTriggerUnit()
endfunction

function TFC takes nothing returns boolean
return GetSpellAbilityId()=='A000'
endfunction

function TFA takes nothing returns nothing
local unit c=GetTriggerUnit()
local group g=CreateGroup()
local boolexpr b=Condition(function TFGC)
local unit f

call GroupEnumUnitsInRect(g,GetWorldBounds(),b)
loop
  set f=FirstOfGroup(g)
  exitwhen f==null
  call PauseUnitBJ(f,true)
[B]  call GroupRemoveUnit(g,f)[/B]
endloop

It tells about the bolded line that there is invalid arguement type (boolean)

 

[AceHart]

> call PauseUnitBJ(f,true)

call PauseUnit(f,true)

 

[IKilledKEnny]

Lol, such a simple problem. Thanks again.

JASS is pretty hard.

 

[IKilledKEnny]

Yet, another question. Why does this disable the trigger? I believe it has somthing to do with the bolded part but I'm not sure.

function TFMC2 takes nothing returns boolean
if (GetIssuedOrderIdBJ()==String2OrderIdBJ("smart")) then
  return true
elseif (GetIssuedOrderIdBJ()==String2OrderIdBJ("move")) then
return true
endif
return false
endfunction

function TFMC1 takes nothing returns boolean
if [B](function TFMC2==true)[/B] then
  if UnitHasBuffBJ(GetTriggerUnit(),'B000') then
    return true
  endif
endif
return false
endfunction

 

[AceHart]

> if (function TFMC2==true) then

if TFMC2()==true then


Why is that actually a function? Put it all in one...

 

[IKilledKEnny]

Thanks again AceHart.

I want it to be
Unit has buff and the command is either smart or move, I figured that would be the easiest way to do it.

 

[IKilledKEnny]

I read Daelin's tutorial (Advanced Tips) and got great explanation from Tom Jones regarding local handles. From what I understood you can call a linker and then few handles that will be linked to him.

So by being able to call the linker only, you can also call the other linked handles. (Daelin's used the word linked so I assume that is what more or less happening).

Also I have been told that not destroy the leaks when we are done with them casus a leak.

My question is say that I want to keep the links to rest of the game, doesn't matter why. How bad would the leak be?

I'll give you an example, say I want to keep pushing a unit back all the game, thus in order to make the pushing efficent I need the unit to be "linked" to a timer (and maybe even a point). So if I wanto achive this, how would it effect the computer?