I'm new to structs

[Dirac]

Hello guys i just made this trigger which purpose is to move a ship through water using the arrow keys. I've never used structs nor vJass before. I just want to know if theres a way to enhance my code.
- I tried to clear all BJs
- I need a better way to initialize my global arrays
- Is there a way to change global arrays from other triggers?
- What does a static method do?
- What is a keyword?

+rep will be rewarded for those who help me improve my coding skills

scope Movement initializer OnInit


    globals
        private unit array ship

        private boolean array left
        private boolean array right
        private boolean array up

        public real array speed
        public real array angle
        public real array maxturnangle
        public real array acceleration
    endglobals

    private struct shipdata
        unit u
        integer i
        real x
        real y

        method store takes unit u, integer i returns nothing
            set this.u = u
            set this.i = i
        endmethod

        method acc takes real a, boolean b,real c returns nothing
            if this.x<c and b== true then
                set this.x = this.x+a
            elseif this.x > 0 then
                set this.x = this.x-a
            endif
        endmethod

        method turn takes real a,boolean b,boolean c, real d returns nothing
            if b != c then
                if b==true and this.y < d then
                    set this.y = this.y + a
                elseif c==true and this.y > d*(-1) then
                    set this.y = this.y - a
                endif
            else
                if this.y > 0 then
                    set this.y = this.y - a
                elseif this.y < 0 then
                    set this.y = this.y + a
                endif
            endif
        endmethod
    endstruct

    private function setglobals takes nothing returns nothing
        local shipdata ud=shipdata.create()
        set ship[0] = CreateUnit(Player(0),'H000',-3000.,-3000.,0.)
        call SetUnitUserData(ship[0],ud)
        call ud.store(ship[0],GetPlayerId(GetOwningPlayer(ship[0])))
    endfunction

    private function pressl takes nothing returns nothing
        if left[GetPlayerId(GetTriggerPlayer())] == true then
            set left[GetPlayerId(GetTriggerPlayer())] = false
        else
            set left[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    private function pressr takes nothing returns nothing
        if right[GetPlayerId(GetTriggerPlayer())] == true then
            set right[GetPlayerId(GetTriggerPlayer())] = false
        else
            set right[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    private function pressu takes nothing returns nothing
        if up[GetPlayerId(GetTriggerPlayer())] == true then
            set up[GetPlayerId(GetTriggerPlayer())] = false
        else
            set up[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    public function periodic takes nothing returns nothing
        local real x
        local real y
        local integer i = 0
        local shipdata ud=GetUnitUserData(ship<i>)
        loop
            exitwhen i == 1
            call ud.turn (0.05,left<i>,right<i>,maxturnangle<i>)
            call ud.acc (acceleration<i>, up<i>, speed<i>)
            set x = GetUnitX(ship<i>) + ud.x*Cos(Deg2Rad(GetUnitFacing(ship<i>)+ud.y))
            set y = GetUnitY(ship<i>) + ud.x*Sin(Deg2Rad(GetUnitFacing(ship<i>)+ud.y))
            call SetUnitFacing(ship<i>,GetUnitFacing(ship<i>)+ud.y)
            call SetUnitX(ship<i>,x)
            call SetUnitY(ship<i>,y)
            if GetLocalPlayer() != Player(i) then
                set x=0.
                set y=0.
            endif
            call PanCameraToTimed(x,y,0.)
            call SetCameraRotateMode(x,y,Deg2Rad(270+GetUnitFacing(ship<i>)),0.)
            call SetCameraField(CAMERA_FIELD_TARGET_DISTANCE,3900.,0.)
            set i = i+1
        endloop
    endfunction

    // =============================================================
    private function OnInit takes nothing returns nothing
        local trigger mov = CreateTrigger() //create a local for each trigger
        local trigger left = CreateTrigger()
        local trigger right = CreateTrigger()
        local trigger up = CreateTrigger()
        local trigger init = CreateTrigger()
        local trigger t = CreateTrigger()
        local integer i = 0
        loop
            exitwhen i == 5
            call TriggerRegisterPlayerEvent (left, Player (i), EVENT_PLAYER_ARROW_LEFT_DOWN) // add the arrow key events to the triggers
            call TriggerRegisterPlayerEvent (left, Player(i), EVENT_PLAYER_ARROW_LEFT_UP)
            call TriggerRegisterPlayerEvent (right, Player(i), EVENT_PLAYER_ARROW_RIGHT_DOWN)
            call TriggerRegisterPlayerEvent (right, Player(i), EVENT_PLAYER_ARROW_RIGHT_UP)
            call TriggerRegisterPlayerEvent (up, Player(i), EVENT_PLAYER_ARROW_UP_DOWN)
            call TriggerRegisterPlayerEvent (up, Player(i), EVENT_PLAYER_ARROW_UP_UP)
            set i = i+1
        endloop
        call TriggerRegisterTimerEvent(t,0.0325,true)
        call TriggerAddAction(t, function periodic )
        call TriggerRegisterTimerEvent(init,0,false)
        call TriggerAddAction( left, function pressl )
        call TriggerAddAction( right, function pressr )
        call TriggerAddAction( up, function pressu )
        call TriggerAddAction(init, function setglobals)
    endfunction

endscope</i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i>

 

[Sevion]

Your coding skills would benefit greatly by code indention :3

Yes, there is a way to change global arrays from other triggers. Simply make sure the global is public (no modifier or [ljass]public[/ljass] modifier, which you already have) and just do something like [ljass]myPublicGlobal[1] = 14[/ljass] in whatever trigger you want. Though some things come into play like trigger placement, but as long as the trigger you're declaring the global is in is above the trigger/function that you're using it in then you're fine.

Static means the method/member has only one instance per struct. Non-static members/methods have one instance per struct instance.

A keyword simply allows for use of something above its declaration. For example:

keyword myStruct

globals
    myStruct myGlobalStruct
endglobals

struct myStruct
    int data
endstruct

 

[Dirac]

thanks for the info, a couple of questions regarding your post
- What's the easiest way to apply indention to my code?
- What good does it make having a static method (isn't a normal method good enough?)

+rep

 

[Sevion]

The easiest way is to use the built in indenter TESH auto indents for you.

Otherwise you have to just simply go through and indent with tab.

There are uses for static methods like Timer Callbacks, etc. You can't pass non-static methods through those.

 

[Solmyr]

Static methods are basically "functions in disguise". They do not use an instance ([ljass]this[/ljass]), but still have an access to all of the members of the struct.

There's another use for [ljass]keyword[/ljass] (besides what Sevion said) - making library-private struct members or methods.

library Foo
    private keyword libraryPrivateString
    
    struct Bar
        string libraryPrivateString
        private string structPrivateString
        real publicReal
        /* This struct has access to "libraryPrivateString", "structPrivateString" and "publicReal" */
    endstruct

    private function doThings takes nothing returns nothing
        /* This function has access to "libraryPrivateString" and "publicReal" */
    endfunction
endlibrary

scope Foobar
    private function doMoreThings takes nothing returns nothing
        /* This function has access only to "publicReal" */
    endfunction
endscope

 

[Dirac]

I've been coding with tesh so far and no intendion has been done so far, is there some kind of option i have to turn on?

 

[Sevion]

That's strange. I thought TESH auto indents. Just remember to use Tab I suppose. Tab in every "block".

I.E. the contents of a function block are indented and the contents of an if block inside of that function are indented two tabs.

 

[WolfieeifloW]

Example:

scope...                 //Aligned all the way left

    globals              //Anything past scope indented once, new block, globals block
        integer...       //All things inside the block indented once again
    endglobals           //Block ending, lineup with the opening of the block

    function...          //New block, a function, indent once
        if...            //All code inside the function block indented once past the opening block; Also, an opening if block
            call...      //All code inside the if is indented once again
            if...        //Nested if opening
                call...  //Again, indent once after an if block
            endif        //Lineup with the opening block of your if
        endif            //Again, line it up with the opening of the if
    endfunction          //Always end the closing of blocks with the opening

endscope                 //Again, lineup openings and closings

Just a sort of basic code example.

 

[Solmyr]

There's no point in coding with TESH. Just use jEdit with Vexorian's JASS2, vJass and Zinc modes (it indents automatically) and import the code afterwards with [ljass]//! import[/ljass].

jEdit - Progammer's Text Editor
JASS2, vJass and Zinc edit modes for jEdit

 

[WolfieeifloW]

Those look complex
Why not just write your code in the actual WE and use 'Tab'?
Or am I missing the point of the programs?

 

[Dirac]

Thanks wolfiee, i was just wondering if the editor did it automatically, guess it doesn't

Yes, there is a way to change global arrays from other triggers. Simply make sure the global is public (no modifier or public modifier, which you already have) and just do something like myPublicGlobal[1] = 14 in whatever trigger you want. Though some things come into play like trigger placement, but as long as the trigger you're declaring the global is in is above the trigger/function that you're using it in then you're fine.

I created a new trigger with this code and gives me syntax errors

scope GlobalsSet initializer start
    private function start takes nothing returns nothing
        set speed[0] = 10.
        set angle [0] = 6.
        set acceleration[0] = 0.1
        set maxturnangle[0] = 6.
    endfunction
endscope

Also, update the code with some intending applied

 

[WolfieeifloW]

Here's your code, with proper indentation:

scope Movement initializer OnInit

    globals
        unit array ship
        
        boolean array left
        boolean array right
        boolean array up

        real array speed
        real array angle
        real array maxturnangle
        real array acceleration
    endglobals

    private struct data
        unit u
        integer i
        real x
        real y
        trigger t
        boolean a
        boolean b
        boolean c

        method acc takes real a, boolean b,real c returns nothing
            if this.x<c and b== true then
                set this.x = this.x+a
            elseif this.x > 0 then
                set this.x = this.x-a
            endif
        endmethod

        method turn takes real a,boolean b,boolean c, real d returns nothing
            if b != c then
                if b==true and this.y < d then
                    set this.y = this.y + a
                elseif c==true and this.y > d*(-1) then
                    set this.y = this.y - a
                endif
            else
                if this.y > 0 then
                    set this.y = this.y - a
                elseif this.y < 0 then
                    set this.y = this.y + a
                endif
            endif
        endmethod
    endstruct

    private function setglobals takes nothing returns nothing
        local data ud=data.create()
        set ship[0] = CreateUnit(Player(0),'H000',-3000.,-3000.,0.)
        call SetUnitUserData(ship[0],ud)
        set speed[0] = 10.
        set angle [0] = 6.
        set acceleration[0] = 0.1
        set maxturnangle[0] = 6.
    endfunction

    private function pressl takes nothing returns nothing
        if left[GetPlayerId(GetTriggerPlayer())] == true then
            set left[GetPlayerId(GetTriggerPlayer())] = false
        else
            set left[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    private function pressr takes nothing returns nothing
        if right[GetPlayerId(GetTriggerPlayer())] == true then
            set right[GetPlayerId(GetTriggerPlayer())] = false
        else
            set right[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    private function pressu takes nothing returns nothing
        if up[GetPlayerId(GetTriggerPlayer())] == true then
            set up[GetPlayerId(GetTriggerPlayer())] = false
        else
            set up[GetPlayerId(GetTriggerPlayer())] = true
        endif
    endfunction

    private function periodic takes nothing returns nothing
        local real x
        local real y
        local integer i = 0
        local data ud=GetUnitUserData(ship<i>)
        loop
        exitwhen i == 1
            call ud.turn (0.05,left<i>,right<i>,maxturnangle<i>)
            call ud.acc (acceleration<i>, up<i>, speed<i>)
            set x = GetUnitX(ship<i>) + ud.x*Cos(Deg2Rad(GetUnitFacing(ship<i>)+ud.y))
            set y = GetUnitY(ship<i>) + ud.x*Sin(Deg2Rad(GetUnitFacing(ship<i>)+ud.y))
            call SetUnitFacing(ship<i>,GetUnitFacing(ship<i>)+ud.y)
            call SetUnitX(ship<i>,x)
            call SetUnitY(ship<i>,y)
            if GetLocalPlayer() != Player(i) then
                set x=0.
                set y=0.
            endif
            call PanCameraToTimed(x,y,0.)
            call SetCameraRotateMode(x,y,Deg2Rad(270+GetUnitFacing(ship<i>)),0.)
            call SetCameraField(CAMERA_FIELD_TARGET_DISTANCE,3900.,0.)
            set i = i+1
        endloop
    endfunction
// =============================================================
    private function OnInit takes nothing returns nothing
        local trigger mov = CreateTrigger() //create a local for each trigger
        local trigger left = CreateTrigger()
        local trigger right = CreateTrigger()
        local trigger up = CreateTrigger()
        local trigger init = CreateTrigger()
        local integer i = 0
        loop
        exitwhen i == 5
            call TriggerRegisterPlayerEvent (left, Player (i), EVENT_PLAYER_ARROW_LEFT_DOWN) // add the arrow key events to the triggers
            call TriggerRegisterPlayerEvent (left, Player(i), EVENT_PLAYER_ARROW_LEFT_UP)
            call TriggerRegisterPlayerEvent (right, Player(i), EVENT_PLAYER_ARROW_RIGHT_DOWN)
            call TriggerRegisterPlayerEvent (right, Player(i), EVENT_PLAYER_ARROW_RIGHT_UP)
            call TriggerRegisterPlayerEvent (up, Player(i), EVENT_PLAYER_ARROW_UP_DOWN)
            call TriggerRegisterPlayerEvent (up, Player(i), EVENT_PLAYER_ARROW_UP_UP)
            set i = i+1
        endloop
        call TriggerRegisterTimerEvent(init,0,false)
        call TriggerRegisterTimerEvent(mov,0.0325,true)
        call TriggerAddAction( mov, function periodic )
        call TriggerAddAction( left, function pressl )
        call TriggerAddAction( right, function pressr )
        call TriggerAddAction( up, function pressu )
        call TriggerAddAction(init, function setglobals)
    endfunction

endscope</i></i></i></i></i></i></i></i></i></i></i></i></i></i></i></i>

/EDIT: Owned, you did it already

 

[Sevion]

Is your declaration trigger both public AND initialized above the use trigger?

 

[Dirac]

i guess not lol they don't work. When you mean they can used in another trigger you mean:
A.- Another scope in the same code
B.- Another scope in another code

 

[Laiev]

A and B is the same |: if you use other 'block of trigger' to trigger another scope or use the same 'block of trigger' to trigger another scope, they will be another scope no matter what

 

[Dirac]

i can't get the public globals (now with the public prefix) to work in another trigger, how do i initialize the scopes in the correct order?

Edit: nvm i just realized i have to type scopename_globalname in other scopes, however i wonder is there a way to change the order scopes initialize? or it's done by default depending on the code

 

[Rllulium]

Make a library:

library Movement initializer OnInit

Libraries are automatically put before scopes.
You can also specify a requirement, that will put the trigger after the requirement:

library Movement initializer OnInit requires ThatOtherLibrary

 

[Magthridon96]

I agree with Rllulium.

Using scopes is bad programming practice.
You can get away with making implicit requirements.

Also, it's much better to use module Initialization:

private module Init
    private static method onInit takes nothing returns nothing
        // init
    endmethod
endmodule
private struct Inits extends array
    implement Init
endstruct

Library initializers are horrible-
edit
-in some cases..

 

[tooltiperror]

>Using scopes is bad programming practice.
I have to agree.

>You can get away with making implicit requirements.
Again, I agree. Using a function from a library your library does not require should not be allowed. Blame Vexorian.

>Library initializers are horrible
Not if you're making a system like AIDS and need to use the library initializer.

 

[Dirac]

Using a function from a library your library does not require should not be allowed

im sorry, what?
where do i find a tutorial to learn implicit requirements and library creation