System Impale System

kingkingyyk3

Visitor (Welcome to the Jungle, Baby!)
Reaction score
216
Maybe some users want to use locations and there is no location use in the code except in the usable functions.
Locations are not recommended. You can see it in Jass help section, we recommend XY very hard.
Diffrence?
Destroying handles when they are running will cause handle stack corruption. GroupUtils simply recycles them. If you hate GroupUtils, use Recycle.
What?
XE is just making the thing hard.
Good or bad?
Does not follow the naming rules.
If you read it, you can see it saves the real that is in the hashtable h in I[Loop2] of Loop2 + (SquareRoot(height[Loop2]) * 2.00) / (airtime[Loop2] / INTERVAL). Why should it use arrays?
Why not just making it struct ?
 

Deaod

Member
Reaction score
6
Maybe some users want to use locations and there is no location use in the code except in the usable functions.
You dont need to support the madness of dumb users. Locations have exactly ONE use nowadays and this use is not applied in this script, or will be in any related script.

Diffrence?
Not recycling groups, thus leaking a good deal of data over time. Also, IIRC, there was a way to optimize the number of groups used. I think you could store all units affected by the stun into a single global group.

Instead of typing in "Abilities\\Spells\\Undead\\Impale\\ImpaleMissTarget.mdl" all the time they could just use SPIKE_SFX. Simple.
Thats not your problem. If its a default effect a user could somehow change, thatd be different. But then it wouldnt have to be a public constant.

Use resources already available, xe provides you with a dummy unit and other constants you might want to use.

Good or bad?
Bad.

Why should it use arrays?
Because you can store all units currently in the air inside a one-dimensional array. You also dont need to use groups to iterate over all units in mid-air.

How should I do it then?
Either find a library with a stack for such functions (the same applies to ShowUnit and PauseUnit), or avoid using those functions at all.

What references?
Unit references (local unit u).

Diffrence?
Room for one additional instance (though you will likely never reach the case where youll need it). Other than that, its bad style. Arrays start at 0.

What is wrong with the name it already has?
IMPS doesnt tell me what it does. Name it ImpaleTemplate or whatever and users reading requirements of spells or other libraries will know what it does.
Using public functions breaks the WC3 convention of not using underscores inside function names.

If you read the other posts, they say I should remove all BJs.
Yeah, i know. Its a load of bullshit. Why remove a BJ when you cant replace it with code that is more efficient (no, optimizing a function call is not something you should care about)? Plus, you lose a bit of readability because you replace a function called CountUnitsInGroup with something looking like this:
JASS:
        set bj_groupCountUnits = 0
        call ForGroup(G[Loop2],function CountUnits)
Tell me, what tells you more directly what that part of code does?

Maybe you're right, but I wanted to not be needed to use other systems.
Yeah, then dont write libraries, please. Libraries are meant to be used. Not to be avoided. Theres absolutely nothing bad about modularity or code reuse.
But that wasnt my main point. You could for example have used a dummy Storm Bolt ability and removed the stun buff after a certain time yourself. WAY better stunning.

Destroying handles when they are running will cause handle stack corruption. GroupUtils simply recycles them. If you hate GroupUtils, use Recycle.
No. Thats not it.
 

BloodySkullz

Active Member
Reaction score
10
There is an issue when you impale flying units, or units with fly height. They get stuck there. Other than that, it is very well done.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Monovertex Monovertex:
    Hmm, how do I change my signature?
  • tom_mai78101 tom_mai78101:
    Signatures can be edit in your account profile. As for the old stuffs, I'm thinking it's because Blizzard is now under Microsoft, and because of Microsoft Xbox going the way it is, it's dreadful.
  • The Helper The Helper:
    I am not big on the recipes I am just promoting them - I use the site as a practice place promoting stuff
    +2
  • Monovertex Monovertex:
    @tom_mai78101 I must be blind. If I go on my profile I don't see any area to edit the signature; If I go to account details (settings) I don't see any signature area either.
  • The Helper The Helper:
    You can get there if you click the bell icon (alerts) and choose preferences from the bottom, signature will be in the menu on the left there https://www.thehelper.net/account/preferences
  • The Helper The Helper:
    I think I need to split the Sci/Tech news forum into 2 one for Science and one for Tech but I am hating all the moving of posts I would have to do
  • The Helper The Helper:
    What is up Old Mountain Shadow?
  • The Helper The Helper:
    Happy Thursday!
    +1
  • Varine Varine:
    Crazy how much 3d printing has come in the last few years. Sad that it's not as easily modifiable though
  • Varine Varine:
    I bought an Ender 3 during the pandemic and tinkered with it all the time. Just bought a Sovol, not as easy. I'm trying to make it use a different nozzle because I have a fuck ton of Volcanos, and they use what is basically a modified volcano that is just a smidge longer, and almost every part on this thing needs to be redone to make it work
  • Varine Varine:
    Luckily I have a 3d printer for that, I guess. But it's ridiculous. The regular volcanos are 21mm, these Sovol versions are about 23.5mm
  • Varine Varine:
    So, 2.5mm longer. But the thing that measures the bed is about 1.5mm above the nozzle, so if I swap it with a volcano then I'm 1mm behind it. So cool, new bracket to swap that, but THEN the fan shroud to direct air at the part is ALSO going to be .5mm to low, and so I need to redo that, but by doing that it is a little bit off where it should be blowing and it's throwing it at the heating block instead of the part, and fuck man
  • Varine Varine:
    I didn't realize they designed this entire thing to NOT be modded. I would have just got a fucking Bambu if I knew that, the whole point was I could fuck with this. And no one else makes shit for Sovol so I have to go through them, and they have... interesting pricing models. So I have a new extruder altogether that I'm taking apart and going to just design a whole new one to use my nozzles. Dumb design.
  • Varine Varine:
    Can't just buy a new heatblock, you need to get a whole hotend - so block, heater cartridge, thermistor, heatbreak, and nozzle. And they put this fucking paste in there so I can't take the thermistor or cartridge out with any ease, that's 30 dollars. Or you can get the whole extrudor with the direct driver AND that heatblock for like 50, but you still can't get any of it to come apart
  • Varine Varine:
    Partsbuilt has individual parts I found but they're expensive. I think I can get bits swapped around and make this work with generic shit though
  • Ghan Ghan:
    Heard Houston got hit pretty bad by storms last night. Hope all is well with TH.
  • The Helper The Helper:
    Power back on finally - all is good here no damage
    +2
  • V-SNES V-SNES:
    Happy Friday!
    +1
  • The Helper The Helper:
    New recipe is another summer dessert Berry and Peach Cheesecake - https://www.thehelper.net/threads/recipe-berry-and-peach-cheesecake.194169/
  • The Helper The Helper:
    I think we need to add something to the bottom of the front page that shows the Headline News forum that has a link to go to the News Forum Index so people can see there is more news. Do you guys see what I am saying, lets say you read all the articles on the front page and you get to the end and it just ends, no kind of link for MOAR!
  • The Helper The Helper:
    Happy Wednesday!
    +1

      The Helper Discord

      Members online

      No members online now.

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top