Is there a downside to inlining conditions?

afisakov

You can change this now in User CP.
I have seen some maps that write functions in this form
Code:
function Trig_kongzhi_Func005C takes nothing returns boolean
if(not(GetUnitTypeId(GetTriggerUnit())=='ndqp'))then
        return false
    endif
    return true
endfunction
 
function Trig_kongzhi_Func006C takes nothing returns boolean
if(not(GetUnitTypeId(GetTriggerUnit())=='ndqs'))then
        return false
    endif
    return true
endfunction
 
function Trig_kongzhi takes nothing returns nothing
if Trig_kongzhi_Func005C() then
do something
endif
if Trig_kongzhi_Func006C() then
do something else
endif
...
I am tempted to write it like this instead
Code:
function Trig_kongzhi takes nothing returns nothing
if (GetUnitTypeId(GetTriggerUnit())=='ndqp')then
do something
endif
if (GetUnitTypeId(GetTriggerUnit())=='ndqs') then
do something else
endif
...
I have no doubt that the second approach saves space, but I am wondering if it somehow slows down the execution. Otherwise I don't know why the first would be used except that is how game translates it from GUI.
Are there any advantages to the first approach or should I switch to the second (conditions written inside the function that uses them)?
 

cyb3rhack-r

New Member
The former executes faster than the latter because it doesn't call other functions. The former wasn't through Jass. It was preset upon converting GUI into custom text.
 

afisakov

You can change this now in User CP.
The former executes faster than the latter because it doesn't call other functions
Wait, I thought the former means the first, and it does call on the other (boolean) functions? Or is that not what u meant by calling other functions.

Do you mean that the longer way of writing it executes faster? The one made from gui conversion?
 

dracolich

TH.net Regular
its not a "some map", its GUI version of jass.
everytime you start to GUI something with conditions, theyre will be exported like those functions.
of course, in-lining is faster, cause function call still takes some time
 

afisakov

You can change this now in User CP.
its not a "some map", its GUI version of jass.
everytime you start to GUI something with conditions, theyre will be exported like those functions.
of course, in-lining is faster, cause function call still takes some time
ok, good, so the shorter way of writing it also works faster, that makes my life much easier.
also results in code that is easier to read :)
 

dracolich

TH.net Regular
well, in-lining not so useful for one-time called function, cause its still only 1 another function call.
but yeah, inlined code easier to read
 

afisakov

You can change this now in User CP.
well, in-lining not so useful for one-time called function, cause its still only 1 another function call.
but yeah, inlined code easier to read
thanks. Even if speed difference is minor, it takes less space and is easier to read, so as long as it isn't slower it seems a much better choice.

The reason I was asking is I open alot of unprotected maps (and some protected ones) to learn from them, and I was wondering if there was a reason they wrote the code that way. Now I know it was just an artifact from using gui and I can safely change it.
 

Tyrulan

Ultra Cool Member
The advantage of writing a separate boolean function can be for reuse and recycling. The compiler will not duplicate code if there is a boolean function, thus the map will load faster. It does slow down the execution, but the difference is so negligible that it doesn't matter.

If later, your boolean logic needed to change, you could simply edit the function. It's also a stylistic or organizational choice.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Ghan Ghan:
    Seeing J4L is definitely a blast from the past.
  • Jesus4Lyf Jesus4Lyf:
    Oh hey Ghan! Long time. :)
    +1
  • jonas jonas:
    J4L! What has happened in your life
  • Jesus4Lyf Jesus4Lyf:
    Hmm, how to summarize... Moved to the USA and got married. Became a professional software engineer and solution lead. Learning Godot for game dev. :)
  • jonas jonas:
    So you are pursuing game dev as a hobby? What industry is your dayjob in?
  • jonas jonas:
    FAANG?
  • Jesus4Lyf Jesus4Lyf:
    Not quite FAANG, less pay for a less hours/stress. Yeah, game dev as a hobby.
  • jonas jonas:
    makes sense. Do we have a hobby game dev subforum to showcase some work?
  • Blackveiled Blackveiled:
    Happy Thursday
    +1
  • The Helper The Helper:
    Happy Thursday!
  • The Helper The Helper:
    TGIF!
  • The Helper The Helper:
    hey tom_mai please do not archive anymore news
  • Ghan Ghan:
    AMD Ryzen 7000 next week :D
    +1
  • The Helper The Helper:
    noice!
  • tom_mai78101 tom_mai78101:
    "hey tom_mai please do not archive anymore news" ----> Got it. What should we do with the "News Archive" subforum?
  • The Helper The Helper:
    I think leave it for real old news that cannot be sorted the reason we had it in the first place was a server issue that we do not have anymore. I don't want to get rid of the archive just not put anything in it for now until we figure it out more
  • The Helper The Helper:
    The side chat has nothing on the discord. it is not possible but the biggest thing on my wish list right now is a sidechat channel on the disord that hooks up to this...
  • Ghan Ghan:
    I've been selected for the Diablo IV beta.
    +1
  • Ghan Ghan:
    Woo!
    +1
  • The Helper The Helper:
    that is so cool
  • V-SNES V-SNES:
    Eh just noticed the new discord section on the side. Looks great!
    +1
  • Blackveiled Blackveiled:
    :( feels bad I can't ever get selected for any beta I sign up for. It's annoying as heck.
    +1
  • The Helper The Helper:
    Hello mgarcia! Happy Monday everyone!

    The Helper Discord

    Members online

    Affiliates

    Hive Workshop NUON Dome World Editor Tutorials

    Network Sponsors

    Apex Steel Pipe - Buys and sells Steel Pipe.
    Top