Is there an easy way to detect if an attack hits?

[afisakov]

I was making an ability that does bonus damage based on char agility (triggered crit) but ran into a problem that it seems to still activate even if main hit misses.
How do I make a triggered crit that takes into account unit evasion?
I don't want this ability to still activate on missed attacks and don't know how to fix it.

 

[dracolich]

when skill learned and this is not an illusion then create trigger which register any unit attacked

when unit attacked and attacker have ability then create trigger which register damage event on attacked_unit or for 2 secs

if damage event source == unit_with_ability then
something
destroy trigger
endif
if timeisover then
destroytrigger
endif

of course, damage register is dynamic trigger, so JASS in action

 

[afisakov]

when skill learned and this is not an illusion then create trigger which register any unit attacked

when unit attacked and attacker have ability then create trigger which register damage event on attacked_unit or for 2 secs

if damage event source == unit_with_ability then
something
destroy trigger
endif
if timeisover then
destroytrigger
endif

of course, damage register is dynamic trigger, so JASS in action

Is there a way to do this without dynamic triggers?
This is supposed to take place inside an arena so both units are easily defined when the arena starts and I tried to make it that way, but don't really know what I'm doing since I never used this event before.
Can you tell me where I went wrong?

    trigger                udg_triggerar              = null
    location                tp1                = null   
...
function arenasetup (already working, only partially included here)
set udg_units17[9]=GetTriggerUnit()
set udg_units17[10]=GetLastCreatedUnit()
...
function Trig_arena50_Conditions takes nothing returns boolean
    return (GetTriggerUnit()==udg_units17[9])
endfunction
function Trig_arena50_Actions takes nothing returns nothing
    set hitter=udg_units17[10]
    set target=udg_units17[9]
    set fint1=rcount(target)
    set dx=I2R((GetHeroStatBJ(bj_HEROSTAT_STR,hitter,true)+GetHeroStatBJ(bj_HEROSTAT_AGI,hitter,true)+GetHeroStatBJ(bj_HEROSTAT_INT,hitter,true))*(8-fint1))/120.
    if(GetRandomInt(1,3)==1)then
        call UnitDamageTargetBJ(hitter,target,dx,ATTACK_TYPE_CHAOS,DAMAGE_TYPE_MAGIC)
        set tp1=GetUnitLoc(target)
        call AddSpecialEffectLocBJ(tp1,"Abilities\\Spells\\Human\\DispelMagic\\DispelMagicTarget.mdl")
        call DestroyEffect(GetLastCreatedEffectBJ())
        call RemoveLocation (tp1)
    endif
endfunction
...
    set udg_triggerar=CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(udg_triggerar,EVENT_UNIT_DAMAGED)
    call TriggerAddCondition(udg_trigger143,Condition(function Trig_arena50_Conditions))
    call TriggerAddAction(udg_triggerar,function Trig_arena50_Actions)

When I try to test in in Jasscraft it tells me "cannot convert unitevent to playerunitevent" but I do not know how to fix it or what that really means, except that I am not using the event correctly somehow

 

[dracolich]

cause there are NO event UNIT_DAMAGED for all units, only for specified.
try to find some jasser which would make pure jass-code better.
or you could use some kind of custom GUI, but since i use it about 3 years ago, cant help here