Jass Help

N

NetherHawk

New Member
Reaction score
26
Ok i know its old - fashioned and out of date to use kattana handle vars but i'm having some problems. My trigger does not fire all the time even if i set the random integer thingy to be 100%.

JASS:
function AutoFire_Jass_Conditions takes nothing returns boolean
    return GetSpellAbilityId() == 'B00X' // autofire buff
endfunction

function AutoFire_Attacker takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    return GetAttacker() == u // to check if the attacking unit is still the same? could this be the problem?
endfunction

function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    return b1 and b2 and b3 and b4
endfunction

function AutoFire_Attack takes nothing returns nothing
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,"attacker")
    local unit ux = GetHandleUnit(tr,"target")
    local location ul = GetUnitLoc(u)    
    local unit d = CreateUnit( GetOwningPlayer(u), 'n005',GetLocationX(ul),GetLocationY(ul), bj_UNIT_FACING ) // create dummy to attack
    local group g = CreateGroup()
    
    
    call SetUnitPathing(d,false)    
    
    call SetHandleHandle(tr,"attacker",u)
    
    call SetUnitAbilityLevel(d,'A01C',GetUnitAbilityLevel(u,'A01D') )
    set g = GetUnitsInRangeOfLocMatching(600,ul, Condition(function AutoFireGroup_Conditions))  
    call GetRandomSubGroup(1, g)  // i doubt its cuz of no units in the group cuz the map i use has plenty of units surrounding the hero
    call UnitApplyTimedLifeBJ( 1.00, 'BTLF', d)
    call SetUnitAnimation( u, "spell" )             
    call IssueTargetOrderBJ( d, "attackonce", ux)
    call UnitAddAbility(d, 'Aloc')
    
    call DisableTrigger(tr)
    call FlushHandleLocals(tr)
    call DestroyTrigger(tr) 
    call GroupClear(g)
    call DestroyGroup(g)
    set u = null
    set ux = null
    call RemoveLocation(ul)     
    set d = null  
endfunction



function AutoFire_Jass_Actions takes nothing returns nothing
    local unit u = GetAttacker()
    local unit ux = GetAttackedUnitBJ()       
    local trigger tr = CreateTrigger()
    
    if  GetRandomInt(1, 100) <= 100 then // the 100% thing
    //if  GetRandomInt(1, 100) <= (20 + (5*(GetUnitAbilityLevel(u,'A01D')))) then //A01D spell id
            call SetHandleHandle(tr,"attacker",u)    
            call TriggerRegisterUnitEvent(tr,ux,EVENT_UNIT_DAMAGED) // to get when unit is damaged instead of the abuse attack thing 
            call TriggerAddCondition(tr, Condition( function AutoFire_Attacker ) )
            call TriggerAddAction(tr , function AutoFire_Attack)
                                                                              
            call SetHandleHandle(tr,"attacker",u)
            call SetHandleHandle(tr,"target",ux)
        else
    endif     
endfunction

//===========================================================================
function InitTrig_Auto_Fire_Jass takes nothing returns nothing
    set gg_trg_Auto_Fire_Jass = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Auto_Fire_Jass, EVENT_PLAYER_UNIT_ATTACKED )
    call TriggerAddCondition( gg_trg_Auto_Fire_Jass, Condition( function AutoFire_Jass_Conditions ) )
    call TriggerAddAction( gg_trg_Auto_Fire_Jass, function AutoFire_Jass_Actions )
endfunction



several stuff i have done to try to find out the problem is, removing the locust thing, removing the AutoFireGroup_Conditions .
 
cr4xzZz

cr4xzZz

Also known as azwraith_ftL.
Reaction score
51
You are back? Dude I missed you (you still remember me, don't you? xD)...

I suggest you forget all these handle variables and learn vJASS - you can find everything in the Tutorial Repository. It's an extension of JASS so you may find a lot of useful things when using it.
http://www.thehelper.net/forums/showthread.php?t=80241&highlight=vJASS I know it's GUI to JASS but it has some common syntax used in vJASS (nothing special, just cleaner code).
http://www.thehelper.net/forums/showthread.php?t=79426 Basic usage of structs in vJASS.
 
N

NetherHawk

New Member
Reaction score
26
off topic: ahaha yeah .. x.x i lent someone my cd and then reformatted my com so i dint have wc3 with me for a vry long time >.<!

i know who to use structs but in the end u still use handle vars/cs-system/abc to attach? so whats the diff? this part i dont understand. what are methods for? =x

on topic: asides from my method, what is the problem with the coding?
 
chobibo

chobibo

Level 1 Crypt Lord
Reaction score
48
Welcome back dude, I hope you enjoy your stay lol.

many leaks. example:
JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    return b1 and b2 and b3 and b4
endfunction


null local variables after using them, warcraft's handle Id recycler won't recycle the handle Id's if a local pointing to a handle is not released.
JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    local boolean b1 = IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == true
    local boolean b2 = IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == false
    local boolean b3 = IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == false
    local boolean b4 = IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == false
    set tr=null
    set u=null
    return b1 and b2 and b3 and b4
endfunction


some BJ's are causing execution slowdown, some not all:
JASS:
GetAttackedUnitBJ()

from the Event "A unit is attacked" so:
JASS:
GetTriggerUnit()
 
Viikuna

Viikuna

No Marlo no game.
Reaction score
265
Handle Vars are outdated these days because they say that I2H is dangerous and can cause some weird bugs.

Structs are integers so you can safely use Handle Vars with structs.

just use SetHandleInt and GetHandleInt.

They also say that destroying triggers is dangerous, so you should maybe try to make that spell without dynamic triggers.
 
darkbeer

darkbeer

Beer is Good!
Reaction score
84
just a hint you can easily use a loop to avoid making 4 booleans:

JASS:
function AutoFireGroup_Conditions takes nothing returns boolean
    local trigger tr = GetTriggeringTrigger()
    local unit u = GetHandleUnit(tr,&quot;attacker&quot;)
    loop
        exitwhen IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) == false
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) == true
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) == true
        exitwhen IsUnitType(GetFilterUnit(), UNIT_TYPE_DEAD) == true
        set tr=null
         set u=null
        return true
    endloop
    set tr=null
    set u=null
    return false
endfunction
 
E

emjlr3

Change can be a good thing
Reaction score
395
wtf do you need a loop for...

JASS:
return IsUnitEnemy(GetFilterUnit(), GetOwningPlayer(u)) and not IsUnitType(GetFilterUnit(), UNIT_TYPE_MAGIC_IMMUNE) and not IsUnitType(GetFilterUnit(), UNIT_TYPE_STRUCTURE) and GetWidgetLife(GetFilterUnit())&gt;.405


JASS:
GetSpellAbilityId() == &#039;B00X&#039; // autofire buff


will never return true because its firing off the attack event not spell cast/effect/etc. event

you want to check if:

JASS:
GetUnitAbilityLevel(GetAttacker(),&#039;XXXX&#039;)&gt;0


the attacker has the auto fire ability
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    How can you tell the difference between real traffic and indexing or AI generation bots?
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/

      The Helper Discord

      Members online

      No members online now.
      Online now:
      452 (members: 0, guests: 452)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top