Jass Script Help

[The_Prophet]

ok im not sure how many of you know jass, but i guess it doesnt hurt to ask. Im not quite sure how to use the actions "call toforce" and set function parameters. Im pretty sure im making some stupid mistake, and any help would be appreciate. the error im getting in the quoted lines are "expected ' "

the line thats getting the error is below:

call ForForce( udg_Alliance, function random_hero (gg_rct_Allied_Region_Selection))

since i know you usually call a function by saying

call function_name(set_parameters_here, along_with_more_parameters)

i tried making the line look like this:

call ForForce( udg_Alliance, random_hero (gg_rct_Allied_Region_Selection))

It doesnt give an error line on this line but then on the very next line, (no matter whats on that line) it gives the error invalid argument type (void)

 

[mems]

you cannot give arguments to functions which will be runned in ForForce functions

i mean function random_hero (gg_rct_Allied_Region_Selection) is wrong ForForce function uses global variables so you cannot give it another variable

but people use a tricky style for pick all unit or pick all players
here is an example for picking units:
We use loop instead of this function which also enables waiting times on picking units and doing actions. Trick is we take the units 1 by 1 and in a group and doing actions

local group UnitGroup = Your group here
local unit PickedUnit = FirstOfGroup(UnitGroup)//We must assign a value to this if not, PickedUnit will null and loop will never start 

loop
    exitwhen PickedUnit==null
    set PickedUnit = FirstOfGroup(UnitGroup)//takes first unit in a group
    call GroupRemoveUnit(UnitGroup,PickedUnit) remove this unit from group
    //do your actions here
endloop

call DestroyGroup(UnitGroup)//need to care about memorial leaks

Each time you take 1 unit from unit group and remove it so everytime first of group will be different and when there is no unit remains it will be null so u dont need to nullify the picked unit for memorial leaks

 

[xPheRe]

call ForForce( udg_Alliance, function random_hero (gg_rct_Allied_Region_Selection))

Callback functions doesn't allow parameters.
If random_hero function needs somewhere a rect as a parameter, you should create a global rect variable, call it for example rRandomHero, then use something like this

function random_hero takes nothing returns nothing
    // Change your references from parameters to the related globals)
    // In this case udg_rRandomHero
endfunction
...

set udg_rRandomHero = gg_rct_Allied_Region_Selection
call ForForce(udg_Alliance, function random_hero)

 

[Vexorian]

You can use a loop with an integer from 0 to 15 and you affect all the players.

I would always replace ForForce with a kind of for loop since it is easier, you don't have to destroy anything, you can use locals, you don't have to use an extra function, and I actually think it is more efficient.

 local integer a=0
    loop
         exitwhen (a>15)
         if (Player(a) matches conditions) then
                 do stuff for Player(a)
         endif
         set a=a+1
    endloop

 

[The_Prophet]

Thanks for the help everyone, especially Vexorian. That proved really helpful.