Jass scripts

[Bananskral]

All right, heres the deal. I copied a JASS Script looking like this

Revive Hero
Events
Unit - A unit Dies
Conditions
((Triggering unit) is A Hero) Equal to True
Actions
Custom script: local timerdialog WINDOW
Custom script: local integer HEROWAIT
Custom script: local timer OURTIMER
Custom script: local unit OURHERO
Custom script: set OURHERO = GetDyingUnit()
Custom script: set HEROWAIT = ( GetHeroLevel(OURHERO) * 5 )
Custom script: set OURTIMER = CreateTimer()
Custom script: call StartTimerBJ( OURTIMER, false, ( I2R(HEROWAIT) ))
Custom script: call CreateTimerDialogBJ( OURTIMER, GetPlayerName(GetOwningPlayer(OURHERO)) )
Custom script: set WINDOW = GetLastCreatedTimerDialogBJ()
Custom script: call TimerDialogDisplayForPlayerBJ( true, WINDOW, GetOwningPlayer(OURHERO) )
Custom script: call PolledWait( HEROWAIT )
Custom script: call ReviveHeroLoc(OURHERO, GetRectCenter(GetPlayableMapRect()), true )
Custom script: call PanCameraToTimedLocForPlayer( GetOwningPlayer(OURHERO), GetUnitLoc(OURHERO), 0.60 )
Custom script: call DestroyTimerDialog(WINDOW)

I want to make the heroes revive at each their start location and not in the center of the map. I changed this line:
Custom script: call ReviveHeroLoc(OURHERO, GetRectCenter(GetPlayableMapRect()), true )

To:
Custom script: call ReviveHeroLoc(OURHERO, GetRectCenter(GetPlayerStartLocRect()), true )

It just doesnt work. Please post me it, so i can use it as it is. I really need it.

 

[DDRtists]

why dont you not use jass, would be easyer...

 

[The_Prophet]

you have to specify start location you want. Use this:

GetPlayerStartLocationLoc takes player whichPlayer returns location

So yours might look like

call ReviveHeroLoc(OURHERO, GetPlayerStartLocationLoc(GetOwningPlayer(OURHERO)), true )

And to DDRtists. Using a JASS revive trigger makes it easier to make multi instanceable. And anyways, once you get fast at JASS, it's faster to use than gui by leaps and bounds.

 

[phyrex1an]

Custom script: call ReviveHeroLoc(OURHERO, GetRectCenter(GetPlayerStartLocRect()), true ).

Congrats, I think that was one of the best guesses on what it could be I ever seen.

Change it to this and you will get it right:

Custom script: call ReviveHeroLoc(OURHERO, GetPlayerStartLocation(GetOwningPlayer(OURHERO)), true)

The reson on using jass on this is that you can have a longer revive timer than you can with a somewhat equal GUI trigger. In a GUI trigger this will eather be not multi instance or bugged with times over ~80.

Edit:
Prophet why do you have to edit ^^. Use wichever you want both works even if they are slighty different. (My uses the native directly and prophets uses the blizzard.j function, wich means that blizzard is :nuts: )

 

[Bananskral]

another jass problem

thank you, it worked, at least it didnt report failure. now its the secondlast line.

call PanCameraToTimedLocForPlayer( GetOwningPlayer(OURHERO), GetUnitLoc(OURHERO), 0.60 )

You can also see it in the start of the thread.
it says: Invalid argument type (integer)

wtf is wrong? i ´copied it from a trigger on the free thread part, and it just sucks. stinky...... please help