Leaderboard: Wont Add to Score

[Arigatou]

Ok, I followed the leaderboard tutorial. (Just changed event from "allied unit of player 1" dying to "unit controlled by player 1, 2, 3, etc dying").

Now then, the leaderboard is created fine. However, the scores never increase.
I opened other maps like mine, and my score adding triggers appear the same.

How my map works is that you should gain 1 point by killing a unit controlled by another player. All players are allied, so that you must click to attack, like in snipers and paintball maps.

My Leaderboard Trigger:

Events: Game time = 5secs

Actions
Leaderboard - Create a leaderboard for (All players) titled PWNAGE
Custom script: set bj_wantDestroyGroup=true
Player Group - Pick every player in (All players) and do (Actions)
Loop - Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
((Picked player) controller) Equal to User
((Picked player) slot status) Equal to Is playing
Then - Actions
Leaderboard - Add (Picked player) to (Last created leaderboard) with label (Name of (Picked player)) and value 0
Else - Actions
Do nothing
Leaderboard - Show (Last created leaderboard)


And here is the trigger for adding score:

Events
Unit - A unit owned by Player 1 (Red) Dies
Unit - A unit owned by Player 2 (Blue) Dies
Unit - A unit owned by Player 3 (Teal) Dies
Unit - A unit owned by Player 4 (Purple) Dies
Unit - A unit owned by Player 5 (Yellow) Dies
Unit - A unit owned by Player 6 (Orange) Dies
Unit - A unit owned by Player 7 (Green) Dies
Unit - A unit owned by Player 8 (Pink) Dies
Actions
Set Pwnage[(Player number of (Owner of (Killing unit)))] = Pwnage[((Player number of (Owner of (Killing unit))) + 1)]
Leaderboard - Change the value for (Owner of (Killing unit)) in (Last created leaderboard) to Pwnage[(Player number of (Owner of (Killing unit)))]
Leaderboard - Sort (Last created leaderboard) by Value in Descending order


ANY HELP APPRECIATED! My map is done once this damn thing works! Thanks SO MUCH!

 

[guitarplay]

here is mine compare tehm cause i had problems also but mine works now

Update Leaderboard
Events
Unit - A unit owned by Player 1 (Red) Dies
Unit - A unit owned by Player 2 (Blue) Dies
Unit - A unit owned by Player 3 (Teal) Dies
Unit - A unit owned by Player 4 (Purple) Dies
Unit - A unit owned by Player 5 (Yellow) Dies
Unit - A unit owned by Player 6 (Orange) Dies
Conditions
(Owner of (Triggering unit)) Not equal to (Owner of (Killing unit))
Actions
If ((Owner of (Killing unit)) Equal to Player 1 (Red)) then do (Set playerkills[(Player number of Player 1 (Red))] = (playerkills[(Player number of Player 1 (Red))] + 1)) else do (Do nothing)
If ((Owner of (Killing unit)) Equal to Player 2 (Blue)) then do (Set playerkills[(Player number of Player 2 (Blue))] = (playerkills[(Player number of Player 2 (Blue))] + 1)) else do (Do nothing)
If ((Owner of (Killing unit)) Equal to Player 3 (Teal)) then do (Set playerkills[(Player number of Player 3 (Teal))] = (playerkills[(Player number of Player 3 (Teal))] + 1)) else do (Do nothing)
If ((Owner of (Killing unit)) Equal to Player 4 (Purple)) then do (Set playerkills[(Player number of Player 4 (Purple))] = (playerkills[(Player number of Player 4 (Purple))] + 1)) else do (Do nothing)
If ((Owner of (Killing unit)) Equal to Player 5 (Yellow)) then do (Set playerkills[(Player number of Player 5 (Yellow))] = (playerkills[(Player number of Player 5 (Yellow))] + 1)) else do (Do nothing)
If ((Owner of (Killing unit)) Equal to Player 6 (Orange)) then do (Set playerkills[(Player number of Player 6 (Orange))] = (playerkills[(Player number of Player 6 (Orange))] + 1)) else do (Do nothing)
Leaderboard - Change the value for (Owner of (Killing unit)) in (Last created leaderboard) to playerkills[(Player number of (Owner of (Killing unit)))]
Leaderboard - Sort (Last created leaderboard) by Value in Descending order

that should work for u and there is a preety obvius difference

 

[Korolen]

Your problem is that you have:

 Set Pwnage[(Player number of (Owner of (Killing unit)))] = Pwnage[((Player number of (Owner of (Killing unit))) + 1)]

and not:

 Set Pwnage[(Player number of (Owner of (Killing unit)))] = Pwnage[((Player number of (Owner of (Killing unit))))] + 1

That should help, athough I canot help but commment that it would be alot more efficiant in JASS, as you could store "((Player number of (Owner of (Killing unit))))" into a local variable, and do a few other things to tidy things up.

PS: Put your code in [ CODE][/CODE ] tags.

 

[Arigatou]

here is mine compare tehm cause i had problems also but mine works now



that should work for u and there is a preety obvius difference

I put that in, and STILL the leaderboard will not update!

 

[emjlr3]

scratch what i said i duno

 

[Heptameron]

I put that in, and STILL the leaderboard will not update!

Listen to Korolen. Look at this:

Pwnage[((Player number of (Owner of (Killing unit))) + 1)]​

Let's say Player 3 killed a unit. Owner of Killing unit is Player 3. Player number of Player 3 is three. 3 + 1 is 4. So that comes out to:

Pwnage[4]​

Which is player four's kills. So it ends up:

Pwnage[3] = Pwnage[4]​

Instead of what you want:

Pwnage[3] = (Pwnage[3] + 1)​

See the difference?

 

[guitarplay]

i see what u mean but my leaderboard works perfectly fine and all??
mine should work for him, but for some reasons the ones is used before taht one had trouble even though they worked in the other maps