Little problem with a variable

Magoiche

Member
Well i made this simple jass trigger.
When a unit get the spell it do the defend animation tag, realy simple.

But i tried to do it in JASS but i got one error in the syntax cheker on JASScraft.

JASS:
function Conditions takes nothing returns boolean
    if ( GetLearnedSkill() == 'A000' ) then
        return true
    endif
        return false
endfunction

function Actions takes nothing returns nothing
    call AddUnitAnimationProperties( GetTriggerUnit(), "defend", true )
endfunction

function Events takes nothing returns nothing
    set gg_trg_Events = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Events, EVENT_PLAYER_HERO_SKILL )
    call TriggerAddCondition( gg_trg_Events, Condition( function Conditions ) )
    call TriggerAddAction( gg_trg_Events, function Actions )
endfunction


The error is: Undeclared variable: gg_trg_Events Line 14

Whats wrong with that? Its the same if i convert a trigger from GUI to JASS but in the 2 cases it gave me this error. Why? T.T


Quick Questions:

1. call TriggerAddCondition and call TriggerAddAction what they do? I know it add condition and actions but... Its like the Events function will run the condition then if its true it will run the action? or something like that?

2. set gg_trg_Events = CreateTrigger(). What this line do? I know it create a trigger but... It can be in a variable? Maybe the cause of the error its because i dont have a global/local variable?

Thanks for now on =P
 

Larcenist

REP: Respect, Envy, Prosperity?
JASS:
function Events takes nothing returns nothing


Change that into

JASS:
function InitTrig_Events takes nothing returns nothing


> 1. call TriggerAddCondition and call TriggerAddAction what they do? I know it add condition and actions but... Its like the Events function will run the condition then if its true it will run the action? or something like that?

Pretty much yeah.

> 2. set gg_trg_Events = CreateTrigger(). What this line do? I know it create a trigger but... It can be in a variable? Maybe the cause of the error its because i dont have a global/local variable?


gg_trg_ is a global variable. Though when you code normally you usually find it easier to use "local trigger t = CreateTrigger()" since it doesn't require you to use the gg_trg_Trigger_Name variable but simply "t" instead.
 

Magoiche

Member
That was.... Fast i.i

Thanks the error is gone but.

Some questions still are in the air x.x

The InitTrig_ indicates that this is the firts triggger to run?

And the trigger dont have error but it wont work i.i

JASS:
function Conditions takes nothing returns boolean     
    if ( GetLearnedSkill() == 'A002' ) then
        return true
    else
        return false
    endif         
endfunction

function Actions takes nothing returns nothing
    call AddUnitAnimationProperties( GetTriggerUnit(), "defend", true )
endfunction

function InitTrig_Events takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ( t, EVENT_PLAYER_HERO_SKILL )
    call TriggerAddCondition( t, Condition( function Conditions ) )
    call TriggerAddAction( t, function Actions )
endfunction


Why? i.i
 

Larcenist

REP: Respect, Envy, Prosperity?
InitTrig_xxxx indicates that this is the init function of the trigger, in spells and such you add events, conditions and actions here as well as creating the trigger.

Try adding this:

JASS:
call BJDebugMsg("Test")


In your actions function to see if it runs or not.
 

Magoiche

Member
@Larcenist

It do not worked =X

@Ryuu

No. Because if the spell its the A002 it will run the trigger if not i will do nothing.
 

Troll-Brain

You can change this now in User CP.
If you use the official editor your InitFunction must be named like that :
InitTrig_TriggerName.

But, meh, if you are a windows user, just use the last JassNewGenPack ...

JASS:
scope NewScope initializer init

private function Conditions takes nothing returns boolean
   // your conditions and return
endfunction

private function Actions takes nothing returns nothing
   // your stuff
endfunction

public function init takes nothing returns nothing
   local trigger trig = CreateTrigger()
   // register your event(s)
   call TriggerAddAction(trig,function Actions)
   call TriggerAddCondition(trig,Condition(function Conditions))
endfunction

endscope


If you need to set the trigger to a global you can put a global/englobals block in your scope.
 

Magoiche

Member
@T.s.e

It do no worked i.i


@Troll-Brain

I use new gen. But i liked the Jasscraft i.i.
Anyway...

This is vJass right?
Let's see.

scope/endscope - don't know what this do.

private/public - private its a function only used in that trigger? public used on every? something like that?

global/endgloblas - what that thing do? its to set a global variable in the trigger?


EDIT:

I found the problem!
InitTrig_xxx!!! The xxx must be the name of the trigger x.x what a dumb i am xD.
Also i noticed that in vJass i dont have to put InitTrig_xxx because the scope say where to begin... right?

Anyway if someone can to explain the things above i apreciate it i.i
 

WarLuvr3393

Hmmm...too many things to play (WoW, COD4, WC3)
Scopes are kind of like sections in your map script that don't necessarily get declared first like libraries; they're more like a section where the scripts/variables are independent from the rest of the script, or at least that's what I've seen.

Scopes are used mostly in spells because all you have to do is copy and paste it and because everything in those scripts have the "private" tag, you won't have to worry about re-declaring variables.
 

Magoiche

Member
Let's see...

Scopes - Sections of indepent scripts/variables
Private - It means that i dont need to re-declare the variables in same scope? (Not sure)
Public - I don't have a clue i.i
 

Troll-Brain

You can change this now in User CP.
Reading the jasshelper manual should help you.
It is in the folder jasshelper of your JNGP.

private : you can use it in the scope/library/struct and so one ..., but not outside the block code.
public : you can use it outside the bloc code.

I personnaly always use public for the initializer functions, in case of i need to manage the order of the differents inits.
 
General chit-chat
Help Users
  • No one is chatting at the moment.
  • tom_mai78101 tom_mai78101:
    Would like to get some annual forum statistics report.
  • The Helper The Helper:
    there are stats in the xenforo forum admin section and we have matomo stats we started collecting beginning of the year so we will not have annual on that until next year
  • The Helper The Helper:
    I thought you had keys to the bathroom Tom? Ghan does Tom have access to the stats thread in the bathroom
  • The Helper The Helper:
    since I started jacking with the bots on the site we doubled our page views on the site in a week lol
  • The Helper The Helper:
    I have been having lots of fun
  • The Helper The Helper:
    we have had like 6000 views of the American Airlines economy class thread in the last week
  • The Helper The Helper:
    I ought to stick a travel affiliate link or something on that page to try and monetize that they are just going there and leaving it might even be bots I am not sure
  • The Helper The Helper:
    I just got into it with the Atari VCS Facebook Moderator I started trolling him and almost got banned
  • The Helper The Helper:
    They deleted one of my posts one time so I was trolling him on a help post I put up because I am evil I guess and bored and the guy handled it well I loved his attitude Atari has a good social media presence even if they do not have many games.
  • The Helper The Helper:
    The French Atari they call them even though they are like totally based in America they just have French Money coming in. Gotta love it
  • Ghan Ghan:
    Microsoft buying Activision Blizzard holy crap!
  • The Helper The Helper:
    I know right holy cow
  • Accname Accname:
    Thats not going to save it.
  • The Helper The Helper:
    It might
  • The Helper The Helper:
    They are going to use alot of that IP in the Metaverse
  • The Helper The Helper:
    I found a new section of the stats that is freaking interesting!
  • The Helper The Helper:
    oh yeah this is what I was looking for good job matomo! These are some sweet stats I am learning the interface on it too!
  • The Helper The Helper:
    If anyone ever asks later how I found out about it was watching the site bots but not watching what they were doing but asking myself why they were here?
  • The Helper The Helper:
    there must be a reason and ok that is it
  • The Helper The Helper:
    the past and the future all come together into one
  • The Helper The Helper:
    the search engines are what built thehelper.net the search engines will make it big again maybe
  • The Helper The Helper:
    the real question is are 5 million links better than 60 real good links?
  • The Helper The Helper:
    the answer is 60 lol
  • The Helper The Helper:
    unless you put 100k links on it lol then you get something

    Members online

    No members online now.

    Affiliates

    Hive Workshop NUON Dome
    Top