Mind control spell, changing owner ship back after spells over

[sunshinex3]

i have this working so far i just need ideas on how to finish it.

these triggers use siphon mana(bloodmage ability)[side note to get the spell to work properly you have to edit gameplay constants specifically game play - Drain transfers mana = true ]

Sylvanas Start Channel
    Events
        Unit - A unit Begins channeling an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Set mana of (Casting unit) to 99.00%
        Unit - Set mana of (Target unit of ability being cast) to 99.00%
        Player Group - Add (Owner of (Target unit of ability being cast)) to ControlPlayerGroup
        Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Casting unit)) and Retain color
        Unit - Add Control Mana Drain (Sylvanis Scourge) to (Casting unit)
        Unit - Set level of Control Mana Drain (Sylvanis Scourge) for (Casting unit) to (Level of Control (Sylvanas Scourge) for (Casting unit))

aside from the playergroup action every thing works, reason i put the playergroup action in their is that i thought that's how i would bring the unit back to its original owner in another trigger here:

Sylvanas End Channel
    Events
        Unit - A unit Stops casting an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Remove Control Mana Drain (Sylvanis Scourge) from (Casting unit)
        Unit - Change ownership of (Target unit of ability being cast) to (Random player from ControlPlayerGroup) and Retain color

but that didn't work...

So how do i bring the unit back to its original owner after the spell ends?

 

[Accname]

Depends on how the spell is supposed to be used.
Do you have only 1 unit in the entire game which can use the ability? If so just use a Player variable.
Do you have at most 1 unit per player able to use the ability? If so use a Player array and use player numbers as indices.
Do you have an arbitrary number of units per player able to use the ability? If so things get difficult and you will probably need to use hash tables. You use the unit and a constant string, for example "Mind Control" as keys into the table and store the original owner in the table.

 

[sunshinex3]

if every player chooses the scourge race then their can be more than one sylvanis with mind controller but their can't be more than one per player. so your saying i should store... owner of unit into a variable array for players and then... hrm i will continue...

 

[sunshinex3]

could you explain this this: If so use a Player array and use player numbers as indices.

 

[sunshinex3]

this is what i have so far but it still doesn't work.

Sylvanas Start Channel
    Events
        Unit - A unit Begins channeling an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Set mana of (Casting unit) to 99.00%
        Unit - Set mana of (Target unit of ability being cast) to 99.00%
        Player Group - Add (Owner of (Target unit of ability being cast)) to ControlPlayerGroup[1]
        Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Casting unit)) and Retain color
        Unit - Add Control Mana Drain (Sylvanis Scourge) to (Casting unit)
        Unit - Set level of Control Mana Drain (Sylvanis Scourge) for (Casting unit) to (Level of Control (Sylvanas Scourge) for (Casting unit))

and then the end trigger...

Sylvanas End Channel
    Events
        Unit - A unit Stops casting an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Remove Control Mana Drain (Sylvanis Scourge) from (Casting unit)
        Player Group - Pick every player in ControlPlayerGroup[1] and do (Unit - Change ownership of (Target unit of ability being cast) to (Picked player) and Retain color)
        Player Group - Remove all players from ControlPlayerGroup[1]

and yea doesn't work, the target refuses to go back to its original owner.

 

[RanCatu]

Sir/ma'am sunshinex3 is it really necessary that you use a channeling ability? I have one trigger here that I copied from a map but he used faerie fire as a base spell, and it worked perfectly. Just asking, xD.

 

[afisakov]

I think what he meant was to use the array to store the player number of original owner
player array originalowner

Sylvanas Start Channel
set originalowner[player number of owner of unit(casting unit)]=owning player(target unit of ability)

Sylvanas End Channel
unit- change owner of target unit to (originalowner[player number of owner of unit(casting unit)])

sorry it is pseudoscript, but that should explain what you could add to the trigger to track the original unit owner.
However, I am not sure if the channeling will continue once unit ownership changes... that would have to be tested if can siphon mana from allied unit

 

[Accname]

As afisakov wrote. You use a Player typed array and the player number is used as the index into the array. Something like this:

Sylvanas Start Channel
   Events
       Unit - A unit Begins channeling an ability
   Conditions
       (Ability being cast) Equal to Control (Sylvanas Scourge)
   Actions
       Unit - Set mana of (Casting unit) to 99.00%
       Unit - Set mana of (Target unit of ability being cast) to 99.00%
       set MindControlOwner[Player number of (Owner of (Casting unit) )] = Owner of (Target unit of ability being cast)
       Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Casting unit)) and Retain color
       Unit - Add Control Mana Drain (Sylvanis Scourge) to (Casting unit)
       Unit - Set level of Control Mana Drain (Sylvanis Scourge) for (Casting unit) to (Level of Control (Sylvanas Scourge) for (Casting unit))

Sylvanas End Channel
   Events
       Unit - A unit Stops casting an ability
   Conditions
       (Ability being cast) Equal to Control (Sylvanas Scourge)
   Actions
       Unit - Remove Control Mana Drain (Sylvanis Scourge) from (Casting unit)
       Unit - Change ownership of (Target unit of ability being cast) to MindControlOwner[Player number of (Owner of (Casting unit) )] and Retain color

Btw: If you just want a channeled ability and that is why you chose mana drain (you dont actually want to drain mana) then just use the ability Channel. It is an ability which does absolutely nothing. Its only purpose is to be used in triggers.

 

[jonas]

Depends on how the spell is supposed to be used.
Do you have only 1 unit in the entire game which can use the ability? If so just use a Player variable.
Do you have at most 1 unit per player able to use the ability? If so use a Player array and use player numbers as indices.
Do you have an arbitrary number of units per player able to use the ability? If so things get difficult and you will probably need to use hash tables. You use the unit and a constant string, for example "Mind Control" as keys into the table and store the original owner in the table.

no just two arrays
unit array controlled unit
player array owner
integer owned units

use linear search. When deleting an entry, copy the top line to the deleted line.

Fast enough.

 

[sunshinex3]

Doesn't work.?.?
start:

Sylvanas Start Channel
    Events
        Unit - A unit Begins channeling an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Set mana of (Casting unit) to 99.00%
        Unit - Set mana of (Target unit of ability being cast) to 99.00%
        Set ControlPlayerGroup[(Player number of (Owner of (Casting unit)))] = (Owner of (Target unit of ability being cast))
        Unit - Change ownership of (Target unit of ability being cast) to (Owner of (Casting unit)) and Retain color
        Unit - Add Control Mana Drain (Sylvanis Scourge) to (Casting unit)
        Unit - Set level of Control Mana Drain (Sylvanis Scourge) for (Casting unit) to (Level of Control (Sylvanas Scourge) for (Casting unit))

END:

Sylvanas End Channel
    Events
        Unit - A unit Stops casting an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Remove Control Mana Drain (Sylvanis Scourge) from (Casting unit)
        Unit - Change ownership of (Target unit of ability being cast) to ControlPlayerGroup[(Player number of (Owner of (Casting unit)))] and Retain color

Still not working the target stays with the owner of casting unit after the channeling ends.

 

[sunshinex3]

now im testing this on neutral hostile units would that make a difference?

 

[Accname]

There is no "Target unit of Ability being cast" for the event "A unit stops casting an ability". You would need to also store the unit in a variable the same way you store the owner.

 

[sunshinex3]

NICE!!
it worked!! let me post what i have/// Do i have to clear this variable?

Sylvanas Start Channel
    Events
        Unit - A unit Begins channeling an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Set mana of (Casting unit) to 99.00%
        Unit - Set mana of (Target unit of ability being cast) to 99.00%
        Set ControlUnit = (Target unit of ability being cast)
        Set ControlPlayerGroup[(Player number of (Owner of (Casting unit)))] = (Owner of (Target unit of ability being cast))
        Unit - Change ownership of ControlUnit to (Owner of (Casting unit)) and Retain color
        Unit - Add Control Mana Drain (Sylvanis Scourge) to (Casting unit)
        Unit - Set level of Control Mana Drain (Sylvanis Scourge) for (Casting unit) to (Level of Control (Sylvanas Scourge) for (Casting unit))

and end

Sylvanas End Channel
    Events
        Unit - A unit Stops casting an ability
    Conditions
        (Ability being cast) Equal to Control (Sylvanas Scourge)
    Actions
        Unit - Remove Control Mana Drain (Sylvanis Scourge) from (Casting unit)
        Unit - Change ownership of ControlUnit to ControlPlayerGroup[(Player number of (Owner of (Target unit of ability being cast)))] and Retain color

and now that ive gotten it to i will try and get it to work with this standard channel ability.

 

[sunshinex3]

about channel ability i want the manna siphoning effect to trigger doesn't happen with channel, also i want the duration bar to appear like with mana siphon...