"My map worked on westfall but not on 1.24"

[Frozenhelfir]

Posting this because a lot of topics like this will probably appear. It seems that Blizzard has made yet another retarded mistake: http://www.wc3c.net/showpost.php?p=1096978&postcount=12

Sigh... my map has tons of these.

EDIT:

function Callback takes nothing returns boolean
    if true then
        return true
    elseif true then
        return true
    endif
    return true
endfunction

This works, so if you have any functions like that in the post, all of your elseifs need to return something it seems.

 

[LiVam]

It's official: Blizzards hates us.

 

[jwallstone]

The use of the keyword "return" is heavily controlled. The safest way to use it now is to have a local variable for storing the return value, then calling return only at the last line of the function.

 

[woot]

Hmm I don't get it .. what is the "return bug" .. that code looks pretty standard .. what about it is causing the error?

 

[Frozenhelfir]

Hmm I don't get it .. what is the "return bug" .. that code looks pretty standard .. what about it is causing the error?

Blizzard being retarded.

The return bug used to be:

function returns integer
return unit
return 0
endfunction

Stuff like that worked. Now they "fixed" it but made the "standard code" not work.

 

[jwallstone]

Return bug:
http://jass.sourceforge.net/doc/retbug.shtml

 

[woot]

lol wow lame .. especially when newgen checks for such errors

 

[cleeezzz]

>lol wow lame .. especially when newgen checks for such errors

newgen allows the return bug (or it did in 1.23)

 

[woot]

what? really?

newgen never allowed me to return a variable that wasn't the same return type as the function

or am I missing what the return bug is =\

 

[cleeezzz]

it was an exploit so it worked (yea your logic is correct, it shouldn't work, but it did)

 

[Romek]

How stupid.
Does:

function H2I takes handle h returns integer
 return h
 call DoNothing()
 return 0
endfunction

...Still work?

function F takes nothing returns boolean
    if true then
        return true
    elseif true then
    endif
    return true
endfunction

Fail.

 

[SerraAvenger]

it seems returns work only in the last line of the function anymore, is that correct?

 

[cleeezzz]

>romek

in some quick tests, it doesn't seem to work.

probably cuz the new detection is multiple returns.

 

[Tyrande_ma3x]

function F takes nothing returns boolean
    if true then
        return true
    elseif true then
    endif
    return true
endfunction

Wait wait wait, this thing doesn't work any more?

 

[BRUTAL]

i think he meant this

function H2I takes handle h return integer
 return h
 call DoNothing()
 return 0
endfunction

wth is up with that boolean function anyways it looks overlycomplicated

 

[cleeezzz]

>Wait wait wait, this thing doesn't work any more?
yes it does not work

neither does this

function Hi takes integer i returns real
if i > 1 then
    return 5.
elseif i > 2 then
endif
return 2.
endfunction

it seems like if you have nothing in an elseif block, then it will bug because this works.

function Hi takes integer i returns real
if i > 1 then
    return 5.
elseif i > 2 then
    return 6.
endif
return 2.
endfunction

 

[SerraAvenger]

wth is up with that boolean function anyways it looks overlycomplicated

It is just about the return in the if block.

 

[Frozenhelfir]

Try it, my wc3 got a fatal error just trying to host it, let alone start it:

function Callback takes nothing returns boolean
    if true then
        return true
    elseif true then
        return true
    endif
    return true
endfunction

This appears to work...

 

[Tt112233]

function F takes nothing returns boolean
    if true then
        return true
    elseif true then
    endif
    return true
endfunction

Does this mean that if conditions is not to be used when using returns?

 

[cleeezzz]

maybe, people are saying to just use return once at the end of the function

k i think i know one cause

function Hi takes integer i returns real
    local real r
    if i > 1 then
        return 5.
    elseif i > 5 then
        set r = 6.
    endif
    return 0.
endfunction

the above DOES NOT WORK. i believe if you use a return in the IF block, you MUST return something in the ELSEIF. THIS DOES NOT APPLY TO "ELSE" BLOCKS, only ELSEIF

function Hi takes integer i returns real  // WORKS
    local real r
    if i > 1 then
        return 5.
    elseif i > 5 then
        set r = 6.
        return r
    endif
    return 0.
endfunction

function Hi takes integer i returns real // WORKS
    local real r
    if i > 1 then
        set r = 5.
    elseif i > 5 then
        set r = 6.
    endif
    return 0.
endfunction

function Hi takes integer i returns real // WORKS
    local real r
    if i > 1 then
        set r = 5.
    elseif i > 5 then
        set r = 6.
        return r
    endif
    return 0.
endfunction