"My map worked on westfall but not on 1.24"

[Terrabull]

Ummm, doesn't this kinda break every GUI made map as well?

EDIT: Nevermind Cleez's post answers my questions (assuming the examples below it are all valid.

 

[BRUTAL]

^
i dont think so. unless gui maps have that H2I thing : s

 

[Frozenhelfir]

No, gui uses separate if's for every return.

 

[cleeezzz]

Another update, If you use a return in ANY of the IF BLOCKS OR ELSEIF BLOCKS (excluding the last ELSEIF block) then the last ELSEIF must return.

function Hi takes integer i returns real  // DOES NOT WORK
    local real r
    if i > 1 then
        set r = 5
    elseif i > 2 then
        set r = 6.
        return r
    elseif i > 3 then
        set r = 6.
    elseif i > 4 then
        set r = 7.
    endif
    return 0.
endfunction

function Hi takes integer i returns real  // WORKS
    local real r
    if i > 1 then
        set r = 5
    elseif i > 2 then
        set r = 6.
        return r
    elseif i > 3 then
        set r = 6.
    elseif i > 4 then
        set r = 7.
        return r
    endif
    return 0.
endfunction

BTW: these only show what will LOAD the map, it will still probably Critical error after map loads.

 

[MasterOfRa]

what about if there isnt a elseif block?

function Hi takes integer i returns real
    local real r
    if i > 1 then
        return 1
    endif
    return 0.
endfunction

 

[T.s.e]

I and Gwypaas tested the usage of DoNothing, and what'dyaknow, it worked.

 

[cleeezzz]

? whats the code you used to test DoNothing? (you mean to make the return bug?)

 

[Jesus4Lyf]

That's funny.

I'm happy, nothing of my 1.23 stuff bugged on 1.24.

This bytecode stuff just keeps getting worse and worse.. Can arbitrary bytecode be executed through DoNothingReturn bug?

 

[cleeezzz]

glad your systems didn't break but the codes/spells that use your systems probably broke XD

 

[Tt112233]

What if you have an ELSE block not Elseif, does the same bug happen?

 

[Sevion]

Um. I don't know about you guys, but this works:

function Hi takes integer i returns real
if i > 1 then
    return 5.
elseif i > 2 then
endif
return 9999999.
endfunction

I tested multiple times.

Edit: Didn't update via East/West. I used Westfall 1.24.

>_<

I'm going through trouble to update right now. Edit w/ results.

 

[Nestharus]

rofl, I just think this is rich

scope testla initializer ini
    private function I2U takes integer i returns unit
        return i
        call DoNothing()
        return null
    endfunction
    
    private function start takes nothing returns nothing
        local unit u = CreateUnit(Player(0), 'hpea', 0, 0, 270)
        call TriggerSleepAction(5)
        call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "Removing Unit " + GetUnitName(I2U(GetHandleId(u))))
        call RemoveUnit(I2U(GetHandleId(u)))
    endfunction
    
    private function ini takes nothing returns nothing
        call TriggerAddAction(Mfn_ini, function start)
    endfunction
endscope

But at least this doesn't work anymore, so we don't have to worry about virus maps

scope testla initializer ini
    globals
        private constant trigger myCode = CreateTrigger()
    endglobals
    
    private function Code2Int takes code c returns integer
        return c
        call DoNothing()
        return 0
    endfunction
    
    private function Int2Code takes integer i returns code
        return i
        call DoNothing()
        return null
    endfunction
    
    private function displaySomeText takes nothing returns nothing
        call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "Hello World")
    endfunction
    
    private function start takes nothing returns nothing
        call TriggerAddAction(myCode, Int2Code(Code2Int(function displaySomeText)))
        call TriggerExecute(myCode)
    endfunction
    
    private function ini takes nothing returns nothing
        call TriggerAddAction(Mfn_ini, function start)
    endfunction
endscope

That compiles but it doesn't do anything in-game :|

 

[Sevion]

Well, apparently, it's bugged if/then/elseif/endif returns.

 

[Jesus4Lyf]

Nestharus, I'm at work. Try this:

scope testla initializer ini
    globals
        private constant trigger myCode = CreateTrigger()
    endglobals
    
    private function Code2Int takes code c returns integer
        return c
        call DoNothing()
        return 0
    endfunction
    
    private function Int2Code takes integer i returns code
        return i
        call DoNothing()
        return null
    endfunction

private function c2c takes code c returns code
return c
// So that JassHelper doesn't inline this...
call DoNothing()
return c
endfunction
    
    private function displaySomeText takes nothing returns nothing
        call DisplayTextToPlayer(GetLocalPlayer(), 0, 0, "Hello World")
    endfunction

private function dothings takes trigger t, code f returns nothing
call TriggerAddAction(t,f)
call DoNothing() // no inline
endfunction
    
    private function start takes nothing returns nothing
local code f=c2c(Int2Code(Code2Int(function displaySomeText)))
        call dothings(myCode, f)
        call TriggerExecute(myCode)
    endfunction
    
    private function ini takes nothing returns nothing
        call TriggerAddAction(Mfn_ini, function start)
    endfunction
endscope

 

[SwedishChef]

I dont understand I use zero jass in my two maps, but i use newgen and egui. Might it be any of the added triggers by egui or newgen that is causing my bugs to freak out??

 

[Jesus4Lyf]

Yes. EGUI.

 

[SwedishChef]

Yes. EGUI.

Okey and the only thing i ues there is the error message and show message for one player i think. Oh and player (any) does event.

 

[Sevion]

1.24 Broke 99.99% of all resources.

 

[Troll-Brain]

So wait, if i've understood all your tests, test if the map is loading is not enough ?
We have to test the code if it doesn't crash war3 when it is executed ?!

Also i just want to point out that you need to test it with debug mode "on" and "off" (ofc if you use vJass), because sometimes it does matter.

 

[MasterOfRa]

1.24 Broke 99.99% of all resources.

i didn't know there were 10000 resources , i fixed my map, though it still doesn't completely work, but blizzard needs to simply make the compiler look at all return statements, and see if they return the correct type, wouldn't that work better?