Need help with item trigger

Vylatin

Vylatin

New Member
Reaction score
32
Hey :)

Could anyone show me how to through GUI triggers; check if unit has 2 items of artifact/powerup/miscellaneous class? My trigger below failed, probably cus the hero already got the item when it runs. Thats why I need help. Or do you got a better solution? Any help is great! +rep

Pick up
Events
Unit - A unit Acquires an item
Conditions
Or - Any (Conditions) are true
Conditions
(Item-class of (Item being manipulated)) Equal to Artifact
(Item-class of (Item being manipulated)) Equal to Powerup
(Item-class of (Item being manipulated)) Equal to Miscellaneous
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
Or - Any (Conditions) are true
Conditions
((Triggering unit) has an item of type |cffffcc00Iron Bow|r) Equal to True
((Triggering unit) has an item of type |cffffcc00Steel Bow|r) Equal to True
Then - Actions
Hero - Drop (Item being manipulated) from (Triggering unit)
Else - Actions
 
Exide

Exide

I am amazingly focused right now!
Reaction score
448
If I understood you right, you want to prevent a unit from carrying two items of the same class? (For example only letting a hero carry one sword, one shield, one armor, etc.)

I made an old trigger once (which I quickly improved slightly just now) that prevents this:

JASS:

function Trig_Special_Items_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local item newitem = GetManipulatedItem()
    local integer i = 0
    
    
    if (GetItemType(newitem) == ITEM_TYPE_ARTIFACT) then
        loop
            exitwhen loopnr >= 6
            if (GetItemType(UnitItemInSlot(u, loopnr)) == ITEM_TYPE_ARTIFACT ) and (UnitItemInSlot(u, loopnr) != newitem) then
                call DisplayTextToPlayer(p, o, o, "You are already wielding a Weapon!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif

    if (GetItemType(newitem) == ITEM_TYPE_PERMANENT) then
        loop
            exitwhen loopnr >= 6
            if (GetItemType(UnitItemInSlot(u, loopnr)) == ITEM_TYPE_ARTIFACT ) and (UnitItemInSlot(u, loopnr) != newitem) then
                call DisplayTextToPlayer(p, o, o, "You are already carrying a Shield!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif

    if (GetItemType(newitem) == ITEM_TYPE_CAMPAIGN) then
        loop
            exitwhen loopnr >= 6
            if (GetItemType(UnitItemInSlot(u, loopnr)) == ITEM_TYPE_ARTIFACT ) and (UnitItemInSlot(u, loopnr) != newitem) then
                call DisplayTextToPlayer(p, o, o, "You are already wearing an Armor!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif
    

    set newitem = null
    set p = null
    set u = null
endfunction

//===========================================================================
function InitTrig_Special_Items takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_PICKUP_ITEM)
    call TriggerAddAction(t, function Trig_Special_Items_Actions)
endfunction


Not syntax-checked.

Implement:
Create a trigger, name it Special Items, convert it to custom text, replace the text with my code.

Artifact = Weapon
Permanent = Shield
Campaign = Armor
 
Vylatin

Vylatin

New Member
Reaction score
32
I converted and replaced the text with your code.

But it doesn't work as I get loads of errors;

9 "expected a name" and 3 "Expected endloop"

I'm probably forgetting something?

I really apreciate ur help :)
 
Exide

Exide

I am amazingly focused right now!
Reaction score
448
No, it's my bad.
Like I said, I haven't syntax-checked it after I improved the code, so I forgot a few things.
This should work better:

JASS:

function Trig_Special_Items_Actions takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local player p = GetOwningPlayer(u)
    local item newitem = GetManipulatedItem()
    local integer i = 0
    
    
    if (GetItemType(newitem) == ITEM_TYPE_ARTIFACT) then
        loop
            exitwhen i >= 6
            if (GetItemType(UnitItemInSlot(u, i)) == ITEM_TYPE_ARTIFACT ) and (UnitItemInSlot(u, i) != newitem) then
                call DisplayTextToPlayer(p, 0, 0, "You are already wielding a Weapon!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif

    if (GetItemType(newitem) == ITEM_TYPE_PERMANENT) then
        loop
            exitwhen i >= 6
            if (GetItemType(UnitItemInSlot(u, i)) == ITEM_TYPE_PERMANENT) and (UnitItemInSlot(u, i) != newitem) then
                call DisplayTextToPlayer(p, 0, 0, "You are already carrying a Shield!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif

    if (GetItemType(newitem) == ITEM_TYPE_CAMPAIGN) then
        loop
            exitwhen i >= 6
            if (GetItemType(UnitItemInSlot(u, i)) == ITEM_TYPE_CAMPAIGN) and (UnitItemInSlot(u, i) != newitem) then
                call DisplayTextToPlayer(p, 0, 0, "You are already wearing an Armor!")
                call UnitRemoveItem(u, newitem)
            endif
            set i = i + 1
        endloop
    endif
    

    set newitem = null
    set p = null
    set u = null
endfunction

//===========================================================================
function InitTrig_Special_Items takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterAnyUnitEventBJ(t, EVENT_PLAYER_UNIT_PICKUP_ITEM)
    call TriggerAddAction(t, function Trig_Special_Items_Actions)
endfunction


Tell me if you get any more errors.
 
Vylatin

Vylatin

New Member
Reaction score
32
From 12 errors to 3 :)

call DisplayTextToPlayer(p, o, o, "You are already wielding a Weapon!")

call DisplayTextToPlayer(p, o, o, "You are already carrying a Shield!")

call DisplayTextToPlayer(p, o, o, "You are already wearing an Armor!")

Expected a name on those lines
 
Exide

Exide

I am amazingly focused right now!
Reaction score
448
Trying to write JASS from on top of your head is a bad idea. :p

It should be:
call DisplayTextToPlayer(p, 0, 0, "You are already wielding a Weapon!")
call DisplayTextToPlayer(p, 0, 0, "You are already carrying a Shield!")
call DisplayTextToPlayer(p, 0, 0, "You are already wearing an Armor!")

-change o to 0 (zero).
My fingers must've slipped. :p
 
Vylatin

Vylatin

New Member
Reaction score
32
Hey, it works almost perfect.

I can carry 1 artifact item, which is perfect. If I pick up a new artifact item, it is instantly dropped.

When I pick up more than 1 campaign/permanent item nothing happens.

I don't see why :X
 
You must log in or register to reply here.
General chit-chat
Help Users
  • No one is chatting at the moment.
  • Varine Varine:
    How can you tell the difference between real traffic and indexing or AI generation bots?
  • The Helper The Helper:
    The bots will show up as users online in the forum software but they do not show up in my stats tracking. I am sure there are bots in the stats but the way alot of the bots treat the site do not show up on the stats
  • The Helper The Helper:
    New recipe is Shipwreck Dinner - https://www.thehelper.net/threads/recipe-shipwreck-dinner.193511/
  • Varine Varine:
    I want to build a filtration system for my 3d printer, and that shit is so much more complicated than I thought it would be
  • Varine Varine:
    Apparently ABS emits styrene particulates which can be like .2 micrometers, which idk if the VOC detectors I have can even catch that
  • Varine Varine:
    Anyway I need to get some of those sensors and two air pressure sensors installed before an after the filters, which I need to figure out how to calculate the necessary pressure for and I have yet to find anything that tells me how to actually do that, just the cfm ratings
  • Varine Varine:
    And then I have to set up an arduino board to read those sensors, which I also don't know very much about but I have a whole bunch of crash course things for that
  • Varine Varine:
    These sensors are also a lot more than I thought they would be. Like 5 to 10 each, idk why but I assumed they would be like 2 dollars
  • Varine Varine:
    Another issue I'm learning is that a lot of the air quality sensors don't work at very high ambient temperatures. I'm planning on heating this enclosure to like 60C or so, and that's the upper limit of their functionality
  • Varine Varine:
    Although I don't know if I need to actually actively heat it or just let the plate and hotend bring the ambient temp to whatever it will, but even then I need to figure out an exfiltration for hot air. I think I kind of know what to do but it's still fucking confusing
  • The Helper The Helper:
    Maybe you could find some of that information from AC tech - like how they detect freon and such
  • Varine Varine:
    That's mostly what I've been looking at
  • Varine Varine:
    I don't think I'm dealing with quite the same pressures though, at the very least its a significantly smaller system. For the time being I'm just going to put together a quick scrubby box though and hope it works good enough to not make my house toxic
  • Varine Varine:
    I mean I don't use this enough to pose any significant danger I don't think, but I would still rather not be throwing styrene all over the air
  • The Helper The Helper:
    New dessert added to recipes Southern Pecan Praline Cake https://www.thehelper.net/threads/recipe-southern-pecan-praline-cake.193555/
  • The Helper The Helper:
    Another bot invasion 493 members online most of them bots that do not show up on stats
  • Varine Varine:
    I'm looking at a solid 378 guests, but 3 members. Of which two are me and VSNES. The third is unlisted, which makes me think its a ghost.
     +1
  • The Helper The Helper:
    Some members choose invisibility mode
     +1
  • The Helper The Helper:
    Latest Recipe is Garlic Parmesan Chicken https://www.thehelper.net/threads/recipe-garlic-parmesan-chicken.193575/
  • The Helper The Helper:
    I bitch about Xenforo sometimes but it really is full featured you just have to really know what you are doing to get the most out of it.
  • The Helper The Helper:
    It is just not easy to fix styles and customize but it definitely can be done
  • The Helper The Helper:
    I do know this - xenforo dropped the ball by not keeping the vbulletin reputation comments as a feature. The loss of the Reputation comments data when we switched to Xenforo really was the death knell for the site when it came to all the users that left. I know I missed it so much and I got way less interested in the site when that feature was gone and I run the site.
  • Blackveiled Blackveiled:
    People love rep, lol
     +1
  • The Helper The Helper:
    The recipe today is Sloppy Joe Casserole - one of my faves LOL https://www.thehelper.net/threads/sloppy-joe-casserole-with-manwich.193585/
  • The Helper The Helper:
    Decided to put up a healthier type recipe to mix it up - Honey Garlic Shrimp Stir-Fry https://www.thehelper.net/threads/recipe-honey-garlic-shrimp-stir-fry.193595/

      The Helper Discord

      Staff online

      Members online

      Online now:
      314 (members: 1, guests: 313)

      Share this page

      Affiliates

      Hive Workshop NUON Dome World Editor Tutorials

      Network Sponsors

      Apex Steel Pipe - Buys and sells Steel Pipe.
      Top