OMG I Have A Question!!!

[Darg]

I'm currently working on the local variable death trigger thing for darkassaisin, but I've hit a bump.

Can someone paste this code into a trigger in a blank map and tell me what I'm doing wrong:

function Trig_a_unit_dies_Actions takes nothing returns nothing
    local unittype udg_DeadUnitType
    local location udg_DeadUnitLocation
    local player udg_DeadUnitOwner
    set udg_DeadUnitType = GetUnitTypeId(GetDyingUnit())
    set udg_DeadUnitLocation = GetUnitLoc(GetDyingUnit())
    set udg_DeadUnitOwner = GetOwningPlayer(GetDyingUnit())
    call TriggerSleepAction( 60.00 )
    call CreateNUnitsAtLoc( 1, udg_DeadUnitType, udg_DeadUnitOwner, udg_DeadUnitLocation, bj_UNIT_FACING )

//===========================================================================
function InitTrig_a_unit_dies takes nothing returns nothing
    set gg_trg_a_unit_dies = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_a_unit_dies, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_a_unit_dies, function Trig_a_unit_dies_Actions )
endfunction

The map doesn't like my local variable declaration of the unit-type and I don't know why (that's the first line in the trigger if you can't see it)

maybe sats you can work on this thing while I work on your thing hehe

 

[sATARa]

Ohhhh man.
Darg, you`re supposed to be the guy with all the answers around here hehe.

K Ill give it a shot, but no promises. I, well... uhh... Im not really that good with JASS. But Ill do my best.

Whats the trigger supposed to do anyway?

 

[sATARa]

Ok, I wont pretend I have any idea how to fix this, but...
I was thinking, why do you need local variables. Couldnt you just
pass what they are supposed to be directly into the function
"call CreateNUnitsAtLoc" ?

And what does the "TriggerSleepAction" do?

 

[Darg]

yeah its my fault, I should have explained what the thing does hehe

When any unit dies, the trigger waits 60 secs, and then creates another unit of the same type at the same place that other unit died.

Local variables are needed beacuse many units might die at the one time.

TriggerSleepAction = wait

CreateNUnitsAtLoc = create N <unit-type> at <some location> facing <some angle>

AddSpecialEffectTargetUnitBJ = add special effect attached to unit

 

[sATARa]

Ehhh, Darg...
I think I did it, but... lol I used GUI
A unit dies
Events
Unit - A unit Dies
Conditions
Actions
Wait 25.00 seconds
Unit - Create 1 (Unit-type of (Triggering unit)) for (Triggering player) at (Position of (Triggering unit)) facing Default building facing degrees

Anyway, you still wouldnt need variables, couse when ever a trigger runs its treated as a seperate trigger, as it seems.

Stop smashing your head to the wall, its not worth it

 

[Darg]

ok you're right, guess I'm a dumbass for not testing it.

I put the wait at 120 seconds (as per what darkassaisin wants), and it also worked. This is a good thing, because it meant that the trigger still kept the unit information in there well after the unit's corpse had disappeared from the battlefield.

so here is the trigger for you darkassasin:

someone dies
    Events
        Unit - A unit Dies
    Conditions
    Actions
        Game - Display to (All players) for 3.00 seconds the text: dead
        Wait 120.00 game-time seconds
        Game - Display to (All players) for 3.00 seconds the text: life
        Unit - Create 1 (Unit-type of (Dying unit)) for (Owner of (Dying unit)) 
        at (Position of (Dying unit)) 
        facing Default building facing degrees

 

[Darg]

An interesting thing I've found out is that declaring more than 1 local global variable in the one trigger can't be done, its a bug which makes the game crash.

e.g.

someone dies
    Events
        Unit - A unit Dies
    Conditions
    Actions
        Custom script:   local integer udg_DeadUnitType
        Set DeadUnitType = (Unit-type of (Dying unit))

is ok.

someone dies
    Events
        Unit - A unit Dies
    Conditions
    Actions
        Custom script:   local integer udg_DeadUnitType
        Custom script:   local location udg_DeadUnitLocation
        Set DeadUnitType = (Unit-type of (Dying unit))
        Set DeadUnitLocation = (Position of (Dying unit))

crashes the game.

 

[sATARa]

Damn strange..

 

[darkassaisin]

thanks but should i use it if it crashes it? and u cussed i m gonna report u to a mod lol u r a mod but really do i use that trigger?

 

[darkassaisin]

it crashes it becausesATaRa told me that if a gate is open it is dead and there r many open gates on there and it keeps doing the trigger till it crashses i had a problem similar to this when Du had a map when u step in a region it transports u to another region which transports u back to the other one so it was going back and forth till it crashed same here the gates keep being remade

 

[sATARa]

Well why would this have anything to do with gates? Am I missing something?
This trigger should work just fine:

code:-----------------------------------------------------------------------------
someone dies
Events
Unit - A unit Dies
Conditions
Actions
Game - Display to (All players) for 3.00 seconds the text: dead
Wait 120.00 game-time seconds
Game - Display to (All players) for 3.00 seconds the text: life
Unit - Create 1 (Unit-type of (Dying unit)) for (Owner of (Dying unit))
at (Position of (Dying unit))
facing Default building facing degrees

Although I`ve noticed that it doesnt work for flying units, at least it didnt when I tested it.

 

[SD_Ryoko]

Originally posted by sATARa

Although I`ve noticed that it doesnt work for flying units, at least it didnt when I tested it.

Um... I think thats because of the decay time. While a unit decays, it still qualifies for 'dying unit' in the trigger code. You can still manipulate it.

Flyers die fast and hard. Therefore, 120 seconds later, the dying unit is gone and no longer applies.

I had some trouble in that area. I had to use a unit store.

Set unit_type = Unit type of (dying unit)

Then later say....

Create 1 unit_type.....

Etc.

 

[darkassaisin]

so m i using variables?

 

[sATARa]

NOPE

 

[Darg]

no variables!

Flyers die fast and hard. Therefore, 120 seconds later, the dying unit is gone and no longer applies.

You missed my previous comment Ryoko:

I put the wait at 120 seconds (as per what darkassaisin wants), and it also worked. This is a good thing, because it meant that the trigger still kept the unit information in there well after the unit's corpse had disappeared from the battlefield.

I'm pretty sure the reason it doesn't work for flying units is because flying units don't leave corpses. As you said, they die "fast and hard". Can anyone verify that a spell like animate dead can resurrect flyers? I can't remember if it can or not.

Oh yeah, and the "magical" property that sets apart flying units from ground units is the absence of a "decay" animation. Check the animations for yourself, you'll notice all flyers don't decay.

 

[darkassaisin]

ok a few things sATARa, the trigger u used was the same as the trigger i had before but i will check and do it agin, and i m not going to put flying units in my map cause many of the units r melee and i decided to change the wait time to 60 seconds which may help and can i use the trigger that sATARa made or r we not done finding one yet?

 

[sATARa]

Ok, to avoid any confusion here`s what you do...
First of all, this has nothing to do with gates, use those triggers freely as I showed you before.
This trigger should work just fine, and do what Darg told me it should do...

A unit dies
Events
Unit - A unit Dies
Conditions
Actions
Wait 60.00 seconds
Unit - Create 1 (Unit-type of (Triggering unit)) for (Triggering player) at (Position of (Triggering unit)) facing Default building facing degrees

I think you must use the triggering unit n triggering player insted of dying unit, because many units die... but Im not sure, I havent tried it.
Just use the above trigger, and add some of the text stuff and effects if you like.

 

[darkassaisin]

k thx the trigger works

 

[Betray]

Memory Usage? Observation..

Since as you say the units are stored in memory well after the corpse is removed from the battlefield.. would this over time of a spawning type map slowly create a huge memory storage and cause problems with lag/server splits?

 

[sATARa]

A unit is stored in memory as long as its corpse exists. Once it disappears, the unit is removed from memory. The only time it stays in memory, is if it was created by a trigger action "create unit..." ... but in that case after the unit corpse decays, the unit itself becomes untrackable, meaning "lost in memory". In other words, a memory leak.