One memory leak problem

[Lordbevan]

Unit - Create 3 Soldier for Player 1 (Red) at (Center of Spawn <gen>) facing Default building facing (270.0) degrees

Does this cause a leak? Its spawn at a region not a point. But accoring to one post i read, it is also a leak?

 

[AceHart]

The center of a region IS a point. So, yes.

 

[Lordbevan]

LOL Then you guys should say create a unit is automatically going to cause a leak, instead of using a jargon thing such as a point.

 

[Darg]

it wouldn't be right to say that because we want to be as specific as possible in the information we tell you, so saying "creating a unit leaks" is far too generic to be of any use to anyone.

As I used to say, you shouldn't be obsessive about leaks, just assign things like that into temp global variables - that way you don't need to care about the issue at all. I don't think a few people liked this advice the last time I gave it, so don't use it if it doesn't suit your taste.

 

[Heptameron]

LOL Then you guys should say create a unit is automatically going to cause a leak, instead of using a jargon thing such as a point.

But that's not true.

This part:

(Center of Spawn <gen>)

causes the leak. Whenever you have a Center Of Region or nearly any other function that returns a point you will have a leak... except if you set a global variable to that and never change the variable. That won't leak, simply because the function is only called once.

 

[Lordbevan]

Okay so if i have 1 spawn trigger that runs everytime, I do this:

Set Tempoint1=centre of spawn<gen>
then make the spawn at tempoint1 and there wont be a leak right?

 

[AceHart]

So they say, yes.
Same for unit-groups btw.

 

[Persen]

I suggest you do a "call RemoveLocation(udg_temppoint1)" afterwards to further prevent leaks.

 

[Darg]

but why is that necessary if he puts it into a global variable? there is a handle attached to the point so the point is not going anywhere and so won't leak.

btw does RemoveLocation destroy the variable itself or does it remove the reference to the point made by the variable? because if its the former, thats not a very good idea.

 

[phyrex1an]

but why is that necessary if he puts it into a global variable? there is a handle attached to the point so the point is not going anywhere and so won't leak.

Depends.
If you overwrite the vaule of the variable the point is lost and is leaking.
So if you dont have a problem with having tons of globals, initilize them at the beginig and never change them you dont need to remove them. If you want to change the variable sometime in the game you have to remove the previus vaule.

btw does RemoveLocation destroy the variable itself or does it remove the reference to the point made by the variable? because if its the former, thats not a very good idea.

It removes the point, not the reference not the variable. So the variable will still pointing to the place in the memory where the point was, but the point doesnt exist. (This is why you have to null local variables so the reference dissaperes)