Spell Panda Roll

[Kenny]

// How much damage is taken, per second.
private constant function BURNDAMAGE_AMOUNT takes integer level returns real
    return level * 100.
    // 100, 200, 300
endfunction

Must have overlooked it.

Anywho, version 2 seems pretty dead on. Nice work.

 

[Uberplayer]

private static method Cond takes nothing returns boolean
    return GetIssuedOrderId() == OrderId("move") or GetIssuedOrderId() == OrderId("smart") or GetIssuedOrderId() == OrderId("patrol") or GetIssuedOrderId() == OrderId("attack") and IsUnitInGroup(GetTriggerUnit(), Casters)
endmethod

-->

private static method Cond takes nothing returns boolean
    local integer id = GetIssuedOrderId()
    return id == OrderId("move") or id == OrderId("smart") or id == OrderId("patrol") or id == OrderId("attack") and IsUnitInGroup(GetTriggerUnit(), Casters)
endmethod

Awesome.

 

[Romek]

private static method Cond takes nothing returns boolean
    return GetIssuedOrderId() == OrderId("move") or GetIssuedOrderId() == OrderId("smart") or GetIssuedOrderId() == OrderId("patrol") or GetIssuedOrderId() == OrderId("attack") and IsUnitInGroup(GetTriggerUnit(), Casters)
endmethod

-->

private static method Cond takes nothing returns boolean
    local integer id = GetIssuedOrderId()
    return id == OrderId("move") or id == OrderId("smart") or id == OrderId("patrol") or id == OrderId("attack") and IsUnitInGroup(GetTriggerUnit(), Casters)
endmethod

Awesome.

Such a minor change
Thanks anyway

 

[Viikuna]

Well, you should try to use as few function calls as you can

 

[Leazy]

Awesome spell, very original (never seen a spell like this before) and fun to use. +rep. However, when I use it when already rolling it gets fucked up, harder to controll and the roll unit will be the normal panda. Try to use it when already rolling to see what I mean.

 

[Romek]

Awesome spell, very original (never seen a spell like this before) and fun to use. +rep. However, when I use it when already rolling it gets fucked up, harder to controll and the roll unit will be the normal panda. Try to use it when already rolling to see what I mean.

I know. Just make the duration shorter than the cooldown, or the cooldown longer than the duration (Yes, they're the same thing).

Thanks anyway

 

[Leazy]

I know. Just make the duration shorter than the cooldown, or the cooldown longer than the duration (Yes, they're the same thing).

Thanks anyway

Ah alright, however, what if you have a refresher type of item (Item that refreshes all cooldowns). Maybe add something that prevents the unit to cast the spell again if he's already casting it?

 

[Romek]

Then Disable the ability when it's cast, wait the duration, and re-enable it after.
I don't think it's necessary to make a new trigger just for that

 

[Leazy]

Then Disable the ability when it's cast, wait the duration, and re-enable it after.
I don't think it's necessary to make a new trigger just for that

Still, it would not hurt to just add a buff to the spell, and if you have the buff stop casting unit (could be done afterwards by any GUI-er to tough) so nvm.

 

[Romek]

Bump. I checked the PandaBall spell over at Wc3C. I prefer my one. The bounce isn't amazing . Especially how it bounces off everything!

I might add a bounce in, only off cliffs and boundry though.

 

[Charapanga]

Awsome job Romek, I'm still a newbie at making spells, but i hope i will be one day as good as you, i'm still making primitive spells with GUI, i just can't seem to learn JASS and I've read almost all of the tutorials, but you know what they say, when you fall off a horse, you gotta go right back on it

Five stars man!

 

[Romek]

Awsome job Romek, I'm still a newbie at making spells, but i hope i will be one day as good as you, i'm still making primitive spells with GUI, i just can't seem to learn JASS and I've read almost all of the tutorials, but you know what they say, when you fall off a horse, you gotta go right back on it

Five stars man!

Thanks!
About Jass, all I can say is:

• Get Newgen. The highlighting, globals and function list are awesome (Especially for beginners)
• Keep practising
• Read over some simple codes, systems, snippets and spells

 

[Flare]

boolexpr bool

Ahm... where exactly is that boolexpr being used (it's the one in the struct) - I can't seem to find it, so I'm beginning to suspect it's a bit useless

And why exactly do you bother with a group member for the TimedEffect struct? You could just use a global group (it is only a temporary group) since there's no requirement to keep track of units for the duration of the instance
Same applies to the group member of the spell struct, it appears to be used in same way, so global group would easily work just fine instead
And!

call GroupRemoveUnit(a.G, u)
call GroupClear(a.G)

That's a bit pointless, don't you think? The group is going to be emptied as a result of the FirstOfGroup loop, so why bother clearing it after when it's already empty?

 

[Romek]

boolexpr bool

Ahm... where exactly is that boolexpr being used (it's the one in the struct) - I can't seem to find it, so I'm beginning to suspect it's a bit useless

That's really odd. I'm sure there was a use for it somewhere, at some time.

And why exactly do you bother with a group member for the TimedEffect struct? You could just use a global group (it is only a temporary group) since there's no requirement to keep track of units for the duration of the instance
Same applies to the group member of the spell struct, it appears to be used in same way, so global group would easily work just fine instead

Made the groups static .

And!

call GroupRemoveUnit(a.G, u)
call GroupClear(a.G)

That's a bit pointless, don't you think? The group is going to be emptied as a result of the FirstOfGroup loop, so why bother clearing it after when it's already empty?

I agree. I don't know why I put that there either.. :nuts:

Updated

 

[Andrewgosu]

Excellently coded and carried through spell!

You make the Pandaren proud!


Resource approved, for the Pandaren!

 

[Romek]

Excellently coded and carried through spell!

You make the Pandaren proud!


Resource approved, for the Pandaren!

Thanks!

 

[tooltiperror]

Jus an idea, why not make it play the "I bring Pandemonium!" sound on cast, would be a nice addition.

 

[Ice Snake]

awesome spell, but... it works on 1.24 ??

 

[kingkingyyk3]

awesome spell, but... it works on 1.24 ??

Update ABC.

 

[Ice Snake]

Update ABC.

woa! thanks!